Skip to content

Commit a41f31c

Browse files
authored
Update changelogs (#56)
* Update changelog link * Add pretty assertions Makes seeing test differences easier * Update jruby changelog link * Expected on the left In ruby expected comes before actual. Swap the order of the assertions. * Fix tests and don't break newline
1 parent a6da00d commit a41f31c

File tree

5 files changed

+34
-6
lines changed

5 files changed

+34
-6
lines changed

Cargo.lock

+24-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

+1
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,4 @@ libherokubuildpack = { version = "0.24.0", default-features = false, features =
3434
# File locking (FLOCK)
3535
fs2 = "0.4"
3636

37+
pretty_assertions = "1.4.1"

jruby_executable/src/bin/jruby_changelog.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ fn jruby_changelog(args: &Args) -> Result<(), Box<dyn Error>> {
2222
let changelog = formatdoc! {"
2323
## JRuby version {version} is now available
2424
25-
[JRuby v{version}](/articles/ruby-support#ruby-versions) is now available on Heroku. To run
25+
[JRuby v{version}](/articles/ruby-support-reference#ruby-versions) is now available on Heroku. To run
2626
your app using this version of Ruby, add the following `ruby` directive to your Gemfile:
2727
2828
```ruby

ruby_executable/Cargo.toml

+3
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,6 @@ libherokubuildpack = { workspace = true }
2121
chrono = { workspace = true }
2222
sha2 = { workspace = true }
2323
gem_version = { workspace = true }
24+
25+
[dev-dependencies]
26+
pretty_assertions = { workspace = true }

ruby_executable/src/bin/ruby_changelog.rs

+5-4
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ where
2929
let changelog = formatdoc! {"
3030
## Ruby version {version} is now available
3131
32-
[Ruby v{version}](/articles/ruby-support#ruby-versions) is now available on Heroku. To run
32+
[Ruby v{version}](/articles/ruby-support#ruby-versions) is now available on Heroku. To run \
3333
your app using this version of Ruby, add the following `ruby` directive to your Gemfile:
3434
3535
```ruby
@@ -72,6 +72,7 @@ fn main() {
7272
#[cfg(test)]
7373
mod test {
7474
use super::*;
75+
use pretty_assertions::assert_eq;
7576

7677
#[test]
7778
fn regular_release() {
@@ -86,7 +87,7 @@ mod test {
8687
8788
## Ruby version 3.3.2 is now available
8889
89-
[Ruby v3.3.2](/articles/ruby-support#ruby-versions) is now available on Heroku. To run
90+
[Ruby v3.3.2](/articles/ruby-support#ruby-versions) is now available on Heroku. To run \
9091
your app using this version of Ruby, add the following `ruby` directive to your Gemfile:
9192
9293
```ruby
@@ -95,7 +96,7 @@ mod test {
9596
9697
For more information on [Ruby 3.3.2, you can view the release announcement](https://www.ruby-lang.org/en/news/).
9798
"};
98-
assert_eq!(actual.trim(), expected.trim());
99+
assert_eq!(expected.trim(), actual.trim());
99100
}
100101

101102
#[test]
@@ -111,7 +112,7 @@ mod test {
111112
112113
## Ruby version 3.1.0-rc1 is now available
113114
114-
[Ruby v3.1.0-rc1](/articles/ruby-support#ruby-versions) is now available on Heroku. To run
115+
[Ruby v3.1.0-rc1](/articles/ruby-support#ruby-versions) is now available on Heroku. To run \
115116
your app using this version of Ruby, add the following `ruby` directive to your Gemfile:
116117
117118
```ruby

0 commit comments

Comments
 (0)