Skip to content

Commit 70a4885

Browse files
committed
#16 Rename test classes and test methods
class name: `Test<Type>_<MethodName>` method name: `test_<StateOrParams>`
1 parent 243c96d commit 70a4885

File tree

2 files changed

+30
-20
lines changed

2 files changed

+30
-20
lines changed

w3/python/core/fundamental_interface/NodeList_test.py

Lines changed: 21 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -34,47 +34,57 @@ def _make_nodes(n: int, document: Optional[Node] = None) -> Iterator[Node]:
3434
yield _create_text_node(document)
3535

3636

37-
class Test_Dunder(unittest.TestCase):
38-
def testInit_Empty(self):
37+
class TestDunder_Init(unittest.TestCase):
38+
def test_EmptyList(self):
3939
NodeList()
4040

41-
def testInit_SingleNode(self):
41+
def test_SingleNode(self):
4242
node = next(_make_nodes(1))
4343
NodeList([node])
4444

45-
def testInit_MultipleNodes(self):
45+
def test_MultipleNodes(self):
4646
NodeList(_make_nodes(4))
4747

48-
def testIter(self):
48+
49+
class TestDunder_Iter(unittest.TestCase):
50+
def test_ForLoop(self):
4951
nodes = [*_make_nodes(4)]
5052
node_list = NodeList(nodes)
5153
# Create an iterator for checking
5254
node_iter = iter(nodes)
5355
for list_elem in node_list:
5456
self.assertEqual(list_elem, next(node_iter))
5557

56-
def testBool(self):
58+
59+
class TestDunder_Bool(unittest.TestCase):
60+
def test_Raw(self):
5761
# Empty `NodeList` should equal False.
5862
node_list = NodeList()
5963
self.assertFalse(node_list)
6064
# `NodeList` with items should equal True.
6165
node_list = NodeList(_make_nodes(2))
6266
self.assertTrue(node_list)
6367

64-
def testGetItem(self):
68+
69+
class TestDunder_GetItem(unittest.TestCase):
70+
def test_IntegerIndex(self):
6571
nodes = [*_make_nodes(4)]
6672
node_list = NodeList(nodes)
6773
for i in range(4):
6874
self.assertEqual(node_list[i], nodes[i])
6975

70-
def testSetItem(self):
76+
77+
class TestDunder_SetItem(unittest.TestCase):
78+
def test_IntegerIndex(self):
7179
document = _create_document_node()
7280
text_node = _create_text_node(document)
7381
node_list = NodeList(_make_nodes(4, document))
7482
node_list[2] = text_node
7583
self.assertEqual(node_list[2], text_node)
7684

77-
def testContains(self):
85+
86+
class TestDunder_Contains(unittest.TestCase):
87+
def test_In(self):
7888
nodes = [*_make_nodes(4)]
7989
node_list = NodeList(nodes)
8090
for n in node_list:
@@ -87,7 +97,7 @@ def testContains_NotIn(self):
8797
self.assertNotIn(external_node, node_list)
8898

8999

90-
class Test_Length(unittest.TestCase):
100+
class TestProperty_Length(unittest.TestCase):
91101
def test_Empty(self):
92102
node_list = NodeList()
93103
self.assertEqual(node_list.length, 0)
@@ -101,7 +111,7 @@ def test_SomeItems(self):
101111
self.assertEqual(node_list.length, 5)
102112

103113

104-
class Test_Item(unittest.TestCase):
114+
class TestMethod_Item(unittest.TestCase):
105115
def test_InSize(self):
106116
nodes = [*_make_nodes(5)]
107117
node_list = NodeList(nodes)

w3/python/core/fundamental_interface/Node_test.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ def _create_element_node(document: Node):
1818
owner_document=document)
1919

2020

21-
class Test_Dunder(unittest.TestCase):
22-
def testInit(self):
21+
class TestDunder_Init(unittest.TestCase):
22+
def test_Default(self):
2323
# Creating document node.
2424
document = Node(node_type=NodeType.DOCUMENT_NODE,
2525
node_name='#document',
@@ -30,7 +30,7 @@ def testInit(self):
3030
self.assertEqual(document.node_value, '')
3131

3232

33-
class Test_NodeValue(unittest.TestCase):
33+
class TestProperty_NodeValue(unittest.TestCase):
3434
def testGetter(self):
3535
document = _create_document_node()
3636
text = Node(node_type=NodeType.TEXT_NODE,
@@ -75,7 +75,7 @@ def testSetter_ReadOnly(self):
7575
self.assertEqual(text.node_value, 'foo')
7676

7777

78-
class Test_NodeType(unittest.TestCase):
78+
class TestProperty_NodeType(unittest.TestCase):
7979
def testGetter(self):
8080
document = _create_document_node()
8181
for node_type in NodeType:
@@ -103,7 +103,7 @@ def testSetter_WrongTypes(self):
103103
pass
104104

105105

106-
class Test_ParentNode(unittest.TestCase):
106+
class TestProperty_ParentNode(unittest.TestCase):
107107
def testConstrutor(self):
108108
document = _create_document_node()
109109
docfrag = Node(node_type=NodeType.DOCUMENT_FRAGMENT_NODE,
@@ -131,7 +131,7 @@ def testSetter_Raises_Exception(self):
131131
self.fail()
132132

133133

134-
class Test_InsertBefore(unittest.TestCase):
134+
class TestMethod_InsertBefore(unittest.TestCase):
135135
def test_WithoutRefNode(self):
136136
# ======================================
137137
# <document>
@@ -286,7 +286,7 @@ def test_Raises_NOT_FOUND_ERR(self):
286286
self.fail()
287287

288288

289-
class Test_AppendChild(unittest.TestCase):
289+
class TestMethod_AppendChild(unittest.TestCase):
290290
def test_AppendNewChild(self):
291291
# ======================================
292292
# <document>
@@ -398,7 +398,7 @@ def test_Raises_NO_MODIFICATION_ALLOWED_ERR(self):
398398
self.fail()
399399

400400

401-
class Test_ReplaceChild(unittest.TestCase):
401+
class TestMethod_ReplaceChild(unittest.TestCase):
402402
def test_ReplaceExistingChild(self):
403403
# ======================================
404404
# <document>
@@ -473,7 +473,7 @@ def test_Raises_NO_MODIFICATION_ALLOWED_ERR(self):
473473
self.fail()
474474

475475

476-
class Test_HasChild(unittest.TestCase):
476+
class TestMethod_HasChild(unittest.TestCase):
477477
def test_True(self):
478478
# ======================================
479479
# <document>

0 commit comments

Comments
 (0)