Skip to content

Conversation

@FoseFx
Copy link
Member

@FoseFx FoseFx commented Apr 10, 2023

This reverts commit d524afd.

@felixevers felixevers marked this pull request as ready for review June 27, 2023 14:02
@felixevers felixevers requested a review from a team as a code owner June 27, 2023 14:02
@felixevers felixevers requested review from DasProffi and felixevers and removed request for a team June 27, 2023 14:02
@felixevers felixevers marked this pull request as draft June 27, 2023 14:04
@felixevers felixevers marked this pull request as ready for review July 15, 2023 16:18
@felixevers felixevers requested a review from MaxSchaefer July 15, 2023 16:24
@felixevers
Copy link
Member

@MaxSchaefer I think we can finally check this pr.

@MaxSchaefer
Copy link
Contributor

@use-to a review is okay. But why should we arm versioning yet?

@MaxSchaefer MaxSchaefer marked this pull request as draft July 15, 2023 16:33
@felixevers
Copy link
Member

@use-to a review is okay. But why should we arm versioning yet?

As you already said, services is production ready. We could wait one more day before or at least for #271

@MaxSchaefer
Copy link
Contributor

@use-to a review is okay. But why should we arm versioning yet?

As you already said, services is production ready. We could wait one more day before or at least for #271

Nope MVP (view). services will be released after web.

@felixevers
Copy link
Member

@use-to a review is okay. But why should we arm versioning yet?

As you already said, services is production ready. We could wait one more day before or at least for #271

Nope github.com/orgs/helpwave/projects/14/views/2. services will be released after web.

Why "Nope"? As I said we can wait for one more day or so...

@MaxSchaefer
Copy link
Contributor

@use-to a review is okay. But why should we arm versioning yet?

As you already said, services is production ready. We could wait one more day before or at least for #271

Nope github.com/orgs/helpwave/projects/14/views/2. services will be released after web.

Why "Nope"? As I said we can wait for one more day or so...

The MVP project-board is a good indicator when services is ready as an MVP. All issues of this board must be addressed before we can merge this pull request. 🙌

@felixevers felixevers marked this pull request as ready for review July 16, 2023 00:10
@MaxSchaefer MaxSchaefer marked this pull request as draft July 16, 2023 11:30
@MaxSchaefer
Copy link
Contributor

@FoseFx could we arm this but instead of failing the CI we emit a warning?

@FoseFx
Copy link
Member Author

FoseFx commented Jan 13, 2024

GitHub action warnings are not present enough to justify this. (Evident by the fact that this PR has a massive amount of warnings, which I had to go looking for to notice)
Additionally, we might want to add a comment to the PR using a bot account or sth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants