feat: add dry-run flag for sync and apply

Signed-off-by: yxxhero <[email protected]>

Author: yxxhero

cmd/apply.go

@@ -68,6 +68,7 @@ func NewApplyCmd(globalCfg *config.GlobalImpl) *cobra.Command {
 	f.StringVar(&applyOptions.PostRenderer, "post-renderer", "", `pass --post-renderer to "helm template" or "helm upgrade --install"`)
 	f.StringArrayVar(&applyOptions.PostRendererArgs, "post-renderer-args", nil, `pass --post-renderer-args to "helm template" or "helm upgrade --install"`)
 	f.StringVar(&applyOptions.Cascade, "cascade", "", "pass cascade to helm exec, default: background")
+	f.StringVar(&applyOptions.DryRyn, "dry-run", "", "pass dry-run to helm exec")
 
 	return cmd
 }

cmd/sync.go

@@ -47,6 +47,7 @@ func NewSyncCmd(globalCfg *config.GlobalImpl) *cobra.Command {
 	f.StringVar(&syncOptions.PostRenderer, "post-renderer", "", `pass --post-renderer to "helm template" or "helm upgrade --install"`)
 	f.StringArrayVar(&syncOptions.PostRendererArgs, "post-renderer-args", nil, `pass --post-renderer-args to "helm template" or "helm upgrade --install"`)
 	f.StringVar(&syncOptions.Cascade, "cascade", "", "pass cascade to helm exec, default: background")
+	f.StringVar(&syncOptions.DryRyn, "dry-run", "", "pass dry-run to helm exec")
 
 	return cmd
 }

pkg/app/app.go

@@ -1482,6 +1482,7 @@ Do you really want to apply?
 					ResetValues:      c.ResetValues(),
 					PostRenderer:     c.PostRenderer(),
 					PostRendererArgs: c.PostRendererArgs(),
+					DryRun:           c.DryRun(),
 				}
 				return subst.SyncReleases(&affectedReleases, helm, c.Values(), c.Concurrency(), syncOpts)
 			}))
@@ -1874,6 +1875,7 @@ Do you really want to sync?
 					ResetValues:      c.ResetValues(),
 					PostRenderer:     c.PostRenderer(),
 					PostRendererArgs: c.PostRendererArgs(),
+					DryRun:           c.DryRun(),
 				}
 				return subst.SyncReleases(&affectedReleases, helm, c.Values(), c.Concurrency(), opts)
 			}))

pkg/app/app_test.go

@@ -2192,6 +2192,7 @@ func (c configImpl) KubeVersion() string {
 type applyConfig struct {
 	args    string
 	cascade string
+	dryRun  string
 	values  []string
 
 	// TODO: Remove this function once Helmfile v0.x
@@ -2396,6 +2397,10 @@ func (a applyConfig) KubeVersion() string {
 	return a.kubeVersion
 }
 
+func (a applyConfig) DryRun() string {
+	return a.dryRun
+}
+
 type depsConfig struct {
 	skipRepos              bool
 	includeTransitiveNeeds bool

pkg/app/config.go

@@ -50,6 +50,7 @@ type ApplyConfigProvider interface {
 	PostRenderer() string
 	PostRendererArgs() []string
 	Cascade() string
+	DryRun() string
 
 	Values() []string
 	Set() []string
@@ -96,6 +97,7 @@ type SyncConfigProvider interface {
 	PostRenderer() string
 	PostRendererArgs() []string
 	Cascade() string
+	DryRun() string
 
 	Values() []string
 	Set() []string

pkg/config/apply.go

@@ -62,6 +62,8 @@ type ApplyOptions struct {
 	PostRendererArgs []string
 	// Cascade '--cascade' to helmv3 delete, available values: background, foreground, or orphan, default: background
 	Cascade string
+	// DryRun is for helm dry-run flag
+	DryRyn string
 }
 
 // NewApply creates a new Apply
@@ -233,3 +235,8 @@ func (a *ApplyImpl) PostRendererArgs() []string {
 func (a *ApplyImpl) Cascade() string {
 	return a.ApplyOptions.Cascade
 }
+
+// DryRun returns dry-run flag
+func (a *ApplyImpl) DryRun() string {
+	return a.ApplyOptions.DryRyn
+}

pkg/config/sync.go

@@ -32,6 +32,8 @@ type SyncOptions struct {
 	PostRendererArgs []string
 	// Cascade '--cascade' to helmv3 delete, available values: background, foreground, or orphan, default: background
 	Cascade string
+	// DryRun is for helm dry-run flag
+	DryRyn string
 }
 
 // NewSyncOptions creates a new Apply
@@ -132,3 +134,8 @@ func (t *SyncImpl) PostRendererArgs() []string {
 func (t *SyncImpl) Cascade() string {
 	return t.SyncOptions.Cascade
 }
+
+// DryRun returns dry-run flag
+func (t *SyncImpl) DryRun() string {
+	return t.SyncOptions.DryRyn
+}

pkg/state/helmx.go

@@ -87,6 +87,12 @@ func (st *HelmState) appendWaitFlags(flags []string, release *ReleaseSpec, ops *
 	}
 	return flags
 }
+func (st *HelmState) appendDryRunFlags(flags []string, opt *SyncOpts) []string {
+	if opt != nil && opt.DryRun != "" {
+		flags = append(flags, "--dry-run", opt.DryRun)
+	}
+	return flags
+}
 
 // append post-renderer flags to helm flags
 func (st *HelmState) appendCascadeFlags(flags []string, helm helmexec.Interface, release *ReleaseSpec, cascade string) []string {

pkg/state/state.go

@@ -725,6 +725,7 @@ type SyncOpts struct {
 	ResetValues      bool
 	PostRenderer     string
 	PostRendererArgs []string
+	DryRun           string
 }
 
 type SyncOpt interface{ Apply(*SyncOpts) }
@@ -2580,6 +2581,7 @@ func (st *HelmState) flagsForUpgrade(helm helmexec.Interface, release *ReleaseSp
 		postRendererArgs = opt.PostRendererArgs
 	}
 	flags = st.appendPostRenderArgsFlags(flags, release, postRendererArgs)
+	flags = st.appendDryRunFlags(flags, opt)
 
 	common, clean, err := st.namespaceAndValuesFlags(helm, release, workerIndex)
 	if err != nil {