Skip to content

Commit 22416f6

Browse files
authored
Merge pull request #125 from fredsod/fix-124
CSR: Updated Makefile to avoid name collision
2 parents d443431 + 95e6de0 commit 22416f6

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

Diff for: csr/Makefile

+9-11
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,14 @@ usage:
1111
@echo "Usage: put the Cisco CSR1000v qcow2 image in this directory and run:"
1212
@echo " make"
1313

14-
docker-build: docker-clean-build docker-pre-build
15-
@if [ -z "$$IMAGE" ]; then echo "ERROR: No IMAGE specified"; exit 1; fi
16-
@if [ "$(IMAGE)" = "$(VERSION)" ]; then echo "ERROR: Incorrect version string"; exit 1; fi
17-
@echo "Building docker image using $(IMAGE) as $(REGISTRY)vr-$(VR_NAME):$(VERSION)"
18-
cp ../common/* docker/
19-
cp $(IMAGE)* docker/
20-
(cd docker; docker build --build-arg http_proxy=$(http_proxy) --build-arg https_proxy=$(https_proxy) --build-arg IMAGE=$(IMAGE) -t $(REGISTRY)vr-$(VR_NAME):$(VERSION) .)
21-
docker run --privileged --name vr-temp $(REGISTRY)vr-$(VR_NAME):$(VERSION) --trace --install
22-
docker commit --change='ENTRYPOINT ["/launch.py"]' vr-temp $(REGISTRY)vr-$(VR_NAME):$(VERSION)
23-
docker rm vr-temp
24-
2514
no-image:
2615
@echo "ERROR: you have no .qcow2 image"
16+
17+
docker-pre-build:
18+
-cat cidfile | xargs --no-run-if-empty docker rm -f
19+
-rm cidfile
20+
21+
docker-build: docker-build-common
22+
docker run --cidfile cidfile --privileged $(REGISTRY)vr-$(VR_NAME):$(VERSION) --trace --install
23+
docker commit --change='ENTRYPOINT ["/launch.py"]' $$(cat cidfile) $(REGISTRY)vr-$(VR_NAME):$(VERSION)
24+
docker rm -f $$(cat cidfile)

0 commit comments

Comments
 (0)