[TASK] Clean up code

Author: helhum

src/Install/Action/SetupConfigurationAction.php

@@ -89,6 +89,9 @@ private function populateCustomSettings(array $actionDefinition, array $options)
         foreach ($arguments as $argumentName => $argumentValue) {
             $customConfig = Config::setValue($customConfig, $argumentDefinitions[$argumentName]['configPath'], $argumentValue);
         }
+        if ($customConfig === []) {
+            return;
+        }
         $this->addValuesToOverrides($customConfig);
     }
 
@@ -127,13 +130,10 @@ private function addValuesToOverrides(array $values): void
         $configFile = SettingsFiles::getOverrideSettingsFile();
         $reader = (new ConfigurationReaderFactory(dirname($configFile)))->createReader($configFile);
         $currentConfig = $reader->hasConfig() ? $reader->readConfig() : [];
-        $config = array_replace_recursive($currentConfig, $values);
-
-        if(empty($config)) {
-            return;
-        }
-
-        $this->configDumper->dumpToFile($config, $configFile);
+        $this->configDumper->dumpToFile(
+            array_replace_recursive($currentConfig, $values),
+            $configFile
+        );
     }
 
     private function copyEnvDistFile(): void