!!! Configured processors now need a key for identifcation

Instead of being an array, processors must now
be defined as a map, so that every processor can
be identified with a key.

This allows easier overriding of already defined processors
and makes the code for removing options with a processor
much simpler.

Closes #34

Author: helhum

README.md

@@ -127,7 +127,8 @@ There are some prerequisites to follow if you want to use this feature:
 
   ```yaml
   processors:
-     - class: Helhum\TYPO3\ConfigHandling\Processor\DecryptSettingsProcessor
+      decrypt:
+          class: Helhum\TYPO3\ConfigHandling\Processor\DecryptSettingsProcessor
   ```
 
 As you can see, the decryption is solely based on a processor, which handles the

src/Xclass/ConfigurationManager.php

@@ -269,7 +269,7 @@ public function updateLocalConfiguration(array $configurationToMerge): void
                 1346323822
             );
         }
-        $removedPaths = $this->findRemovedPaths();
+        $removedPaths = $this->getRemovedPaths();
         foreach ($removedPaths as $removedPath) {
             try {
                 Config::getValue($configurationToMerge, $removedPath);
@@ -292,44 +292,26 @@ public function updateLocalConfiguration(array $configurationToMerge): void
         }
     }
 
-    private function findRemovedPaths(): array
-    {
-        $overrides = $this->configLoader->loadOverrides();
-        $removedPaths = [];
-        if (isset($overrides['processors'])) {
-            foreach ($overrides['processors'] as $index => $processorConfig) {
-                if (($processorConfig['internal'] ?? false) && $processorConfig['class'] === RemoveSettingsProcessor::class) {
-                    $removedPaths = $processorConfig['paths'];
-                    break;
-                }
-            }
-        }
+    private const REMOVE_PROCESSOR_KEY = '_stale_options';
 
-        return $removedPaths;
+    private function getRemovedPaths(): array
+    {
+        return $this->configLoader->loadOverrides()['processors'][self::REMOVE_PROCESSOR_KEY]['paths'] ?? [];
     }
 
     private function updateRemovalPaths(array $pathsToRemove): void
     {
         $overrideSettingsFile = SettingsFiles::getOverrideSettingsFile();
         $overrides = $this->configLoader->loadOverrides();
-        $processorPosition = 0;
-        if (isset($overrides['processors'])) {
-            foreach ($overrides['processors'] as $index => $processorConfig) {
-                if (($processorConfig['internal'] ?? false) && $processorConfig['class'] === RemoveSettingsProcessor::class) {
-                    $processorPosition = $index;
-                    break;
-                }
-            }
-        }
+        $overrides['processors'][self::REMOVE_PROCESSOR_KEY] = [
+            'class' => RemoveSettingsProcessor::class,
+            'paths' => $pathsToRemove,
+        ];
         if (empty($pathsToRemove)) {
-            unset($overrides['processors'][$processorPosition]);
+            unset($overrides['processors'][self::REMOVE_PROCESSOR_KEY]);
             if (empty($overrides['processors'])) {
                 unset($overrides['processors']);
             }
-        } else {
-            $overrides['processors'][$processorPosition]['class'] = RemoveSettingsProcessor::class;
-            $overrides['processors'][$processorPosition]['paths'] = $pathsToRemove;
-            $overrides['processors'][$processorPosition]['internal'] = true;
         }
         $this->configDumper->dumpToFile($overrides, $overrideSettingsFile);
     }
@@ -422,7 +404,7 @@ public function removeLocalConfigurationKeysByPath(array $keys): bool
             }
         }
         if (!empty($removedPaths)) {
-            $alreadyRemovedPaths = $this->findRemovedPaths();
+            $alreadyRemovedPaths = $this->getRemovedPaths();
             $removedPaths = array_unique(array_merge($alreadyRemovedPaths, $removedPaths));
             $this->updateRemovalPaths($removedPaths);
         }