fix reusable workflow call

Author: heaven00

.github/workflows/build_and_deploy_images.yml

@@ -1,52 +1,51 @@
-name: Reusable build and deploy to ecr workflow
+name: Reusable build and deploy to ECR workflow
 
 on:
   workflow_call:
     inputs:
-     aws-region:
-       required: true
-       type: string
-     ecr-repo-name:
-       required: true
-       type: string
-     image-tag:
-       required: true
-       type: string
+      aws-region:
+        required: true
+        type: string
+      ecr-repo-name:
+        required: true
+        type: string
+      image-tag:
+        required: true
+        type: string
     secrets:
       AWS_ACCESS_KEY_ID:
         required: true
       AWS_SECRET_ACCESS_KEY:
         required: true
 
-
 jobs:
   build-images-and-push-to-ecr:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
+      - name: Checkout Repository
         uses: actions/checkout@v4
-      - name: Configure AWS credentials
+
+      - name: Configure AWS Credentials
         uses: aws-actions/configure-aws-credentials@v1
         with:
           aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
           aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          aws-region: ${{ input.aws-region }}
-        env:
-          ECR_REPOSITORY: ${{ input.ecr-repo-name }}
-          IMAGE_TAG: ${{ input.image-tag }}
-     
+          aws-region: ${{ inputs.aws-region }}
+
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
 
-      - name: Build, tag, and push image to Amazon ECR
+      - name: Build, Tag, and Push Image to Amazon ECR
         id: build-image
         working-directory: src/validation_lambda
         env:
           ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
+          ECR_REPOSITORY: ${{ inputs.ecr-repo-name }}
+          IMAGE_TAG: ${{ inputs.image-tag }}
         run: |
-          # Build a docker container and
-          # push it to ECR to be used in lambda.
+          echo "Building Docker image..."
           docker build -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG .
+          echo "Pushing image to ECR..."
           docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
-          echo "image=$ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG"
+          echo "Image successfully pushed: $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG"

.github/workflows/workflow.yml

@@ -20,14 +20,14 @@ jobs:
       - name: Run tests
         run: uv run pytest tests
 
-  build-ecr-images: 
-    runs-on: ubuntu-latest
+  build-validation-lambda-ecr: 
     needs: test
-    steps:
-      - name: validation lambda
-        uses: heaven00/fraud-detection-aws/.github/workflows/build_and_deploy_images.yml@main
-        with:
-            aws-region: ca-central-1
-            ecr-repo-name: fraud-detection/validation-lambda
-            image-tag: ${{ github.sha }}
+    uses: heaven00/fraud-detection-aws/.github/workflows/build_and_deploy_images.yml@main
+    with:
+        aws-region: ca-central-1
+        ecr-repo-name: fraud-detection/validation-lambda
+        image-tag: ${{ github.sha }}
+    secrets:
+      AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+      AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}