Add test

Author: JackPGreen

.github/workflows/test-download-hz-dist.yml

@@ -17,10 +17,17 @@ jobs:
 
       - name: Download ${{ matrix.distribution }}"
         uses: ./download-hz-dist
+        id: download
         with:
           repo-vars-as-json: "{\n  \"MAVEN_EE_RELEASE_REPO\": \"https://repository.hazelcast.com/release\",\n  \"MAVEN_OSS_RELEASE_REPO\": \" \"\n}"
           distribution: "${{ matrix.distribution }}"
           hz_version: "5.0"
           classifier: "slim"
           packaging: "tar.gz"
-          output_file: "distribution"
+
+      - name: Check file exists
+        run: |
+          if [[ ! -f "${{ steps.download.outputs.output_file }}" ]]; then
+            echo "${{ steps.download.outputs.output_file }} not found!"
+            exit 1
+          fi

.github/workflows/test-get-hz-versions.yml

@@ -31,13 +31,6 @@ jobs:
             assert_eq "$expected" "$actual" "$msg" && log_success "$msg" || TESTS_RESULT=$?
           }
 
-          assert_populated() {
-            local name=$1
-            local actual=$2
-            local msg="$name should not be empty"
-            assert_not_empty "$actual" "$msg" && log_success "$msg" || TESTS_RESULT=$?
-          }
-          
           assert_equals "HZ_VERSION" "1.2.3" "${{ steps.hz_versions.outputs.HZ_VERSION }}"
 
           assert_eq 0 "$TESTS_RESULT" "All tests should pass"

download-hz-dist/action.yml

@@ -16,12 +16,15 @@ inputs:
     description: 'Maven packaging'
     required: true
   output_file:
-    description: 'Path to the output file, if not defaults to "distribution"'
+    description: 'Path to the output file'
     required: false
 outputs:
   maven_repo_url:
     description: 'The Maven repository root URL used to download the distribution'
     value: ${{ steps.get_repo_url.outputs.repo_url }}
+  output_file:
+    description: 'Path to the downloaded file'
+    value: ${{ steps.derive-output-file.outputs.file }}
 runs:
   using: "composite"
   steps:
@@ -53,6 +56,12 @@ runs:
         # Lookup up the value of the selected key in "repo-vars-as-json"
         echo "repo_url=$(jq --raw-output .${repo_var_name} <<< '${{ inputs.repo-vars-as-json }}')" >> ${GITHUB_OUTPUT}
 
+    - name: Derive output file
+      id: derive-output-file
+      shell: bash
+      run: |
+        echo "file=${{ inputs.output_file || format('distribution.{0}', inputs.packaging) }}" >> ${GITHUB_OUTPUT}
+
     - name: Download via Maven
       shell: bash
       run: |
@@ -65,6 +74,6 @@ runs:
           -Dclassifier="${{ inputs.classifier }}" \
           -Dpackaging="${{ inputs.packaging }}" \
           -Dtransitive=false \
-          -Ddest="${{ inputs.output_file || format('distribution.{0}', inputs.packaging) }}" \
+          -Ddest="${{ steps.derive-output-file.outputs.file }}" \
           --batch-mode \
           --no-transfer-progress