Skip to content

Commit 57c2854

Browse files
committed
README updates related to git-sync for ndc-postgres, ndc-connector-oracle & ndc-mongodb
1 parent 3d13f5d commit 57c2854

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

charts/ndc-connector-oracle/README.md

+4-2
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@ helm upgrade --install <release-name> \
3030

3131
Follow the pre-requisite [here](../../README.md#using-git-for-metadata-files) which has to be done once and deployed on the cluster.
3232

33-
Replace `org`, `repo` placeholders in the below command to suit your git repository. Additionally, ensure that `connectorEnvVars.configDirectory` is set to the given path below, providing that you are also replacing `repo` and `connector-name` placeholders within it. For clarity, `connector-name` is the name that was give to your connector (ie. Check `app/connector` under your Supergraph).
33+
Replace `git_domain`, `org` and `repo` placeholders in the below command to suit your git repository. Additionally, ensure that `connectorEnvVars.configDirectory` is set to the given path below, providing that you are also replacing `repo` and `connector-name` placeholders within it. For clarity, `connector-name` is the name that was give to your connector (ie. Check `app/connector` under your Supergraph).
34+
35+
Note: For `https` based checkout, a typical URL format for `initContainers.gitSync.repo` will be `https://<git_domain>/<org>/<repo>`. For `ssh` based checkout, a typical URL format will be `git@<git_domain>:<org>/<repo>`
3436

3537
```bash
3638
helm upgrade --install <release-name> \
@@ -39,7 +41,7 @@ helm upgrade --install <release-name> \
3941
--set image.tag="my_custom_image_tag" \
4042
--set connectorEnvVars.JDBC_URL="jdbc_url" \
4143
--set initContainers.gitSync.enabled="true" \
42-
--set initContainers.gitSync.repo="git@github.com:<org>/<repo>" \
44+
--set initContainers.gitSync.repo="git@<git_domain>:<org>/<repo>" \
4345
--set initContainers.gitSync.branch="main" \
4446
--set connectorEnvVars.configDirectory="/work-dir/<repo>/app/connector/<connector-name>" \
4547
hasura-ddn/ndc-connector-oracle

charts/ndc-mongodb/README.md

+5-3
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,13 @@ helm upgrade --install <release-name> \
2626
hasura-ddn/ndc-mongodb
2727
```
2828

29-
## Enabling git-sync
29+
## Deployment option via git-sync
3030

3131
Follow the pre-requisite [here](../../README.md#using-git-for-metadata-files) which has to be done once and deployed on the cluster.
3232

33-
Replace `org`, `repo` placeholders in the below command to suit your git repository. Additionally, ensure that `connectorEnvVars.configDirectory` is set to the given path below, providing that you are also replacing `repo` and `connector-name` placeholders within it. For clarity, `connector-name` is the name that was give to your connector (ie. Check `app/connector` under your Supergraph).
33+
Replace `git_domain`, `org` and `repo` placeholders in the below command to suit your git repository. Additionally, ensure that `connectorEnvVars.configDirectory` is set to the given path below, providing that you are also replacing `repo` and `connector-name` placeholders within it. For clarity, `connector-name` is the name that was give to your connector (ie. Check `app/connector` under your Supergraph).
34+
35+
Note: For `https` based checkout, a typical URL format for `initContainers.gitSync.repo` will be `https://<git_domain>/<org>/<repo>`. For `ssh` based checkout, a typical URL format will be `git@<git_domain>:<org>/<repo>`
3436

3537
```bash
3638
helm upgrade --install <release-name> \
@@ -39,7 +41,7 @@ helm upgrade --install <release-name> \
3941
--set image.tag="my_custom_image_tag" \
4042
--set connectorEnvVars.MONGODB_DATABASE_URI="db_connection_string" \
4143
--set initContainers.gitSync.enabled="true" \
42-
--set initContainers.gitSync.repo="git@github.com:<org>/<repo>" \
44+
--set initContainers.gitSync.repo="git@<git_domain>:<org>/<repo>" \
4345
--set initContainers.gitSync.branch="main" \
4446
--set connectorEnvVars.configDirectory="/work-dir/<repo>/app/connector/<connector-name>" \
4547
hasura-ddn/ndc-mongodb

charts/ndc-postgres/README.md

+4-2
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@ helm upgrade --install <release-name> \
3030

3131
Follow the pre-requisite [here](../../README.md#using-git-for-metadata-files) which has to be done once and deployed on the cluster.
3232

33-
Replace `org`, `repo` placeholders in the below command to suit your git repository. Additionally, ensure that `connectorEnvVars.configDirectory` is set to the given path below, providing that you are also replacing `repo` and `connector-name` placeholders within it. For clarity, `connector-name` is the name that was give to your connector (ie. Check `app/connector` under your Supergraph).
33+
Replace `git_domain`, `org` and `repo` placeholders in the below command to suit your git repository. Additionally, ensure that `connectorEnvVars.configDirectory` is set to the given path below, providing that you are also replacing `repo` and `connector-name` placeholders within it. For clarity, `connector-name` is the name that was give to your connector (ie. Check `app/connector` under your Supergraph).
34+
35+
Note: For `https` based checkout, a typical URL format for `initContainers.gitSync.repo` will be `https://<git_domain>/<org>/<repo>`. For `ssh` based checkout, a typical URL format will be `git@<git_domain>:<org>/<repo>`
3436

3537
```bash
3638
helm upgrade --install <release-name> \
@@ -39,7 +41,7 @@ helm upgrade --install <release-name> \
3941
--set image.tag="my_custom_image_tag" \
4042
--set connectorEnvVars.CONNECTION_URI="db_connection_string" \
4143
--set initContainers.gitSync.enabled="true" \
42-
--set initContainers.gitSync.repo="git@github.com:<org>/<repo>" \
44+
--set initContainers.gitSync.repo="git@<git_domain>:<org>/<repo>" \
4345
--set initContainers.gitSync.branch="main" \
4446
--set connectorEnvVars.configDirectory="/work-dir/<repo>/app/connector/<connector-name>" \
4547
hasura-ddn/ndc-postgres

0 commit comments

Comments
 (0)