Follow hlint suggestion: move brackets to avoid $

Author: philderbeast

.hlint.yaml

@@ -12,7 +12,6 @@
 - ignore: {name: "Missing NOINLINE pragma"} # 1 hint
 - ignore: {name: "Monoid law, left identity"} # 3 hints
 - ignore: {name: "Monoid law, right identity"} # 3 hints
-- ignore: {name: "Move brackets to avoid $"} # 25 hints
 - ignore: {name: "Move guards forward"} # 4 hints
 - ignore: {name: "Redundant $"} # 125 hints
 - ignore: {name: "Redundant $!"} # 4 hints

Cabal/src/Distribution/Compat/ResponseFile.hs

@@ -76,7 +76,7 @@ expandResponse = go recursionLimit "."
       | otherwise = const $ hPutStrLn stderr "Error: response file recursion limit exceeded." >> exitFailure
 
     expand :: Int -> FilePath -> String -> IO [String]
-    expand n dir arg@('@' : f) = readRecursively n (dir </> f) `catchIOError` (const $ print "?" >> return [arg])
+    expand n dir arg@('@' : f) = readRecursively n (dir </> f) `catchIOError` const (print "?" >> return [arg])
     expand _n _dir x = return [x]
 
     readRecursively :: Int -> FilePath -> IO [String]

Cabal/src/Distribution/Compat/Time.hs

@@ -155,7 +155,7 @@ posixSecondsToModTime s =
 posixTimeToModTime :: POSIXTime -> ModTime
 posixTimeToModTime p =
   ModTime $
-    (ceiling $ p * 1e7) -- 100 ns precision
+    ceiling (p * 1e7) -- 100 ns precision
       + (secToUnixEpoch * windowsTick)
 
 -- | Return age of given file in days.

Cabal/src/Distribution/ReadE.hs

@@ -55,7 +55,7 @@ runParsecFromString p txt =
 
 parsecToReadE :: (String -> ErrorMsg) -> ParsecParser a -> ReadE a
 parsecToReadE err p = ReadE $ \txt ->
-  (const $ err txt) `Bi.first` runParsecFromString p txt
+  const (err txt) `Bi.first` runParsecFromString p txt
 
 parsecToReadEErr :: (Parsec.ParseError -> ErrorMsg) -> ParsecParser a -> ReadE a
 parsecToReadEErr err p =

Cabal/src/Distribution/Simple/Build.hs

@@ -857,7 +857,7 @@ testSuiteLibV09AsLibAndExe
                 { hsSourceDirs = [unsafeMakeSymbolicPath testDir]
                 , targetBuildDepends =
                     testLibDep
-                      : (targetBuildDepends $ testBuildInfo test)
+                      : targetBuildDepends (testBuildInfo test)
                 }
           }
       -- \| The stub executable needs a new 'ComponentLocalBuildInfo'

Cabal/src/Distribution/Simple/Haddock.hs

@@ -395,7 +395,7 @@ haddock pkg_descr lbi suffixes flags' = do
 
             return $ PackageIndex.insert ipi index
       CFLib flib ->
-        ( when (flag haddockForeignLibs) $ do
+        when (flag haddockForeignLibs) (do
             withTempDirectoryEx verbosity tmpFileOpts (buildDir lbi') "tmp" $
               \tmp -> do
                 smsg
@@ -409,12 +409,11 @@ haddock pkg_descr lbi suffixes flags' = do
                     version
                     flib
                 let libArgs' = commonArgs `mappend` flibArgs
-                runHaddock verbosity tmpFileOpts comp platform haddockProg True libArgs'
-        )
+                runHaddock verbosity tmpFileOpts comp platform haddockProg True libArgs')
           >> return index
-      CExe _ -> (when (flag haddockExecutables) $ smsg >> doExe component) >> return index
-      CTest _ -> (when (flag haddockTestSuites) $ smsg >> doExe component) >> return index
-      CBench _ -> (when (flag haddockBenchmarks) $ smsg >> doExe component) >> return index
+      CExe _ -> when (flag haddockExecutables) (smsg >> doExe component) >> return index
+      CTest _ -> when (flag haddockTestSuites) (smsg >> doExe component) >> return index
+      CBench _ -> when (flag haddockBenchmarks) (smsg >> doExe component) >> return index
 
   for_ (extraDocFiles pkg_descr) $ \fpath -> do
     files <- matchDirFileGlob verbosity (specVersion pkg_descr) "." fpath
@@ -937,8 +936,7 @@ renderPureArgs version comp platform args =
     renderInterface :: (FilePath, Maybe FilePath, Maybe FilePath, Visibility) -> String
     renderInterface (i, html, hypsrc, visibility) =
       "--read-interface="
-        ++ ( intercalate "," $
-              concat
+        ++ intercalate "," (concat
                 [ [fromMaybe "" html]
                 , -- only render hypsrc path if html path
                   -- is given and hyperlinked-source is
@@ -962,8 +960,7 @@ renderPureArgs version comp platform args =
                       ]
                     else []
                 , [i]
-                ]
-           )
+                ])
 
     bool a b c = if c then a else b
     isVersion major minor = version >= mkVersion [major, minor]

Cabal/src/Distribution/Utils/Json.hs

@@ -39,7 +39,7 @@ renderJson json = toLazyByteString (go json)
     go (JsonObject attrs) =
       surround "{" "}" $ mconcat $ intersperse "," $ map render attrs
       where
-        render (k, v) = (surround "\"" "\"" $ stringUtf8 (escape k)) <> ":" <> go v
+        render (k, v) = surround "\"" "\"" (stringUtf8 (escape k)) <> ":" <> go v
     go (JsonString s) = surround "\"" "\"" $ stringUtf8 (escape s)
 
 surround :: Builder -> Builder -> Builder -> Builder

cabal-install-solver/src/Distribution/Solver/Modular/Linking.hs

@@ -85,11 +85,11 @@ validateLinking index = (`runReader` initVS) . go
     go :: Tree d c -> Validate (Tree d c)
 
     go (PChoice qpn rdm gr       cs) =
-      PChoice qpn rdm gr       <$> (W.traverseWithKey (goP qpn) $ fmap go cs)
+      PChoice qpn rdm gr       <$> W.traverseWithKey (goP qpn) (fmap go cs)
     go (FChoice qfn rdm gr t m d cs) =
-      FChoice qfn rdm gr t m d <$> (W.traverseWithKey (goF qfn) $ fmap go cs)
+      FChoice qfn rdm gr t m d <$> W.traverseWithKey (goF qfn) (fmap go cs)
     go (SChoice qsn rdm gr t     cs) =
-      SChoice qsn rdm gr t     <$> (W.traverseWithKey (goS qsn) $ fmap go cs)
+      SChoice qsn rdm gr t     <$> W.traverseWithKey (goS qsn) (fmap go cs)
 
     -- For the other nodes we just recurse
     go (GoalChoice rdm           cs) = GoalChoice rdm <$> T.traverse go cs

cabal-install-solver/src/Distribution/Solver/Modular/Message.hs

@@ -66,7 +66,7 @@ showMessages = go 0
     go !l (Step (Next (Goal (P _  ) gr)) (Step (TryP qpn' i) ms@(Step Enter (Step (Next _) _)))) =
         (atLevel l $ "trying: " ++ showQPNPOpt qpn' i ++ showGR gr) (go l ms)
     go !l (Step (Next (Goal (P qpn) gr)) (Step (Failure _c UnknownPackage) ms)) =
-        (atLevel l $ "unknown package: " ++ showQPN qpn ++ showGR gr) $ go l ms
+        atLevel l ("unknown package: " ++ showQPN qpn ++ showGR gr) $ go l ms
     -- standard display
     go !l (Step Enter                    ms) = go (l+1) ms
     go !l (Step Leave                    ms) = go (l-1) ms

cabal-install/src/Distribution/Client/CmdRun.hs

@@ -514,12 +514,13 @@ renderRunProblem (TargetProblemMatchesMultiple targetSelector targets) =
     ++ " which includes \n"
     ++ unlines
       ( (\(label, xs) -> "- " ++ label ++ ": " ++ renderListPretty xs)
-          <$> ( zip ["executables", "test-suites", "benchmarks"] $
-                  filter (not . null) . map removeDuplicates $
-                    map (componentNameRaw . availableTargetComponentName)
-                      <$> (flip filterTargetsKind $ targets)
-                      <$> [ExeKind, TestKind, BenchKind]
-              )
+          <$> zip
+            ["executables", "test-suites", "benchmarks"]
+            ( filter (not . null) . map removeDuplicates $
+                map (componentNameRaw . availableTargetComponentName)
+                  <$> (flip filterTargetsKind $ targets)
+                  <$> [ExeKind, TestKind, BenchKind]
+            )
       )
   where
     removeDuplicates = catMaybes . map safeHead . group . sort