Updates from standardrb

Author: mattpolito

Gemfile

@@ -1,5 +1,5 @@
 source "https://rubygems.org"
 
-gem 'rake'
+gem "rake"
 
 gemspec

decent_exposure.gemspec

@@ -1,23 +1,23 @@
 require File.expand_path("../lib/decent_exposure/version", __FILE__)
 
 Gem::Specification.new do |spec|
-  spec.name         = "decent_exposure"
-  spec.version      = DecentExposure::VERSION
-  spec.authors      = ["Pavel Pravosud", "Stephen Caudill"]
-  spec.email        = ["[email protected]"]
-  spec.summary      = "A helper for creating declarative interfaces in controllers"
-  spec.description = %q{
+  spec.name = "decent_exposure"
+  spec.version = DecentExposure::VERSION
+  spec.authors = ["Pavel Pravosud", "Stephen Caudill"]
+  spec.email = ["[email protected]"]
+  spec.summary = "A helper for creating declarative interfaces in controllers"
+  spec.description = '
     DecentExposure helps you program to an interface, rather than an
     implementation in your Rails controllers.  The fact of the matter is that
     sharing state via instance variables in controllers promotes close coupling
     with views.  DecentExposure gives you a declarative manner of exposing an
     interface to the state that controllers contain and thereby decreasing
     coupling and improving your testability and overall design.
-  }
-  spec.homepage     = "https://github.com/hashrocket/decent_exposure"
-  spec.license      = "MIT"
-  spec.files        = `git ls-files -z`.split("\x0")
-  spec.test_files   = spec.files.grep(/\Aspec\//)
+  '
+  spec.homepage = "https://github.com/hashrocket/decent_exposure"
+  spec.license = "MIT"
+  spec.files = `git ls-files -z`.split("\x0")
+  spec.test_files = spec.files.grep(/\Aspec\//)
   spec.require_path = "lib"
 
   spec.required_ruby_version = "~> 2.0"
@@ -26,4 +26,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "railties", ">= 4.0"
   spec.add_development_dependency "actionmailer"
   spec.add_development_dependency "rspec-rails", "~> 3.0"
+  spec.add_development_dependency "standard"
 end

lib/decent_exposure.rb

@@ -4,12 +4,12 @@
 
 module DecentExposure
   autoload :Controller, "decent_exposure/controller"
-  autoload :Mailer,     "decent_exposure/mailer"
-  autoload :Exposure,   "decent_exposure/exposure"
-  autoload :Attribute,  "decent_exposure/attribute"
-  autoload :Context,    "decent_exposure/context"
-  autoload :Behavior,   "decent_exposure/behavior"
-  autoload :Flow,       "decent_exposure/flow"
+  autoload :Mailer, "decent_exposure/mailer"
+  autoload :Exposure, "decent_exposure/exposure"
+  autoload :Attribute, "decent_exposure/attribute"
+  autoload :Context, "decent_exposure/context"
+  autoload :Behavior, "decent_exposure/behavior"
+  autoload :Flow, "decent_exposure/flow"
 
   ActiveSupport.on_load :action_controller do
     include Controller

lib/decent_exposure/attribute.rb

@@ -32,7 +32,6 @@ def setter_method_name
       "#{name}=".to_sym
     end
 
-
     # Public: Expose a getter and setter method for the Attribute
     # on the passed in Controller class.
     #

lib/decent_exposure/behavior.rb

@@ -86,7 +86,7 @@ def build_params
     protected
 
     def params_id_key_candidates
-      [ "#{model_param_key}_id", "#{name}_id", "id" ].uniq
+      ["#{model_param_key}_id", "#{name}_id", "id"].uniq
     end
 
     def model_param_key

lib/decent_exposure/context.rb

@@ -20,7 +20,7 @@ def initialize(context, attribute)
     #
     # Returns the attribute's value.
     def get
-      ivar_defined?? ivar_get : set(fetch_value)
+      ivar_defined? ? ivar_get : set(fetch_value)
     end
 
     # Public: Write to an attribute on the context Class.
@@ -51,7 +51,7 @@ def ivar_set(value)
     end
 
     def ivar_name
-      "@#{attribute.ivar_name.gsub('?', '_question_mark_')}"
+      "@#{attribute.ivar_name.gsub("?", "_question_mark_")}"
     end
 
     def fetch_value

lib/decent_exposure/exposure.rb

@@ -34,7 +34,7 @@ def self.expose!(*args, &block)
     #               the Proc.
     #
     # Returns a normalized options Hash.
-    def initialize(controller, name, fetch_block=nil, **options, &block)
+    def initialize(controller, name, fetch_block = nil, **options, &block)
       @controller = controller
       @options = options.with_indifferent_access.merge(name: name)
 
@@ -86,43 +86,43 @@ def normalize_options
 
     def normalize_fetch_option
       normalize_non_proc_option :fetch do |method_name|
-        ->{ send(method_name) }
+        -> { send(method_name) }
       end
     end
 
     def normalize_find_by_option
-      if find_by = options.delete(:find_by)
-        merge_lambda_option :find, ->(id, scope){ scope.find_by!(find_by => id) }
+      if (find_by = options.delete(:find_by))
+        merge_lambda_option :find, ->(id, scope) { scope.find_by!(find_by => id) }
       end
     end
 
     def normalize_parent_option
       exposure_name = options.fetch(:name)
 
-      if parent = options.delete(:parent)
-        merge_lambda_option :scope, ->{ send(parent).send(exposure_name.to_s.pluralize) }
+      if (parent = options.delete(:parent))
+        merge_lambda_option :scope, -> { send(parent).send(exposure_name.to_s.pluralize) }
       end
     end
 
     def normalize_from_option
       exposure_name = options.fetch(:name)
 
-      if from = options.delete(:from)
-        merge_lambda_option :build, ->{ send(from).send(exposure_name) }
-        merge_lambda_option :model, ->{ nil }
-        merge_lambda_option :id, ->{ nil }
+      if (from = options.delete(:from))
+        merge_lambda_option :build, -> { send(from).send(exposure_name) }
+        merge_lambda_option :model, -> { nil }
+        merge_lambda_option :id, -> { nil }
       end
     end
 
     def normalize_with_option
-      if configs = options.delete(:with)
-        Array.wrap(configs).each{ |config| reverse_merge_config! config }
+      if (configs = options.delete(:with))
+        Array.wrap(configs).each { |config| reverse_merge_config! config }
       end
     end
 
     def normalize_id_option
       normalize_non_proc_option :id do |ids|
-        ->{ Array.wrap(ids).map{ |id| params[id] }.find(&:present?) }
+        -> { Array.wrap(ids).map { |id| params[id] }.find(&:present?) }
       end
     end
 
@@ -134,7 +134,7 @@ def normalize_model_option
           value
         end
 
-        ->{ model }
+        -> { model }
       end
     end
 
@@ -147,7 +147,7 @@ def normalize_build_params_option
 
     def normalize_scope_options
       normalize_non_proc_option :scope do |custom_scope|
-        ->(model){ model.send(custom_scope) }
+        ->(model) { model.send(custom_scope) }
       end
     end
 
@@ -165,7 +165,7 @@ def normalize_non_proc_option(name)
     end
 
     def merge_lambda_option(name, body)
-      if previous_value = options[name] and Proc === previous_value
+      if (previous_value = options[name]) && (Proc === previous_value)
         fail ArgumentError, "#{name.to_s.titleize} block is already defined"
       end
 
@@ -178,7 +178,7 @@ def attribute
 
         name = options.fetch(:name)
         ivar_name = "exposed_#{name}"
-        fetch = ->{ Flow.new(self, local_options).fetch }
+        fetch = -> { Flow.new(self, local_options).fetch }
 
         Attribute.new(
           name: name,

lib/decent_exposure/flow.rb

@@ -46,7 +46,7 @@ def get_request?
     end
 
     def params_method_name
-      options.fetch(:build_params_method){ "#{name}_params" }
+      options.fetch(:build_params_method) { "#{name}_params" }
     end
 
     def handle_flow_method(name, *args, &block)
@@ -75,7 +75,6 @@ def handle_default_flow_method(name, *args, &block)
       method.bind(self).call(*args, &block)
     end
 
-
     def fetch_ivar(name)
       ivar_name = "@#{name}"
 

lib/decent_exposure/mailer.rb

@@ -6,7 +6,7 @@ def self.included(base)
 
         def process_action(*args)
           arg = args.second
-          self.params = arg.stringify_keys() if arg && Hash === arg
+          self.params = arg.stringify_keys if arg && Hash === arg
           super
         end
       end

lib/generators/decent_exposure/scaffold_templates_generator.rb

@@ -1,14 +1,14 @@
-require 'rails/generators'
+require "rails/generators"
 
 module DecentExposure
   module Generators
     class ScaffoldTemplatesGenerator < Rails::Generators::Base
-      desc 'Generate DecentExposure scaffold template files'
-      source_root File.expand_path('../templates', __FILE__)
-      class_option :template_engine, desc: 'Template engine to be invoked (erb).'
+      desc "Generate DecentExposure scaffold template files"
+      source_root File.expand_path("../templates", __FILE__)
+      class_option :template_engine, desc: "Template engine to be invoked (erb)."
 
-      VIEWS = %i(_form edit index new show)
-      AVAILABLE_ENGINES = %w(erb haml)
+      VIEWS = %i[_form edit index new show]
+      AVAILABLE_ENGINES = %w[erb haml]
 
       def generate
         validate_template_engine
@@ -20,7 +20,7 @@ def generate
       private
 
       def generate_controller
-        copy_template('rails/scaffold_controller', 'controller.rb')
+        copy_template("rails/scaffold_controller", "controller.rb")
       end
 
       def generate_view(view)