File tree Expand file tree Collapse file tree 3 files changed +18
-9
lines changed Expand file tree Collapse file tree 3 files changed +18
-9
lines changed Original file line number Diff line number Diff line change @@ -102,9 +102,13 @@ public async Task<bool> CanDownloadAsync(string revision)
102
102
/// <inheritdoc/>
103
103
public async Task < InstalledBrowser > DownloadAsync ( )
104
104
{
105
- var buildId = Browser == SupportedBrowser . Firefox
106
- ? await Firefox . GetDefaultBuildIdAsync ( ) . ConfigureAwait ( false )
107
- : Chrome . DefaultBuildId ;
105
+ var buildId = Browser switch
106
+ {
107
+ SupportedBrowser . Firefox => await Firefox . GetDefaultBuildIdAsync ( ) . ConfigureAwait ( false ) ,
108
+ SupportedBrowser . Chrome or SupportedBrowser . ChromeHeadlessShell => Chrome . DefaultBuildId ,
109
+ SupportedBrowser . Chromium => await Chromium . ResolveBuildIdAsync ( Platform ) . ConfigureAwait ( false ) ,
110
+ _ => throw new PuppeteerException ( $ "{ Browser } not supported.") ,
111
+ } ;
108
112
109
113
return await DownloadAsync ( buildId ) . ConfigureAwait ( false ) ;
110
114
}
Original file line number Diff line number Diff line change @@ -50,9 +50,14 @@ public async Task<IBrowser> LaunchAsync(LaunchOptions options)
50
50
51
51
EnsureSingleLaunchOrConnect ( ) ;
52
52
_browser = options . Browser ;
53
- var executable = options . ExecutablePath ?? GetExecutablePath (
54
- options ,
55
- options . Browser == SupportedBrowser . Firefox ? await Firefox . GetDefaultBuildIdAsync ( ) . ConfigureAwait ( false ) : Chrome . DefaultBuildId ) ;
53
+ var buildId = options . Browser switch
54
+ {
55
+ SupportedBrowser . Firefox => await Firefox . GetDefaultBuildIdAsync ( ) . ConfigureAwait ( false ) ,
56
+ SupportedBrowser . Chrome or SupportedBrowser . ChromeHeadlessShell => Chrome . DefaultBuildId ,
57
+ SupportedBrowser . Chromium => await Chromium . ResolveBuildIdAsync ( BrowserFetcher . GetCurrentPlatform ( ) ) . ConfigureAwait ( false ) ,
58
+ _ => throw new ArgumentException ( "Invalid browser" ) ,
59
+ } ;
60
+ var executable = options . ExecutablePath ?? GetExecutablePath ( options , buildId ) ;
56
61
57
62
Process = options . Browser switch
58
63
{
Original file line number Diff line number Diff line change 12
12
<Description >Headless Browser .NET API</Description >
13
13
<PackageId >PuppeteerSharp</PackageId >
14
14
<PackageReleaseNotes ></PackageReleaseNotes >
15
- <PackageVersion >18.0.0 </PackageVersion >
16
- <ReleaseVersion >18.0.0 </ReleaseVersion >
17
- <AssemblyVersion >18.0.0 </AssemblyVersion >
15
+ <PackageVersion >18.0.1 </PackageVersion >
16
+ <ReleaseVersion >18.0.1 </ReleaseVersion >
17
+ <AssemblyVersion >18.0.1 </AssemblyVersion >
18
18
<FileVersion >18.0.0</FileVersion >
19
19
<SynchReleaseVersion >false</SynchReleaseVersion >
20
20
<StyleCopTreatErrorsAsWarnings >false</StyleCopTreatErrorsAsWarnings >
You can’t perform that action at this time.
0 commit comments