Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 20d6fab

Browse files
authoredApr 23, 2024
Roll Chrome to 124 (#2610)
1 parent f8ff8af commit 20d6fab

File tree

3 files changed

+7
-13
lines changed

3 files changed

+7
-13
lines changed
 

‎lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.upstream.json‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -915,13 +915,6 @@
915915
"expectations": ["SKIP"],
916916
"comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
917917
},
918-
{
919-
"testIdPattern": "[accessibility.spec] Accessibility should work",
920-
"platforms": ["darwin", "linux", "win32"],
921-
"parameters": ["chrome", "webDriverBiDi"],
922-
"expectations": ["FAIL"],
923-
"comment": "Change in A11Y tree on Canary"
924-
},
925918
{
926919
"testIdPattern": "[ariaqueryhandler.spec] AriaQueryHandler queryOne (Chromium web test) should find by role \"button\"",
927920
"platforms": ["darwin", "linux", "win32"],

‎lib/PuppeteerSharp.Tests/AccessibilityTests/AccessibilityTests.cs‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,17 +87,18 @@ await Page.SetContentAsync(@"
8787
Name= "",
8888
Value= "First Option",
8989
HasPopup = "menu",
90-
Children= new SerializedAXNode[]{
90+
Children=
91+
[
9192
new() {
92-
Role = "menuitem",
93+
Role = "option",
9394
Name = "First Option",
9495
Selected= true
9596
},
9697
new() {
97-
Role = "menuitem",
98+
Role = "option",
9899
Name = "Second Option"
99100
}
100-
}
101+
]
101102
}
102103
}
103104
};
@@ -188,7 +189,7 @@ await Page.SetContentAsync(@"
188189

189190
var button = await Page.QuerySelectorAsync("button");
190191
Assert.AreEqual("Show", await GetAccessibleNameAsync(Page, button));
191-
await button?.ClickAsync();
192+
await button!.ClickAsync();
192193
await Page.WaitForSelectorAsync("aria/Hide");
193194
}
194195

‎lib/PuppeteerSharp/BrowserData/Chrome.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public static class Chrome
1313
/// <summary>
1414
/// Default chrome build.
1515
/// </summary>
16-
public static string DefaultBuildId => "123.0.6312.86";
16+
public static string DefaultBuildId => "124.0.6367.60";
1717

1818
internal static async Task<string> ResolveBuildIdAsync(ChromeReleaseChannel channel)
1919
=> (await GetLastKnownGoodReleaseForChannel(channel).ConfigureAwait(false)).Version;

0 commit comments

Comments
 (0)
Please sign in to comment.