🧪 fix(build): fmt + resolve clippy warnings

- Updated build.rs to automatically fix format string patterns in generated code
- Applied format string replacements to eliminate clippy::uninlined_format_args warnings
- Fixed format strings in telemetry test for consistency

Author: hardbyte

.github/workflows/ci.yml

@@ -37,16 +37,16 @@ jobs:
       run: cargo fmt --all -- --check
 
     - name: Run clippy
-      run: cargo clippy --all-targets --all-features -- -D warnings
+      run: SQLX_OFFLINE=true cargo clippy --all-targets --all-features -- -D warnings
 
     - name: Build workspace
-      run: cargo build --workspace
+      run: SQLX_OFFLINE=true cargo build --workspace
 
     # Start services for both unit tests (with external access) and integration tests
     - name: Start services for testing
       run: |
         echo "Starting Docker services..."
-        docker compose up -d --build
+        docker compose --profile ci up -d --build
         
         echo "Waiting for core services (DB, Kafka) to be ready..."
         max_attempts=20
@@ -135,4 +135,4 @@ jobs:
 
     - name: Cleanup
       if: always()
-      run: docker compose down -v
+      run: docker compose --profile ci down -v

client/build.rs

@@ -29,7 +29,26 @@ fn main() {
         .generate_tokens(&spec)
         .expect("Could not generate tokens");
     let ast = syn::parse2(tokens).unwrap();
-    let content = prettyplease::unparse(&ast);
+    let mut content = prettyplease::unparse(&ast);
+
+    // Fix clippy::uninlined_format_args warnings by replacing format string patterns
+    content = content.replace(
+        r#"format!("error converting supplied value for author: {}", e)"#,
+        r#"format!("error converting supplied value for author: {e}")"#,
+    );
+    content = content.replace(
+        r#"format!("error converting supplied value for id: {}", e)"#,
+        r#"format!("error converting supplied value for id: {e}")"#,
+    );
+    content = content.replace(
+        r#"format!("error converting supplied value for title: {}", e)"#,
+        r#"format!("error converting supplied value for title: {e}")"#,
+    );
+    content = content.replace(
+        r#"format!("conversion to `BookCreateIn` for body failed: {}", s)"#,
+        r#"format!("conversion to `BookCreateIn` for body failed: {s}")"#,
+    );
+
     let content = format!("#![allow(clippy::all)]\n{content}");
 
     let mut out_file = std::path::Path::new("src").to_path_buf();

client/src/generated.rs

@@ -170,7 +170,7 @@ pub mod types {
             {
                 self.author = value
                     .try_into()
-                    .map_err(|e| format!("error converting supplied value for author: {}", e));
+                    .map_err(|e| format!("error converting supplied value for author: {e}"));
                 self
             }
             pub fn id<T>(mut self, value: T) -> Self
@@ -180,7 +180,7 @@ pub mod types {
             {
                 self.id = value
                     .try_into()
-                    .map_err(|e| format!("error converting supplied value for id: {}", e));
+                    .map_err(|e| format!("error converting supplied value for id: {e}"));
                 self
             }
             pub fn title<T>(mut self, value: T) -> Self
@@ -190,7 +190,7 @@ pub mod types {
             {
                 self.title = value
                     .try_into()
-                    .map_err(|e| format!("error converting supplied value for title: {}", e));
+                    .map_err(|e| format!("error converting supplied value for title: {e}"));
                 self
             }
         }
@@ -240,7 +240,7 @@ pub mod types {
             {
                 self.author = value
                     .try_into()
-                    .map_err(|e| format!("error converting supplied value for author: {}", e));
+                    .map_err(|e| format!("error converting supplied value for author: {e}"));
                 self
             }
             pub fn title<T>(mut self, value: T) -> Self
@@ -250,7 +250,7 @@ pub mod types {
             {
                 self.title = value
                     .try_into()
-                    .map_err(|e| format!("error converting supplied value for title: {}", e));
+                    .map_err(|e| format!("error converting supplied value for title: {e}"));
                 self
             }
         }
@@ -498,7 +498,7 @@ pub mod builder {
             self.body = value
                 .try_into()
                 .map(From::from)
-                .map_err(|s| format!("conversion to `BookCreateIn` for body failed: {}", s));
+                .map_err(|s| format!("conversion to `BookCreateIn` for body failed: {s}"));
             self
         }
         pub fn body_map<F>(mut self, f: F) -> Self
@@ -714,7 +714,7 @@ pub mod builder {
             self.body = value
                 .try_into()
                 .map(From::from)
-                .map_err(|s| format!("conversion to `BookCreateIn` for body failed: {}", s));
+                .map_err(|s| format!("conversion to `BookCreateIn` for body failed: {s}"));
             self
         }
         pub fn body_map<F>(mut self, f: F) -> Self

docker-compose.yaml

@@ -124,6 +124,9 @@ services:
       target: builder # Use the builder stage from the Dockerfile
     environment:
       OTEL_EXPORTER_OTLP_ENDPOINT: http://telemetry:4317
+      APP_BASE_URL: "http://app:8000"
+      TELEMETRY_BASE_URL: "http://telemetry:3000"
+      TEMPO_DIRECT_URL: "http://telemetry:3200"
       RUST_LOG: "info,integration_tests=trace,integration_tests::telemetry_test=trace" # Enable trace logs for our test crate and specific test module
       RUST_BACKTRACE: "1"
       # DATABASE_URL is not strictly needed by this test unless tests evolve to touch DB directly