BUG/MINOR: service deletion upon ServiceDiscovery update

prometherion · aiharos · commit 6acd2ddbf80f · 2021-04-06T18:16:42.000+02:00
diff --git a/discovery/service_discovery_instance.go b/discovery/service_discovery_instance.go
@@ -106,7 +106,8 @@ func (s *ServiceDiscoveryInstance) UpdateServices(services []ServiceInstance) er
 		}
 		reload = reload || r
 	}
-	reload = reload || s.removeDeleted()
+	r := s.removeDeleted()
+	reload = reload || r
 	if reload {
 		if err := s.commitTransaction(); err != nil {
 			return err

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,8 @@ func (s *ServiceDiscoveryInstance) UpdateServices(services []ServiceInstance) er`
`106`	`106`	`}`
`107`	`107`	`reload = reload \|\| r`
`108`	`108`	`}`
`109`		`- reload = reload \|\| s.removeDeleted()`
	`109`	`+ r := s.removeDeleted()`
	`110`	`+ reload = reload \|\| r`
`110`	`111`	`if reload {`
`111`	`112`	`if err := s.commitTransaction(); err != nil {`
`112`	`113`	`return err`