Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Unused Variable eps_returns in examples/baselines/ppo/ppo.py #803

Closed
songyuc opened this issue Jan 20, 2025 · 1 comment · Fixed by #837
Closed

Potential Unused Variable eps_returns in examples/baselines/ppo/ppo.py #803

songyuc opened this issue Jan 20, 2025 · 1 comment · Fixed by #837

Comments

@songyuc
Copy link
Contributor

songyuc commented Jan 20, 2025

Hello developers,

I'm a student and I was reviewing the code in examples/baselines/ppo/ppo.py. I noticed a variable named eps_returns that is initialized here:

eps_returns = torch.zeros(args.num_envs, dtype=torch.float, device=device)

After inspecting the codebase, I couldn't find any instances where this variable is used (read or modified) after its initialization.

I was wondering if this variable is a leftover from previous development or if it has a purpose that I might be missing.

Thank you for your time and clarification!

@StoneT2000
Copy link
Member

Thanks! It is not needed anymor4e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants