Skip to content

Commit e04b061

Browse files
committed
fix context menu
1 parent 3eaaf27 commit e04b061

File tree

5 files changed

+130
-9
lines changed

5 files changed

+130
-9
lines changed

package-lock.json

Lines changed: 118 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@
6767
"dot-json": "^1.2.0",
6868
"eslint": "^6.8.0",
6969
"eslint-plugin-svelte3": "^2.7.3",
70+
"husky": "^4.2.5",
7071
"npm-run-all": "^4.1.5",
7172
"rollup": "^2.6.1",
7273
"rollup-plugin-copy-glob": "^0.3.1",
@@ -77,5 +78,10 @@
7778
"svelte": "^3.20.1",
7879
"web-ext": "^4.1.0",
7980
"xo": "^0.29.1"
81+
},
82+
"husky":{
83+
"hooks":{
84+
"pre-commit": "npm run fix"
85+
}
8086
}
8187
}

source/App.svelte

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,12 @@
7171
});
7272
});
7373
74-
// Show extra buttons on right click on the name
74+
// Toggle extra buttons on right click on the name
7575
let onContextMenu;
76-
$: onContextMenu = showExtras ? () => {} : (event => {
77-
showExtras = true;
76+
$: onContextMenu = event => {
77+
showExtras = !showExtras;
7878
event.preventDefault();
79-
});
79+
};
8080
</script>
8181

8282
<svelte:window on:keydown={keyboardNavigationHandler}/>

source/Extension.svelte

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,7 @@
4949
<button type="button" class="ext-name" on:click={toggleExtension} on:contextmenu>
5050
<img alt="" src={getIcon(icons, 16)}>{name}
5151
</button>
52-
53-
{#if enabled}
54-
{#if optionsUrl}
52+
{#if showExtras || (optionsUrl && enabled)}
5553
<a href='chrome://extensions/?options={id}' title={getI18N('gotoOpt')} on:click={openInTab}>
5654
<img src="icons/options.svg" alt="">
5755
</a>
@@ -69,5 +67,4 @@
6967
<img src="icons/bin.svg" alt="">
7068
</button>
7169
{/if}
72-
{/if}
7370
</li>

source/lib/open-in-tab.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/** Required for chrome:// links */
22
export default function openInTab(event) {
3-
browser.tabs.create({url: event.target.href});
3+
browser.tabs.create({url: event.currentTarget.href});
44
event.preventDefault();
55
}

0 commit comments

Comments
 (0)