Add recommendation to add namespace to operations

Author: cllns

lib/hanami/cli/files.rb

@@ -42,6 +42,12 @@ def chdir(path, &blk)
         super
       end
 
+      # @since x.x.x
+      # @api private
+      def recommend(message)
+        out.puts("  Recommendation: #{message}")
+      end
+
       private
 
       attr_reader :out

lib/hanami/cli/generators/app/operation.rb

@@ -46,6 +46,7 @@ def generate_for_slice(context, slice)
             else
               fs.mkdir(directory = fs.join(slice_directory))
               fs.write(fs.join(directory, "#{context.name}.rb"), t("top_level_slice_operation.erb", context))
+              fs.recommend("Add a namespace to operation names, so they go into a folder within #{directory}/.")
             end
           end
 
@@ -56,6 +57,7 @@ def generate_for_app(context)
             else
               fs.mkdir(directory = fs.join("app"))
               fs.write(fs.join(directory, "#{context.name}.rb"), t("top_level_app_operation.erb", context))
+              fs.recommend("Add a namespace to operation names, so they go into a folder within #{directory}/.")
             end
           end
 

spec/unit/hanami/cli/commands/app/generate/operation_spec.rb

@@ -17,7 +17,7 @@ def output
   end
 
   context "generating for app" do
-    it "generates an operation" do
+    it "generates an operation without a namespace, with a recommendation" do
       subject.call(name: "add_book")
 
       operation_file = <<~EXPECTED
@@ -33,6 +33,7 @@ def call
 
       expect(fs.read("app/add_book.rb")).to eq(operation_file)
       expect(output).to include("Created app/add_book.rb")
+      expect(output).to include("  Recommendation: Add a namespace to operation names, so they go into a folder within app/")
     end
 
     it "generates a operation in a deep namespace with default separator" do
@@ -81,7 +82,7 @@ def call
   end
 
   context "generating for a slice" do
-    it "generates a operation in a top-level namespace" do
+    it "generates a operation in a top-level namespace, with recommendation" do
       fs.mkdir("slices/main")
       subject.call(name: "add_book", slice: "main")
 
@@ -98,6 +99,30 @@ def call
 
       expect(fs.read("slices/main/add_book.rb")).to eq(operation_file)
       expect(output).to include("Created slices/main/add_book.rb")
+      expect(output).to include("  Recommendation: Add a namespace to operation names, so they go into a folder within slices/main/")
+    end
+
+    it "generates a operation in a nested namespace" do
+      fs.mkdir("slices/main")
+      subject.call(name: "admin.books.add", slice: "main")
+
+      operation_file = <<~EXPECTED
+        # frozen_string_literal: true
+
+        module Main
+          module Admin
+            module Books
+              class Add < Main::Operation
+                def call
+                end
+              end
+            end
+          end
+        end
+      EXPECTED
+
+      expect(fs.read("slices/main/admin/books/add.rb")).to eq(operation_file)
+      expect(output).to include("Created slices/main/admin/books/add.rb")
     end
   end
 end