You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: README.md
+24-71
Original file line number
Diff line number
Diff line change
@@ -10,7 +10,7 @@
10
10
11
11
1. Fork this repository and clone the fork to your machine
12
12
2. Install the dependencies `npm install`
13
-
3. Start the application `npm start`
13
+
3. Start the application in development mode `npm dev` (then open [http://localhost:3000](http://localhost:3000) to view it in your browser)
14
14
15
15
## Overview
16
16
@@ -27,9 +27,12 @@ Using the provided Figma design and data files the application should:
27
27
28
28
#### What's provided
29
29
30
-
This repository contains the [Create React App](https://create-react-app.dev/) boilerplate code using the TypeScript template, a CSS reset, and the Mortal Kombot logo image. You are free to use any other boilerplate or React framework that uses TypeScript if you'd prefer.
30
+
### NOTES
31
+
I've added material-ui's baseline (to normalise styles between browsers). Feel free to replace with something like normalize.css if you'd prefer.
31
32
32
-
We've also put together a `.json` file containing all Character data (sourced from [DashFight](https://dashfight.com/) and [EventHubs](https://www.eventhubs.com/)) from various fighting games (Mortal Kombat, Street Fighter, Super Smash Bros. and Dragon Ball Z). You can import this file directly into your code to complete the challenge. You'll find this in the `./src/data` directory.
33
+
This repository contains boilerplate code for a [Next.js](https://nextjs.org/) project using the Next.js Pages router, TypeScript, a CSS reset (via the Material-UI design library's Baseline component), and the Mortal Kombot logo image. You are free to use any other boilerplate or React framework that uses TypeScript if you'd prefer.
34
+
35
+
We've also put together a `.json` file containing all Character data (sourced from [DashFight](https://dashfight.com/) and [EventHubs](https://www.eventhubs.com/)) from various fighting games (Mortal Kombat, Street Fighter, Super Smash Bros. and Dragon Ball Z). You can import this file directly into your code to complete the challenge (this has been done inside the `pages/index.tsx` file). You'll find the data file located in the `./data` directory.
33
36
34
37
##### Figma design files
35
38
@@ -39,86 +42,36 @@ We've also put together a `.json` file containing all Character data (sourced fr
39
42
40
43
#### Constraints
41
44
42
-
- 2–4 hours over ~5 days
43
45
- React + TypeScript
44
46
45
47
## Expectations
46
48
47
-
**We do not expect you to spend more than 2–4 hours on the challenge**, and we understand that it's unrealistic to implement a complete and polished solution in this time frame. We also have intentionally built-in some poor usability patterns that we'd love for you to improve upon. If you feel there was more you could do to improve it by the end of this time, please add some notes about what you'd change. We'll discuss these with you in person (or video call). We are looking for good architectural decisions, modularity, readability, and adherence to industry best practices.
48
-
49
-
## Submission
50
-
51
-
Once you've finished you can send us the URL to your repository via email. If your repository is private let us know and we'll send you the GitHub accounts that will need access to review the submission.
52
-
53
-
You are free to open source your work if you like.
54
-
55
-
# Create React App Readme
56
-
57
-
This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app).
58
-
59
-
## Available Scripts
60
-
61
-
In the project directory, you can run:
62
-
63
-
### `npm start`
64
-
65
-
Runs the app in the development mode.\
66
-
Open [http://localhost:3000](http://localhost:3000) to view it in your browser.
67
-
68
-
The page will reload when you make changes.\
69
-
You may also see any lint errors in the console.
70
-
71
-
### `npm test`
72
-
73
-
Launches the test runner in the interactive watch mode.\
74
-
See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information.
49
+
**We do not expect you to spend more than a few hours on the challenge**, and we understand that it's unrealistic to implement a complete and polished solution in this time frame.
75
50
76
-
### `npm run build`
51
+
We have intentionally built-in some poor usability patterns that we'd love for you to either:
52
+
a) improve upon, or
53
+
b) suggest improvements, or
54
+
c) even just point out an awareness of problems/issues would be valuable.
77
55
78
-
Builds the app for production to the `build` folder.\
79
-
It correctly bundles React in production mode and optimizes the build for the best performance.
56
+
If you feel there was more you could do to improve by the end of this time, please add some notes (e.g. dot points ) about what you'd change.
80
57
81
-
The build is minified and the filenames include the hashes.\
82
-
Your app is ready to be deployed!
58
+
We'll discuss these with you in person (or video call). We are looking for sensible structure, readability, and adherence to industry best practices.
83
59
84
-
See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information.
60
+
## Styling
85
61
86
-
### `npm run eject`
62
+
Note we're flexible on whatever approach to styling you want to use.
87
63
88
-
**Note: this is a one-way operation. Once you `eject`, you can't go back!**
64
+
We've tried to setup a few options to make getting started easier/quicker, being:
65
+
- global css/scss, or
66
+
- css modules, or even
67
+
- style props available in [Material UI](https://mui.com/material-ui/getting-started/)
89
68
90
-
If you aren't satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project.
69
+
Feel free to add any other libraries if you have a preferred way of working (e.g. Tailwind).
91
70
92
-
Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you're on your own.
93
-
94
-
You don't have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn't feel obligated to use this feature. However we understand that this tool wouldn't be useful if you couldn't customize it when you are ready for it.
95
-
96
-
## Learn More
97
-
98
-
You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started).
99
-
100
-
To learn React, check out the [React documentation](https://reactjs.org/).
101
-
102
-
### Code Splitting
103
-
104
-
This section has moved here: [https://facebook.github.io/create-react-app/docs/code-splitting](https://facebook.github.io/create-react-app/docs/code-splitting)
105
-
106
-
### Analyzing the Bundle Size
107
-
108
-
This section has moved here: [https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size](https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size)
109
-
110
-
### Making a Progressive Web App
111
-
112
-
This section has moved here: [https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app](https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app)
113
-
114
-
### Advanced Configuration
115
-
116
-
This section has moved here: [https://facebook.github.io/create-react-app/docs/advanced-configuration](https://facebook.github.io/create-react-app/docs/advanced-configuration)
117
-
118
-
### Deployment
71
+
## Submission
119
72
120
-
This section has moved here: [https://facebook.github.io/create-react-app/docs/deployment](https://facebook.github.io/create-react-app/docs/deployment)
73
+
Once you've finished you can send us the URL to your repository via email. If your repository is private let us know and we'll send you the GitHub accounts that will need access to review the submission.
121
74
122
-
### `npm run build` fails to minify
75
+
You are free to open source your work if you like.
123
76
124
-
This section has moved here: [https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify](https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify)
0 commit comments