Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Render] Optimizations (Part 1) #6

Open
2 tasks
halotroop2288 opened this issue Feb 25, 2020 · 5 comments
Open
2 tasks

[Render] Optimizations (Part 1) #6

halotroop2288 opened this issue Feb 25, 2020 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@halotroop2288
Copy link
Member

halotroop2288 commented Feb 25, 2020

Aggressive optimizations have been implemented (869795a ?) to cull inner cubes, but inner faces are still a problem, and still severely weigh down the rendering.

@halotroop2288 halotroop2288 added the enhancement New feature or request label Feb 25, 2020
@hYdos hYdos closed this as completed Feb 29, 2020
@halotroop2288
Copy link
Member Author

halotroop2288 commented Feb 29, 2020

Face culling is definitely not done. Nice try.
https://i.gyazo.com/54d857d6a044910bf93e5e2b8fce855f.mp4

@halotroop2288 halotroop2288 reopened this Feb 29, 2020
@hYdos
Copy link

hYdos commented Feb 29, 2020

we are optimising a different way this issue is not needed anymore

@hYdos hYdos closed this as completed Feb 29, 2020
@halotroop2288
Copy link
Member Author

DO NOT close issues without proper discussion. Culling is still not finished.
Close this issue again without finishing the optimizations and you will lose your permissions.

@hYdos
Copy link

hYdos commented Feb 29, 2020

gl @SuperCoder7979

@halotroop2288
Copy link
Member Author

This seems like a reasonable solution to meshing but it's very simplified, so I don't know how you would accomplish it.

If I understand it correctly, here's what needs to be done:

  • Collect all faces in a chunk and render to a single VAO
  • Render that VAO for the chunk

@halotroop2288 halotroop2288 added the help wanted Extra attention is needed label Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants