Merge pull request #4 from hadilq/cool-reactive-feature-flags

Feature Flags

Author: hadilq

.gitignore

@@ -1,16 +1,6 @@
 *.iml
 .gradle
 /local.properties
-/.idea/caches
-/.idea/libraries
-/.idea/modules.xml
-/.idea/workspace.xml
-/.idea/navEditor.xml
-/.idea/assetWizardSettings.xml
-.idea/gradle.xml
-.idea/misc.xml
-.idea/runConfigurations.xml
-.idea/vcs.xml
 .DS_Store
 /build
 /captures

.idea/.gitignore

@@ -1,6 +1,6 @@
 # Clean Architecture
 
-This is a sample app to show best practices up to authors's knowledge by trying to
+This is a sample app to show best practices up to author's knowledge by trying to
 stay close to standard technologies for a highly scalable, maintainable, and testable
 Android app.
 

.idea/jarRepositories.xml

@@ -13,6 +13,10 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+import featureflags.installScenario
+import featureflags.loadScenarioFromLocal
+import featureflags.scenarios
+
 
 plugins {
   id("com.android.application")
@@ -53,20 +57,22 @@ android {
   }
 
   packagingOptions {
-    exclude("META-INF/public_release.kotlin_module")
-    exclude("META-INF/impl_release.kotlin_module")
+    exclude("META-INF/*.kotlin_module")
   }
 }
 
 dependencies {
+  installScenario(scenarios, project.loadScenarioFromLocal())
+
   implementation(project(Modules.corePublic))
   implementation(project(Modules.coreImpl))
+  implementation(project(Modules.diPublic))
   implementation(project(Modules.singleActivityPublic))
   implementation(project(Modules.singleActivityImpl))
   implementation(project(Modules.guidomiaPublic))
-  implementation(project(Modules.guidomiaImpl))
   implementation(project(Modules.databasePublic))
-  implementation(project(Modules.databaseImpl))
+  implementation(project(Modules.featureFlagsPublic))
+  implementation(project(Modules.featureFlagsImpl))
 
   kapt(Depends.daggerCompiler)
 

README.md

@@ -16,12 +16,15 @@
 package com.hadilq.guidomia
 
 import android.app.Application
-import com.hadilq.guidomia.core.api.di.AppScope
-import com.hadilq.guidomia.core.api.di.SingleIn
+import com.github.hadilq.commandku.api.CommandHook
+import com.github.hadilq.commandku.api.CommandRegister
 import com.hadilq.guidomia.di.AppComponent
 import com.hadilq.guidomia.di.DaggerAppComponent
+import com.hadilq.guidomia.di.api.AppScope
+import com.hadilq.guidomia.di.api.SingleIn
 import com.hadilq.guidomia.singleactivity.impl.di.SingleActivityComponent
 import com.hadilq.guidomia.singleactivity.impl.di.SingleActivityComponentProvider
+import javax.inject.Inject
 
 @SingleIn(AppScope::class)
 class CustomApplication : Application(), SingleActivityComponentProvider {
@@ -34,4 +37,20 @@ class CustomApplication : Application(), SingleActivityComponentProvider {
 
   override val singleActivityComponentProvider: SingleActivityComponent.Builder
     get() = component.singleActivityComponentBuilder()
+
+  @Inject
+  protected lateinit var commandHookSet: Set<@JvmSuppressWildcards CommandHook>
+
+  @Inject
+  protected lateinit var commandRegister: CommandRegister
+
+  override fun onCreate() {
+    super.onCreate()
+    component.inject(this)
+    hookUpFeatureFlags()
+  }
+
+  private fun hookUpFeatureFlags() {
+    commandHookSet.forEach { it.hookUp(commandRegister) }
+  }
 }

app/build.gradle.kts

@@ -16,8 +16,8 @@
 package com.hadilq.guidomia.di
 
 import com.hadilq.guidomia.CustomApplication
-import com.hadilq.guidomia.core.api.di.AppScope
-import com.hadilq.guidomia.core.api.di.SingleIn
+import com.hadilq.guidomia.di.api.AppScope
+import com.hadilq.guidomia.di.api.SingleIn
 import com.hadilq.guidomia.singleactivity.impl.di.SingleActivityComponent
 import com.squareup.anvil.annotations.MergeComponent
 import dagger.BindsInstance
@@ -39,7 +39,7 @@ interface AppComponent {
     fun build(): AppComponent
   }
 
+  fun inject(app: CustomApplication)
+
   fun singleActivityComponentBuilder(): SingleActivityComponent.Builder
-  fun fragmentComponentBuilder(): FragmentComponent.Builder
-  fun retainComponentBuilder(): RetainComponent.Builder
 }

app/src/main/java/com/hadilq/guidomia/CustomApplication.kt

@@ -16,13 +16,24 @@
 package com.hadilq.guidomia.di
 
 import android.content.Context
+import com.github.hadilq.commandku.api.CommandHook
+import com.github.hadilq.commandku.api.CommandRegister
 import com.hadilq.guidomia.CustomApplication
+import com.hadilq.guidomia.di.api.AppScope
+import com.squareup.anvil.annotations.ContributesMultibinding
 import dagger.Binds
 import dagger.Module
+import javax.inject.Inject
 
 @Module
 interface AppModule {
 
   @Binds
   fun provideContext(app: CustomApplication): Context
 }
+
+@ContributesMultibinding(AppScope::class)
+class EmptyHook @Inject constructor() : CommandHook {
+  override fun hookUp(commandRegister: CommandRegister) {
+  }
+}

app/src/main/java/com/hadilq/guidomia/di/AppComponent.kt

@@ -18,7 +18,7 @@ package com.hadilq.guidomia.di.fragment
 import androidx.fragment.app.Fragment
 import com.hadilq.guidomia.core.api.FragmentFactory
 import com.hadilq.guidomia.core.api.SimpleFragmentFactory
-import com.hadilq.guidomia.core.api.di.AppScope
+import com.hadilq.guidomia.di.api.AppScope
 import com.squareup.anvil.annotations.ContributesBinding
 import javax.inject.Inject
 import kotlin.reflect.KClass

app/src/main/java/com/hadilq/guidomia/di/AppModule.kt

@@ -18,7 +18,7 @@ package com.hadilq.guidomia.di.viewmodel
 import androidx.lifecycle.ViewModel
 import com.hadilq.guidomia.core.api.SimpleViewModelFactory
 import com.hadilq.guidomia.core.api.ViewModelFactory
-import com.hadilq.guidomia.core.api.di.AppScope
+import com.hadilq.guidomia.di.api.AppScope
 import com.squareup.anvil.annotations.ContributesBinding
 import javax.inject.Inject
 

app/src/main/java/com/hadilq/guidomia/di/fragment/FragmentFactoryImpl.kt

@@ -30,4 +30,4 @@ allprojects {
         google()
         mavenCentral()
     }
-}
+}

app/src/main/java/com/hadilq/guidomia/di/fragment/GuidomiaFragmentFactory.kt

@@ -15,6 +15,7 @@
  */
 object Depends {
   const val kotlinStdLib = "org.jetbrains.kotlin:kotlin-stdlib:${Versions.kotlin}"
+  const val kotlinTest = "org.jetbrains.kotlin:kotlin-test:${Versions.kotlin}"
   const val coreKtx = "androidx.core:core-ktx:${Versions.coreKtx}"
   const val appCompat = "androidx.appcompat:appcompat:${Versions.appCompat}"
   const val material = "com.google.android.material:material:${Versions.material}"
@@ -32,6 +33,8 @@ object Depends {
   const val roomRuntime = "androidx.room:room-runtime:${Versions.room}"
   const val roomCompiler = "androidx.room:room-compiler:${Versions.room}"
   const val roomKtx = "androidx.room:room-ktx:${Versions.room}"
+  const val commandKuApi = "com.github.hadilq:command-ku-api:${Versions.commandKu}"
+  const val commandKuImpl = "com.github.hadilq:command-ku-impl:${Versions.commandKu}"
 
   const val junit = "junit:junit:${Versions.junit}"
   const val junitJupiterApi = "org.junit.jupiter:junit-jupiter-api:${Versions.junitJupiter}"

app/src/main/java/com/hadilq/guidomia/di/viewmodel/GuidomiaViewModelFactory.kt

@@ -16,10 +16,13 @@
 object Modules {
   const val corePublic = ":core:public"
   const val coreImpl = ":core:impl"
+  const val diPublic = ":di:public"
   const val singleActivityPublic = ":single-activity:public"
   const val singleActivityImpl = ":single-activity:impl"
   const val guidomiaPublic = ":guidomia:public"
   const val guidomiaImpl = ":guidomia:impl"
   const val databaseImpl = ":database:impl"
   const val databasePublic = ":database:public"
+  const val featureFlagsImpl = ":feature-flags:impl"
+  const val featureFlagsPublic = ":feature-flags:public"
 }

app/src/main/java/com/hadilq/guidomia/di/viewmodel/ViewModelFactoryImpl.kt

@@ -33,6 +33,7 @@ object Versions {
   const val serialization = "1.4.30"
   const val jsonSerialization = "1.1.0"
   const val room = "2.2.6"
+  const val commandKu = "0.0.1"
 
   const val junit = "4.13.2"
   const val junitJupiter = "5.7.1"