Skip to content

Commit 99796a0

Browse files
committed
refactor
1 parent 719aa6e commit 99796a0

File tree

3 files changed

+16
-10
lines changed

3 files changed

+16
-10
lines changed

src/gui.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ use crate::settings_window::settings_window;
1414
use crate::toggle::toggle;
1515
use crate::update::check_update;
1616
use crate::FileOptions;
17-
use crate::{APP_INFO, PREFS_KEY};
17+
use crate::{APP_INFO, PREFERENCES_KEY};
1818
use eframe::egui::panel::Side;
1919
use eframe::egui::{
2020
Align2, CollapsingHeader, Color32, FontFamily, FontId, KeyboardShortcut, Pos2, Sense, Ui, Vec2,
@@ -90,10 +90,10 @@ impl Default for GuiSettingsContainer {
9090
}
9191

9292
pub fn load_gui_settings() -> GuiSettingsContainer {
93-
GuiSettingsContainer::load(&APP_INFO, PREFS_KEY).unwrap_or_else(|_| {
93+
GuiSettingsContainer::load(&APP_INFO, PREFERENCES_KEY).unwrap_or_else(|_| {
9494
let gui_settings = GuiSettingsContainer::default();
9595
// save default settings
96-
if gui_settings.save(&APP_INFO, PREFS_KEY).is_err() {
96+
if gui_settings.save(&APP_INFO, PREFERENCES_KEY).is_err() {
9797
log::error!("failed to save gui_settings");
9898
}
9999
gui_settings
@@ -1300,7 +1300,7 @@ impl eframe::App for MyApp {
13001300

13011301
fn save(&mut self, _storage: &mut dyn Storage) {
13021302
save_serial_settings(&self.serial_devices);
1303-
if let Err(err) = self.gui_conf.save(&APP_INFO, PREFS_KEY) {
1303+
if let Err(err) = self.gui_conf.save(&APP_INFO, PREFERENCES_KEY) {
13041304
log::error!("gui settings save failed: {:?}", err);
13051305
}
13061306
}

src/main.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ const APP_INFO: AppInfo = AppInfo {
3434
name: "Serial Monitor",
3535
author: "Linus Leo Stöckli",
3636
};
37-
const PREFS_KEY: &str = "config/gui";
38-
const PREFS_KEY_SERIAL: &str = "config/serial_devices";
37+
const PREFERENCES_KEY: &str = "config/gui";
38+
const PREFERENCES_KEY_SERIAL: &str = "config/serial_devices";
3939

4040
fn split(payload: &str) -> Vec<f32> {
4141
let mut split_data: Vec<&str> = vec![];

src/serial.rs

+10-4
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ use std::time::{Duration, Instant};
99

1010
use crate::color_picker::COLORS;
1111
use crate::data::{get_epoch_ms, SerialDirection};
12-
use crate::{Packet, APP_INFO, PREFS_KEY_SERIAL};
12+
use crate::{Packet, APP_INFO, PREFERENCES_KEY_SERIAL};
1313

1414
#[derive(Debug, Clone, Serialize, Deserialize)]
1515
pub struct SerialDevices {
@@ -37,7 +37,7 @@ impl Default for SerialDevices {
3737
}
3838

3939
pub fn load_serial_settings() -> SerialDevices {
40-
SerialDevices::load(&APP_INFO, PREFS_KEY_SERIAL).unwrap_or_else(|_| {
40+
SerialDevices::load(&APP_INFO, PREFERENCES_KEY_SERIAL).unwrap_or_else(|_| {
4141
let serial_configs = SerialDevices::default();
4242
// save default settings
4343
save_serial_settings(&serial_configs);
@@ -46,14 +46,20 @@ pub fn load_serial_settings() -> SerialDevices {
4646
}
4747

4848
pub fn save_serial_settings(serial_configs: &SerialDevices) {
49-
if serial_configs.save(&APP_INFO, PREFS_KEY_SERIAL).is_err() {
49+
if serial_configs
50+
.save(&APP_INFO, PREFERENCES_KEY_SERIAL)
51+
.is_err()
52+
{
5053
log::error!("failed to save gui_settings");
5154
}
5255
}
5356

5457
pub fn clear_serial_settings() {
5558
let serial_configs = SerialDevices::default();
56-
if serial_configs.save(&APP_INFO, PREFS_KEY_SERIAL).is_err() {
59+
if serial_configs
60+
.save(&APP_INFO, PREFERENCES_KEY_SERIAL)
61+
.is_err()
62+
{
5763
log::error!("failed to clear gui_settings");
5864
}
5965
}

0 commit comments

Comments
 (0)