Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lost schema of S3 URL. #1892

Open
fukumoto-ts opened this issue Feb 20, 2025 · 0 comments · May be fixed by #1893
Open

Lost schema of S3 URL. #1892

fukumoto-ts opened this issue Feb 20, 2025 · 0 comments · May be fixed by #1893

Comments

@fukumoto-ts
Copy link

fukumoto-ts commented Feb 20, 2025 •
edited
Loading

Since v2.5.0, S3 URL schema is now lost.

Image

This is caused by a change in this PR. #1762 (#1761)

It would be good to change it like this.

Now:
https://github.com/blademainer/codimd/blob/7b1e4e3ddb2ef07d1170dcd819986252d5758596/lib/imageRouter/s3.js#L54

s3Endpoint = `s3-${config.s3.region}.amazonaws.com`

After:

s3Endpoint = `https://s3-${config.s3.region}.amazonaws.com`
@fukumoto-ts fukumoto-ts linked a pull request Feb 20, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Lost schema of S3 URL. fukumoto-ts/codimd
1 participant
@fukumoto-ts