Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't center map to position when far from Paris #84

Open
1 of 3 tasks
eliemichel opened this issue Oct 3, 2015 · 5 comments
Open
1 of 3 tasks

Don't center map to position when far from Paris #84

eliemichel opened this issue Oct 3, 2015 · 5 comments

Comments

@eliemichel
Copy link
Member

I also suggest to disable the bike and stand view then, or at least the display of the path to reach the station as (1) it is useless and (2) it takes time to compute (for instance if you are in New York…).

  • Disable view centering on the geolocation when at, say, more than Config.maxDistanceFromParis from Paris.
  • Disable direction computing when at more than Config.maxDistanceFromStation
  • Display a status message to explain the situation, like "Vous êtes actuellement loin de Paris. Géoposition désactivée."
@Phyks
Copy link
Member

Phyks commented Oct 4, 2015

👍

@Phyks
Copy link
Member

Phyks commented Oct 4, 2015

Implemented the first point, using Config.maxDistanceFromCity to be city agnostic.

Not sure to understand the point of the second point though.

Did not yet take care of the status message.

@eliemichel
Copy link
Member Author

Then you could have checked the corresponding box. ;)
The second point is that if I am at, say 50km from Paris, even if the view is centered on me, I don't want it to show me haw to walk to any station.

@Phyks
Copy link
Member

Phyks commented Oct 4, 2015

Oh, did not think I could actually check without editing your comment!

Indeed for the second point, but I do not want it to show me how to walk to any station. But once I selected a station, it seems ok to guide me to it, whatever the distance. If I am out of Paris, using the bikes or stands view is a nonsense. And the search view would show the roadmap only if I select a station and want some routes.

@eliemichel
Copy link
Member Author

Yeah but people might want to use those views anyway, just to know which station are the closest, maybe for fun or whatever. We cannot take the risk to have the application lag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants