Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuples in ecodes mappings #234

Open
sezanzeb opened this issue Feb 14, 2025 · 1 comment
Open

Tuples in ecodes mappings #234

sezanzeb opened this issue Feb 14, 2025 · 1 comment

Comments

@sezanzeb
Copy link
Collaborator

sezanzeb commented Feb 14, 2025

I just saw dfd45df, which is a breaking change for sezanzeb/input-remapper#1061. I'm not so sure I'd use a tuple for something that can be of arbitrary length (depending on evdev kernel stuff). And it might be a breaking change for other projects as well.

Are you sure this should be a tuple? @gvalkov

@gvalkov
Copy link
Owner

gvalkov commented Feb 15, 2025

Hi Tobi,

Sorry for that. Perhaps that release should have been a major release, but somehow I didn't think the change was major enough (for 2.0.0 it has to be something like proper handling of SYN_DROPPED ...). It's a minor optimization and it probably wasn't worth the trouble for the 16 bytes saved per list (i.e. 464 bytes total with the ecodes I'm running). Still, it makes sense to me that those values are tuples.

I saw that you already fixed the issue in your project. If I get more reports I'll consider reverting it.

Kind regards,
Georgi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants