Skip to content

Commit 18c82da

Browse files
author
Chris Moultrie
committed
0.4.0 Now redirecting properly
1 parent 1174e18 commit 18c82da

File tree

6 files changed

+28
-2
lines changed

6 files changed

+28
-2
lines changed

‎.npmignore

Whitespace-only changes.

‎README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,11 @@ Currently there is no explicit login call necessary as each API call uses Basic
7272

7373
* Refactor currently implemented APIs to be more Object Oriented
7474
* Refactor to make use of built-in node.js events and classes
75-
* Auto-redirect between `http` and `https` following headers
7675

7776
## Changelog ##
7877

7978

79+
* _0.4.0 Now auto-redirecting between http and https (for both GET and POST)_
8080
* _0.3.1 [Request](https://github.com/mikeal/request) is broken, setting max request package at 2.15.0_
8181
* _0.3.0 Now Gets Issues for a Rapidview/Sprint (thanks [donbonifacio](https://github.com/donbonifacio))_
8282
* _0.2.0 Now allowing startAt and MaxResults to be passed to searchJira,

‎docs/jira.html

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -407,6 +407,7 @@ <h3>Returns</h3>
407407
<span class="kd">var</span> <span class="nx">options</span> <span class="o">=</span> <span class="p">{</span>
408408
<span class="nx">uri</span><span class="o">:</span> <span class="k">this</span><span class="p">.</span><span class="nx">makeUri</span><span class="p">(</span><span class="s1">&#39;/sprint/&#39;</span> <span class="o">+</span> <span class="nx">sprintId</span> <span class="o">+</span> <span class="s1">&#39;/issues/add&#39;</span><span class="p">,</span> <span class="s1">&#39;rest/greenhopper/&#39;</span><span class="p">),</span>
409409
<span class="nx">method</span><span class="o">:</span> <span class="s1">&#39;PUT&#39;</span><span class="p">,</span>
410+
<span class="nx">followAllRedirects</span><span class="o">:</span> <span class="kc">true</span><span class="p">,</span>
410411
<span class="nx">json</span><span class="o">:</span><span class="kc">true</span><span class="p">,</span>
411412
<span class="nx">body</span><span class="o">:</span> <span class="p">{</span>
412413
<span class="nx">issueKeys</span><span class="o">:</span> <span class="p">[</span><span class="nx">issueId</span><span class="p">]</span>
@@ -466,6 +467,7 @@ <h3>Returns</h3>
466467
<span class="kd">var</span> <span class="nx">options</span> <span class="o">=</span> <span class="p">{</span>
467468
<span class="nx">uri</span><span class="o">:</span> <span class="k">this</span><span class="p">.</span><span class="nx">makeUri</span><span class="p">(</span><span class="s1">&#39;/issueLink&#39;</span><span class="p">),</span>
468469
<span class="nx">method</span><span class="o">:</span> <span class="s1">&#39;POST&#39;</span><span class="p">,</span>
470+
<span class="nx">followAllRedirects</span><span class="o">:</span> <span class="kc">true</span><span class="p">,</span>
469471
<span class="nx">json</span><span class="o">:</span> <span class="kc">true</span><span class="p">,</span>
470472
<span class="nx">body</span><span class="o">:</span> <span class="nx">link</span>
471473
<span class="p">};</span>
@@ -551,6 +553,7 @@ <h3>Returns</h3>
551553
<span class="kd">var</span> <span class="nx">options</span> <span class="o">=</span> <span class="p">{</span>
552554
<span class="nx">uri</span><span class="o">:</span> <span class="k">this</span><span class="p">.</span><span class="nx">makeUri</span><span class="p">(</span><span class="s1">&#39;/version&#39;</span><span class="p">),</span>
553555
<span class="nx">method</span><span class="o">:</span> <span class="s1">&#39;POST&#39;</span><span class="p">,</span>
556+
<span class="nx">followAllRedirects</span><span class="o">:</span> <span class="kc">true</span><span class="p">,</span>
554557
<span class="nx">json</span><span class="o">:</span> <span class="kc">true</span><span class="p">,</span>
555558
<span class="nx">body</span><span class="o">:</span> <span class="nx">version</span>
556559
<span class="p">};</span>
@@ -606,6 +609,7 @@ <h3>Returns</h3>
606609
<span class="nx">uri</span><span class="o">:</span> <span class="k">this</span><span class="p">.</span><span class="nx">makeUri</span><span class="p">(</span><span class="s1">&#39;/search&#39;</span><span class="p">),</span>
607610
<span class="nx">method</span><span class="o">:</span> <span class="s1">&#39;POST&#39;</span><span class="p">,</span>
608611
<span class="nx">json</span><span class="o">:</span> <span class="kc">true</span><span class="p">,</span>
612+
<span class="nx">followAllRedirects</span><span class="o">:</span> <span class="kc">true</span><span class="p">,</span>
609613
<span class="nx">body</span><span class="o">:</span> <span class="p">{</span>
610614
<span class="nx">jql</span><span class="o">:</span> <span class="nx">searchString</span><span class="p">,</span>
611615
<span class="nx">startAt</span><span class="o">:</span> <span class="nx">optional</span><span class="p">.</span><span class="nx">startAt</span> <span class="o">||</span> <span class="mi">0</span><span class="p">,</span>
@@ -670,6 +674,7 @@ <h3>Returns</h3>
670674
<span class="kd">var</span> <span class="nx">options</span> <span class="o">=</span> <span class="p">{</span>
671675
<span class="nx">uri</span><span class="o">:</span> <span class="k">this</span><span class="p">.</span><span class="nx">makeUri</span><span class="p">(</span><span class="s1">&#39;/issue&#39;</span><span class="p">),</span>
672676
<span class="nx">method</span><span class="o">:</span> <span class="s1">&#39;POST&#39;</span><span class="p">,</span>
677+
<span class="nx">followAllRedirects</span><span class="o">:</span> <span class="kc">true</span><span class="p">,</span>
673678
<span class="nx">json</span><span class="o">:</span> <span class="kc">true</span><span class="p">,</span>
674679
<span class="nx">body</span><span class="o">:</span> <span class="nx">issue</span>
675680
<span class="p">};</span>
@@ -707,6 +712,7 @@ <h3>Returns</h3>
707712
<span class="kd">var</span> <span class="nx">options</span> <span class="o">=</span> <span class="p">{</span>
708713
<span class="nx">uri</span><span class="o">:</span> <span class="k">this</span><span class="p">.</span><span class="nx">makeUri</span><span class="p">(</span><span class="s1">&#39;/issue/&#39;</span> <span class="o">+</span> <span class="nx">issueNum</span><span class="p">),</span>
709714
<span class="nx">method</span><span class="o">:</span> <span class="s1">&#39;DELETE&#39;</span><span class="p">,</span>
715+
<span class="nx">followAllRedirects</span><span class="o">:</span> <span class="kc">true</span><span class="p">,</span>
710716
<span class="nx">json</span><span class="o">:</span> <span class="kc">true</span>
711717
<span class="p">};</span>
712718

@@ -740,6 +746,7 @@ <h3>Returns</h3>
740746
<span class="nx">uri</span><span class="o">:</span> <span class="k">this</span><span class="p">.</span><span class="nx">makeUri</span><span class="p">(</span><span class="s1">&#39;/issue/&#39;</span> <span class="o">+</span> <span class="nx">issueNum</span><span class="p">),</span>
741747
<span class="nx">body</span><span class="o">:</span> <span class="nx">issueUpdate</span><span class="p">,</span>
742748
<span class="nx">method</span><span class="o">:</span> <span class="s1">&#39;PUT&#39;</span><span class="p">,</span>
749+
<span class="nx">followAllRedirects</span><span class="o">:</span> <span class="kc">true</span><span class="p">,</span>
743750
<span class="nx">json</span><span class="o">:</span> <span class="kc">true</span>
744751
<span class="p">};</span>
745752

@@ -844,6 +851,7 @@ <h3>Returns</h3>
844851
<span class="nx">uri</span><span class="o">:</span> <span class="k">this</span><span class="p">.</span><span class="nx">makeUri</span><span class="p">(</span><span class="s1">&#39;/issue/&#39;</span> <span class="o">+</span> <span class="nx">issueNum</span> <span class="o">+</span> <span class="s1">&#39;/transitions&#39;</span><span class="p">),</span>
845852
<span class="nx">body</span><span class="o">:</span> <span class="nx">issueTransition</span><span class="p">,</span>
846853
<span class="nx">method</span><span class="o">:</span> <span class="s1">&#39;POST&#39;</span><span class="p">,</span>
854+
<span class="nx">followAllRedirects</span><span class="o">:</span> <span class="kc">true</span><span class="p">,</span>
847855
<span class="nx">json</span><span class="o">:</span> <span class="kc">true</span>
848856
<span class="p">};</span>
849857

@@ -951,6 +959,7 @@ <h3>Returns</h3>
951959
<span class="nx">uri</span><span class="o">:</span> <span class="k">this</span><span class="p">.</span><span class="nx">makeUri</span><span class="p">(</span><span class="s1">&#39;/issue/&#39;</span> <span class="o">+</span> <span class="nx">issueId</span> <span class="o">+</span> <span class="s1">&#39;/worklog&#39;</span><span class="p">),</span>
952960
<span class="nx">body</span><span class="o">:</span> <span class="nx">worklog</span><span class="p">,</span>
953961
<span class="nx">method</span><span class="o">:</span> <span class="s1">&#39;POST&#39;</span><span class="p">,</span>
962+
<span class="nx">followAllRedirects</span><span class="o">:</span> <span class="kc">true</span><span class="p">,</span>
954963
<span class="nx">json</span><span class="o">:</span> <span class="kc">true</span>
955964
<span class="p">};</span>
956965

‎lib/jira.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,7 @@ var JiraApi = exports.JiraApi = function(protocol, host, port, username, passwor
389389
var options = {
390390
uri: this.makeUri('/sprint/' + sprintId + '/issues/add', 'rest/greenhopper/'),
391391
method: 'PUT',
392+
followAllRedirects: true,
392393
json:true,
393394
body: {
394395
issueKeys: [issueId]
@@ -445,6 +446,7 @@ var JiraApi = exports.JiraApi = function(protocol, host, port, username, passwor
445446
var options = {
446447
uri: this.makeUri('/issueLink'),
447448
method: 'POST',
449+
followAllRedirects: true,
448450
json: true,
449451
body: link
450452
};
@@ -526,6 +528,7 @@ var JiraApi = exports.JiraApi = function(protocol, host, port, username, passwor
526528
var options = {
527529
uri: this.makeUri('/version'),
528530
method: 'POST',
531+
followAllRedirects: true,
529532
json: true,
530533
body: version
531534
};
@@ -641,6 +644,7 @@ var JiraApi = exports.JiraApi = function(protocol, host, port, username, passwor
641644
var options = {
642645
uri: this.makeUri('/issue'),
643646
method: 'POST',
647+
followAllRedirects: true,
644648
json: true,
645649
body: issue
646650
};
@@ -674,6 +678,7 @@ var JiraApi = exports.JiraApi = function(protocol, host, port, username, passwor
674678
var options = {
675679
uri: this.makeUri('/issue/' + issueNum),
676680
method: 'DELETE',
681+
followAllRedirects: true,
677682
json: true
678683
};
679684

@@ -703,6 +708,7 @@ var JiraApi = exports.JiraApi = function(protocol, host, port, username, passwor
703708
uri: this.makeUri('/issue/' + issueNum),
704709
body: issueUpdate,
705710
method: 'PUT',
711+
followAllRedirects: true,
706712
json: true
707713
};
708714

@@ -799,6 +805,7 @@ var JiraApi = exports.JiraApi = function(protocol, host, port, username, passwor
799805
uri: this.makeUri('/issue/' + issueNum + '/transitions'),
800806
body: issueTransition,
801807
method: 'POST',
808+
followAllRedirects: true,
802809
json: true
803810
};
804811

@@ -897,6 +904,7 @@ var JiraApi = exports.JiraApi = function(protocol, host, port, username, passwor
897904
uri: this.makeUri('/issue/' + issueId + '/worklog'),
898905
body: worklog,
899906
method: 'POST',
907+
followAllRedirects: true,
900908
json: true
901909
};
902910

‎package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "jira",
3-
"version": "0.3.1",
3+
"version": "0.4.0",
44
"description": "Wrapper for the JIRA API",
55
"author": "Steven Surowiec <[email protected]>",
66
"contributors": [

‎spec/jira.spec.coffee

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ describe "Node Jira Tests", ->
138138
uri: makeUrl("sprint/1/issues/add", true)
139139
method: 'PUT'
140140
json: true
141+
followAllRedirects: true
141142
body:
142143
issueKeys: [2]
143144

@@ -158,6 +159,7 @@ describe "Node Jira Tests", ->
158159
method: 'POST'
159160
json: true
160161
body: 'test'
162+
followAllRedirects: true
161163

162164
@jira.issueLink 'test', @cb
163165
expect(@jira.request).toHaveBeenCalledWith options, jasmine.any(Function)
@@ -201,6 +203,7 @@ describe "Node Jira Tests", ->
201203
method: 'POST'
202204
json: true
203205
body: 'ABC'
206+
followAllRedirects: true
204207

205208
@jira.createVersion 'ABC', @cb
206209
expect(@jira.request).toHaveBeenCalledWith options, jasmine.any(Function)
@@ -230,6 +233,7 @@ describe "Node Jira Tests", ->
230233
uri: makeUrl "search"
231234
method: 'POST'
232235
json: true
236+
followAllRedirects: true
233237
body:
234238
jql: 'aJQLstring'
235239
startAt: 0
@@ -258,6 +262,7 @@ describe "Node Jira Tests", ->
258262
uri: makeUrl "search"
259263
method: 'POST'
260264
json: true
265+
followAllRedirects: true
261266
body:
262267
jql: 'aJQLstring'
263268
startAt: 200
@@ -301,6 +306,7 @@ describe "Node Jira Tests", ->
301306
uri: makeUrl "issue/1"
302307
method: 'DELETE'
303308
json: true
309+
followAllRedirects: true
304310

305311
@jira.deleteIssue 1, @cb
306312
expect(@jira.request).toHaveBeenCalledWith options, jasmine.any(Function)
@@ -318,6 +324,7 @@ describe "Node Jira Tests", ->
318324
body: 'updateGoesHere'
319325
method: 'PUT'
320326
json: true
327+
followAllRedirects: true
321328

322329
@jira.updateIssue 1, 'updateGoesHere', @cb
323330
expect(@jira.request).toHaveBeenCalledWith options, jasmine.any(Function)
@@ -354,6 +361,7 @@ describe "Node Jira Tests", ->
354361
uri: makeUrl "issue/1/transitions"
355362
body: 'someTransition'
356363
method: 'POST'
364+
followAllRedirects: true
357365
json: true
358366

359367
@jira.transitionIssue 1, 'someTransition', @cb
@@ -390,6 +398,7 @@ describe "Node Jira Tests", ->
390398
uri: makeUrl "issue/1/worklog"
391399
body: 'aWorklog'
392400
method: 'POST'
401+
followAllRedirects: true
393402
json: true
394403

395404
@jira.addWorklog 1, 'aWorklog', @cb

0 commit comments

Comments
 (0)