Breaking: Return wrapped task instead of original function, add unwrap method to wrapper, update tests

Author: phated

README.md

@@ -58,7 +58,8 @@ to create the registry for this instance.
 Both a `getter` and `setter` for tasks.
 
 If a string (`taskName`) is given as the only argument, it behaves as a `getter`
-and returns the registered function.
+and returns the wrapped task (not the original function). The wrapped task has a `unwrap`
+method that will return the original function.
 
 If a function (`fn`) and optionally a string (`taskName`) is given, it behaves as
 a `setter` and will register the task by the `taskName`.  If `taskName` is not

lib/get-task.js

@@ -1,21 +1,7 @@
 'use strict';
 
-var metadata = require('./helpers/metadata');
-
 function get(name) {
-  var wrapper = this._registry.get(name);
-
-  if (!wrapper) {
-    return;
-  }
-
-  var meta = metadata.get(wrapper);
-
-  if (meta) {
-    return meta.orig;
-  }
-
-  return wrapper;
+  return this._registry.get(name);
 }
 
 module.exports = get;

lib/last-run.js

@@ -2,6 +2,8 @@
 
 var retrieveLastRun = require('last-run');
 
+var metadata = require('./helpers/metadata');
+
 function lastRun(task, timeResolution) {
   if (timeResolution == null) {
     timeResolution = process.env.UNDERTAKER_TIME_RESOLUTION;
@@ -12,6 +14,12 @@ function lastRun(task, timeResolution) {
     fn = this._getTask(task);
   }
 
+  var meta = metadata.get(fn);
+
+  if (meta) {
+    fn = meta.orig || fn;
+  }
+
   return retrieveLastRun(fn, timeResolution);
 }
 

lib/set-task.js

@@ -13,6 +13,11 @@ function set(name, fn) {
     return fn.apply(this, arguments);
   }
 
+  function unwrap() {
+    return fn;
+  }
+
+  taskWrapper.unwrap = unwrap;
   taskWrapper.displayName = name;
 
   var meta = metadata.get(fn) || {};

test/task.js

@@ -25,20 +25,20 @@ describe('task', function() {
 
   it('should register a named function', function(done) {
     taker.task(noop);
-    expect(taker.task('noop')).to.equal(noop);
+    expect(taker.task('noop').unwrap()).to.equal(noop);
     done();
   });
 
   it('should register an anonymous function by string name', function(done) {
     taker.task('test1', anon);
-    expect(taker.task('test1')).to.equal(anon);
+    expect(taker.task('test1').unwrap()).to.equal(anon);
     done();
   });
 
   it('should register an anonymous function by displayName property', function(done) {
     anon.displayName = '<display name>';
     taker.task(anon);
-    expect(taker.task('<display name>')).to.equal(anon);
+    expect(taker.task('<display name>').unwrap()).to.equal(anon);
     delete anon.displayName;
     done();
   });
@@ -54,7 +54,7 @@ describe('task', function() {
 
   it('should register a named function by string name', function(done) {
     taker.task('test1', noop);
-    expect(taker.task('test1')).to.equal(noop);
+    expect(taker.task('test1').unwrap()).to.equal(noop);
     done();
   });
 
@@ -65,7 +65,22 @@ describe('task', function() {
 
   it('should get a task that was registered', function(done) {
     taker.task('test1', noop);
-    expect(taker.task('test1')).to.equal(noop);
+    expect(taker.task('test1').unwrap()).to.equal(noop);
+    done();
+  });
+
+  it('should get the wrapped task, not original function', function(done) {
+    var registry = taker.registry();
+    taker.task('test1', noop);
+    expect(taker.task('test1').unwrap).to.be.a.function();
+    expect(taker.task('test1')).to.equal(registry.get('test1'));
+    done();
+  });
+
+  it('provides an `unwrap` method to get the original function', function(done) {
+    taker.task('test1', noop);
+    expect(taker.task('test1').unwrap).to.be.a.function();
+    expect(taker.task('test1').unwrap()).to.equal(noop);
     done();
   });
 
@@ -79,15 +94,15 @@ describe('task', function() {
     function fn() {}
     fn.displayName = 'test1';
     taker.task(fn);
-    expect(taker.task('test1')).to.equal(fn);
+    expect(taker.task('test1').unwrap()).to.equal(fn);
     done();
   });
 
   it('should allow different tasks to refer to the same function', function(done) {
     function fn() {}
     taker.task('foo', fn);
     taker.task('bar', fn);
-    expect(taker.task('foo' )).to.equal(taker.task('bar'));
+    expect(taker.task('foo').unwrap()).to.equal(taker.task('bar').unwrap());
     done();
   });