Skip to content

Commit 1ee58b1

Browse files
coreyfarrellphated
authored andcommitted
Fix: Avoid setting displayName on series/parallel functions (ref gulpjs/gulp#2270) (#91)
1 parent f94fd87 commit 1ee58b1

File tree

4 files changed

+17
-8
lines changed

4 files changed

+17
-8
lines changed

lib/parallel.js

+3-4
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,13 @@ function parallel() {
1313
var args = normalizeArgs(this._registry, arguments);
1414
var extensions = createExtensions(this);
1515
var fn = create(args, extensions);
16-
17-
fn.displayName = '<parallel>';
16+
var name = '<parallel>';
1817

1918
metadata.set(fn, {
20-
name: fn.displayName,
19+
name: name,
2120
branch: true,
2221
tree: {
23-
label: fn.displayName,
22+
label: name,
2423
type: 'function',
2524
branch: true,
2625
nodes: buildTree(args),

lib/series.js

+3-4
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,13 @@ function series() {
1313
var args = normalizeArgs(this._registry, arguments);
1414
var extensions = createExtensions(this);
1515
var fn = create(args, extensions);
16-
17-
fn.displayName = '<series>';
16+
var name = '<series>';
1817

1918
metadata.set(fn, {
20-
name: fn.displayName,
19+
name: name,
2120
branch: true,
2221
tree: {
23-
label: fn.displayName,
22+
label: name,
2423
type: 'function',
2524
branch: true,
2625
nodes: buildTree(args),

test/parallel.js

+6
Original file line numberDiff line numberDiff line change
@@ -146,4 +146,10 @@ describe('parallel', function() {
146146
done();
147147
});
148148
});
149+
150+
it('should not register a displayName on the returned function by default', function(done) {
151+
var task = taker.parallel(fn1);
152+
expect(task.displayName).toEqual(undefined);
153+
done();
154+
});
149155
});

test/series.js

+5
Original file line numberDiff line numberDiff line change
@@ -147,4 +147,9 @@ describe('series', function() {
147147
});
148148
});
149149

150+
it('should not register a displayName on the returned function by default', function(done) {
151+
var task = taker.series(fn1);
152+
expect(task.displayName).toEqual(undefined);
153+
done();
154+
});
150155
});

0 commit comments

Comments
 (0)