Remove obsolete TODO comments

simo5 · simo5 · commit eb4cf16f5f0c · 2020-06-19T20:48:13.000Z
Signed-off-by: Simo Sorce &lt;simo@redhat.com&gt;
diff --git a/src/gss_ntlmssp.h b/src/gss_ntlmssp.h
@@ -137,8 +137,6 @@ struct gssntlm_ctx {
     /* negotiated flags */
     uint32_t neg_flags;
 
-    /* TODO: Add whitelist of servers we are allowed to communicate with */
-
     struct ntlm_key exported_session_key;
     struct ntlm_signseal_state crypto_state;
 
diff --git a/src/gss_sec_ctx.c b/src/gss_sec_ctx.c
@@ -697,8 +697,6 @@ uint32_t gssntlm_accept_sec_context(uint32_t *minor_status,
                               NTLMSSP_NEGOTIATE_KEY_EXCH;
         }
 
-        /* TODO: Support MS-NLMP ServerBlock ? */
-
         /* TODO: Check some minimum required flags ? */
         /* TODO: Check MS-NLMP ServerRequire128bitEncryption */
 
diff --git a/src/ntlm.c b/src/ntlm.c
@@ -1000,7 +1000,6 @@ int ntlm_decode_neg_msg(struct ntlm_ctx *ctx,
     return ret;
 }
 
-/* TODO: support datagram style */
 int ntlm_encode_chal_msg(struct ntlm_ctx *ctx,
                          uint32_t flags,
                          const char *target_name,
diff --git a/tests/ntlmssptest.c b/tests/ntlmssptest.c
@@ -2003,8 +2003,6 @@ int test_gssapi_cl(void)
         goto done;
     }
 
-    /* TODO: again with channel bindings */
-
     gss_release_buffer(&retmin, &cli_token);
     gss_release_buffer(&retmin, &srv_token);
 

Original file line number	Diff line number	Diff line change
`@@ -697,8 +697,6 @@ uint32_t gssntlm_accept_sec_context(uint32_t *minor_status,`
`697`	`697`	`NTLMSSP_NEGOTIATE_KEY_EXCH;`
`698`	`698`	`}`
`699`	`699`
`700`		`- /* TODO: Support MS-NLMP ServerBlock ? */`
`701`		`-`
`702`	`700`	`/* TODO: Check some minimum required flags ? */`
`703`	`701`	`/* TODO: Check MS-NLMP ServerRequire128bitEncryption */`
`704`	`702`
Original file line number	Diff line number	Diff line change
`@@ -1000,7 +1000,6 @@ int ntlm_decode_neg_msg(struct ntlm_ctx *ctx,`
`1000`	`1000`	`return ret;`
`1001`	`1001`	`}`
`1002`	`1002`
`1003`		`-/* TODO: support datagram style */`
`1004`	`1003`	`int ntlm_encode_chal_msg(struct ntlm_ctx *ctx,`
`1005`	`1004`	`uint32_t flags,`
`1006`	`1005`	`const char *target_name,`
Original file line number	Diff line number	Diff line change
`@@ -2003,8 +2003,6 @@ int test_gssapi_cl(void)`
`2003`	`2003`	`goto done;`
`2004`	`2004`	`}`
`2005`	`2005`
`2006`		`- /* TODO: again with channel bindings */`
`2007`		`-`
`2008`	`2006`	`gss_release_buffer(&retmin, &cli_token);`
`2009`	`2007`	`gss_release_buffer(&retmin, &srv_token);`
`2010`	`2008`