Added tests for http service

Author: gsinghsfdc

demo_03/bank_test.go

@@ -2,6 +2,10 @@ package main
 
 import (
 	"errors"
+	"fmt"
+	"io/ioutil"
+	"net/http"
+	"net/http/httptest"
 	"testing"
 )
 
@@ -20,9 +24,45 @@ func (tms TransactionReaderStub) ReadBalance(account int) (int, error) {
 }
 
 func TestBalanceEndpoint(t *testing.T) {
+	req := httptest.NewRequest(http.MethodGet, "localhost:8080/balance?account=12", nil)
+	rec := httptest.NewRecorder()
 
+	balanceHandler(rec, req)
+
+	result := rec.Result()
+	defer result.Body.Close()
+
+	if result.StatusCode != http.StatusOK {
+		t.Fatalf("Expected status 200, got %v", result.StatusCode)
+	}
+
+	body, err := ioutil.ReadAll(result.Body)
+	if err != nil {
+		t.Fatalf("Error reading body")
+	}
+
+	// silly comparison, ideally the body will be parsed, this is just for demonstration purposes
+	if strBody := string(body); strBody != "10\n" {
+		t.Fatalf("expected 10, got %s", strBody)
+	}
 }
 
 func TestBalanceEndpointWithTestServer(t *testing.T) {
+	server := httptest.NewServer(handler())
+	defer server.Close()
+
+	res, err := http.Get(fmt.Sprintf("%s/balance?account=12", server.URL))
+	if err != nil {
+		t.Fatalf("an error occured making request to balance endpoint, err: %v", err)
+	}
 
+	body, err := ioutil.ReadAll(res.Body)
+	if err != nil {
+		t.Fatalf("Error reading body")
+	}
+
+	// silly comparison, ideally the body will be parsed, this is just for demonstration purposes
+	if strBody := string(body); strBody != "10\n" {
+		t.Fatalf("expected 10, got %s", strBody)
+	}
 }

demo_04/bank.go

@@ -55,12 +55,12 @@ func (ca ChequingAccount) Balance(tr TransactionReader) (int, error) {
 	return balance, nil
 }
 
-func (ca ChequingAccount) BalanceCAD(url string, tr TransactionReader) (int, error) {
+func (ca ChequingAccount) BalanceCAD(baseURL string, tr TransactionReader) (int, error) {
 	balance, _ := ca.Balance(tr)
-	if url == "" {
-		url = "https://api.exchangerate-api.com/v4/latest/usd"
+	if baseURL == "" {
+		baseURL = "https://api.exchangerate-api.com/v4"
 	}
-	res, err := http.Get(url)
+	res, err := http.Get(baseURL + "/latest/usd")
 	if err != nil {
 		return 0, err
 	}