-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle Show memes in system gallery #55
Comments
If you need more information ask. This issue is an idea, and about people to start contributing to the project. It has not much information because I pasted many ideas/issues and just let them out at the same time :). If you are interested in working on this, and have questions I can give you more details on this. Register on https://hacktoberfest.digitalocean.com/, send a PR to fix this and get your t-shirt for free (4 accepted PRs to same or different GitHub repositories needed) :). You have to mention the issue number in the commit/PR (e.g. fix #20 / about #8) Find more hacktober issues from my projects: https://github.com/search?&q=label%3Ahacktoberfest+user%3Agsantner |
Hi, I am interesting in working on this issue. I would like to clarify: Do you mean a toggle in settings is required, and this toggle toggles the visibility of the created memes in the system gallery, while showing them as normal within the application? |
Yes, the visibility of images inside MemeTastic is not affected in any means by this. This should really only control the visibility on normal android gallery apps |
Okay, thanks. I'll work on it. |
Hi @gsantner, please take a look at the pull request I've made, thank you. |
the PR doesnt contain any calls to update/add/delete index entries there. Your way the gallery will do a rescan at an ranfom time. |
I have created another pull request that rectifies this issue. |
Add setting to show/hide pictures in device gallery, fixes #55
Add setting to show/hide pictures in device gallery, fixes #55
Resolving this should toggle the visiblity of memes in the android system galleries (MediaScanner). For this you have to add (on creation), delete (on deletion) the meme from the system media database.
Additionally there should be an toggle provided in the Settings (
SettingsActivity, preferences.xml
) that in general toggles (enables/disables) this. Enabling means the deletion of%SAVEPATH%/memes/.nomedia
and the addition of all current and future files in there. Deletion means creation of nomedia file and the removal of all items from the system media database.Attention: This is ONLY about the media database. You must not delete any pictures here.
The text was updated successfully, but these errors were encountered: