Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Commit 2ccde03

Browse files
committed
Merge pull request #37 from groupon/jk-warn-only
Warn only for non-critical errors
2 parents 7bc6c87 + ac8cf24 commit 2ccde03

File tree

2 files changed

+37
-1
lines changed

2 files changed

+37
-1
lines changed

lib/parse_response.js

Lines changed: 22 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/parse_response.coffee

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
3030
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
3131
###
3232

33+
{omit} = require 'lodash'
34+
debug = require('debug')('webdriver-http-sync:parse_response')
35+
3336
json = require './json'
3437

3538
cleanResponse = (response) ->
@@ -50,9 +53,21 @@ createDetailError = (message) ->
5053

5154
new Error message
5255

56+
logWarning = (message) ->
57+
if message[0] == '{'
58+
details = json.tryParse message
59+
if typeof details?.errorMessage == 'string'
60+
debug details.errorMessage, omit(details, 'errorMessage')
61+
else
62+
debug details
63+
else
64+
debug message
65+
5366
validateResponse = (response) ->
5467
return unless response.message?
5568

69+
return logWarning(response.message) unless response.stackTrace?
70+
5671
friendlyError = createDetailError response.message
5772
friendlyError.inner = response
5873
throw friendlyError

0 commit comments

Comments
 (0)