refactor: fixing lint issues

Author: HabibMAALEM

.golangci.yml

@@ -4,8 +4,7 @@ run:
 linters:
   enable-all: true
   disable:
-    - wsl
-    - lll
+    - exhaustive
     - funlen
     - gci
     - gochecknoglobals
@@ -19,9 +18,10 @@ linters:
     - goimports
     - gomnd
     - gosec
+    - lll
     - maligned
     - nestif
     - nlreturn
     - noctx
     - scopelint
-    - stylecheck
+    - wsl

internal/core/handler.go

@@ -13,6 +13,7 @@ import (
 	"github.com/groupe-edf/watchdog/internal/logging"
 )
 
+// HandlerType handler type
 type HandlerType string
 
 const (

internal/hook/condition.go

@@ -16,7 +16,7 @@ const (
 	ConditionLength ConditionType = "length"
 	// ConditionPattern pattern condition
 	ConditionPattern ConditionType = "pattern"
-	// ConditionPattern protected condition
+	// ConditionProtected protected condition
 	ConditionProtected ConditionType = "protected"
 	// ConditionSecret secret condition
 	ConditionSecret ConditionType = "secret"

internal/hook/hook.go

@@ -25,7 +25,7 @@ func (gitHooks *GitHooks) Validate() error {
 		return err
 	}
 	if !gitHooksVersion.LessThan(*watchDogVersion) && !gitHooksVersion.Equal(*watchDogVersion) {
-		return fmt.Errorf("Unsupported .githooks.yml version %s by watchdog v%s", gitHooksVersion.String(), version.Version)
+		return fmt.Errorf("unsupported .githooks.yml version %s by watchdog v%s", gitHooksVersion.String(), version.Version)
 	}
 	return nil
 }

internal/hook/hook_file.go

@@ -15,7 +15,7 @@ var (
 	// ConfigFilename Git hooks configuration filename to be parsed
 	ConfigFilename = ".githooks.yml"
 	// ErrFileNotFound File not found error
-	ErrFileNotFound = errors.New("Configuration file .githooks.(yaml|yml) not found")
+	ErrFileNotFound = errors.New("configuration file .githooks.(yaml|yml) not found")
 )
 
 // LoadGitHooks load and return Configuration struct
@@ -44,7 +44,7 @@ func ExtractConfigFile(ctx context.Context, commit *object.Commit) (gitHooks *Gi
 func LoadGitHooksFromRaw(fileContent string) (*GitHooks, error) {
 	var hooks = &GitHooks{}
 	if err := yaml.Unmarshal([]byte(fileContent), hooks); err != nil {
-		return nil, fmt.Errorf("Unable to decode into struct, %v", err)
+		return nil, fmt.Errorf("unable to decode into struct, %v", err)
 	}
 	if err := hooks.Validate(); err != nil {
 		return nil, err

internal/hook/hook_info.go

@@ -31,7 +31,8 @@ const (
 
 var (
 	// ErrNoHookData no hook data error
-	ErrNoHookData      = errors.New("Hook data is mandatory")
+	ErrNoHookData = errors.New("Hook data is mandatory")
+	// ErrInvalidHookData invalid hook input
 	ErrInvalidHookData = errors.New("invalid hook input")
 	// HookTypes that are supported by Watchdog
 	HookTypes = [...]string{
@@ -94,12 +95,11 @@ func (info *Info) ParseHookInput(input io.Reader) error {
 		}
 		info.NewRev = commit
 	}
-	info.parseHookAction()
 	return nil
 }
 
-// ParseHookAction return hook action
-func (info *Info) parseHookAction() {
+// GetAction return hook action
+func (info *Info) GetAction() string {
 	action := "push"
 	context := "branch"
 	if info.Ref.IsTag() {
@@ -110,9 +110,10 @@ func (info *Info) parseHookAction() {
 	} else if info.OldRev != nil && info.NewRev == nil {
 		action = "delete"
 	}
-	info.Action = fmt.Sprintf("%s.%s", context, action)
+	return fmt.Sprintf("%s.%s", context, action)
 }
 
+// ParseInfo parse info for the current working directory
 func ParseInfo(repository *git.Repository) (*Info, error) {
 	directory, err := os.Getwd()
 	if err != nil {

internal/hook/hook_test.go

@@ -25,5 +25,5 @@ func TestParseHookAction(t *testing.T) {
 	info := Info{
 		Ref: plumbing.ReferenceName("refs/heads/master"),
 	}
-	assert.Equal(info.Action, "branch.push")
+	assert.Equal("branch.push", info.GetAction())
 }

internal/output/formatter.go

@@ -48,7 +48,7 @@ func NewReport(writer io.Writer, options *config.Options, set *util.Set) (err er
 			ErrorMessagePrefix: options.ErrorMessagePrefix,
 		})
 	default:
-		return errors.New("Unsupported output format")
+		return errors.New("unsupported output format")
 	}
 }
 

test/data/config.yml

@@ -3,7 +3,7 @@ docs_link: https://groupe-edf.github.io/watchdog/docs/
 error_message_prefix: "GL-HOOK-ERR: "
 logs_level: info
 logs_format: json
-logs_path: /var/log/watchdog/watchdog.log
+logs_path: watchdog.log
 concurrent: 4
 output_format: text
 security: