Merge pull request #32 from groundlight/credentials-refactor-fix

updated workflows to fix issues exposed by credentials-refactor merge

Author: positavi

.github/workflows/make_binaries.yaml

@@ -2,8 +2,6 @@ name: PlatformIO CI
 
 on:
   push:
-    branches:
-      - main
 
 jobs:
   build:
@@ -23,9 +21,19 @@ jobs:
       - name: Install PlatformIO Core
         run: pip install --upgrade platformio
 
+      - name: Create credentials.h for build 
+        run: cp src/credentials_template.h src/credentials.h
+
       - name: Build PlatformIO Project
         run: pio run
 
+
+  deploy_release:
+    if: github.ref == 'refs/heads/main'
+    runs-on: ubuntu-latest
+    needs: build
+    steps:
+
       - name: Copy binaries to /firmware
         run: bash copy_firmware.sh
 

src/credentials_template.h

@@ -4,7 +4,7 @@
 /*  template file for preloading credentials instead of reading from the file system 
  *  only applicable for [env:demo-unit-preloaded]
  *
- *  to use this file, copy this template to "credentials.h" and fill in the applicable values.  
+ *  to use this file, copy this template to "credentials.h" and uncomment/fill in the applicable values.  
  *  the list below is non-exhaustive and additional options can be added as needed.
  *  this will override anything in the file system on every startup.
 */
@@ -13,17 +13,20 @@
 void set_preferences(Preferences preferences);
 
 void set_preferences(Preferences preferences) {
-    // A non-exhaustive list of preferences for the ESP32
+    
     preferences.begin("config");
-    preferences.putString("ssid", "");
-    preferences.putString("password", "");
-    preferences.putString("det_id", "");
-    preferences.putString("api_key", "");
-    preferences.putInt("query_delay", 600);
+    
+    // A non-exhaustive list of preferences for the ESP32
+    // preferences.putString("ssid", "");
+    // preferences.putString("password", "");
+    // preferences.putString("det_id", "");
+    // preferences.putString("api_key", "");
+    // preferences.putInt("query_delay", 600);
     // preferences.putString("email", "");
     // preferences.putString("emailEndpoint", "");
     // preferences.putString("emailKey", "");
     // preferences.putString("emailHost", "");
+    
     preferences.end();
 }