Skip to content

Commit a9506ba

Browse files
committed
Revert "grml-live: clean up MIRROR_DIRECTORY if provided."
This reverts commit c78f58b. While deleting the bind-mount destination of mirror directories is fine in theory, we end up deleting empty base directories as well, which is unexpected and unwanted behavior. See #104 for the related discussion, this issue needs further attention yet before we can include this in a new release of grml-live.
1 parent 79d0a1c commit a9506ba

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

Diff for: grml-live

+1-4
Original file line numberDiff line numberDiff line change
@@ -180,10 +180,7 @@ umount_all() {
180180
fi
181181

182182
umount "${CHROOT_OUTPUT}/grml-live/sources/" 2>/dev/null || /bin/true
183-
if [ -n "${MIRROR_DIRECTORY}" ]; then
184-
umount "${CHROOT_OUTPUT}/${MIRROR_DIRECTORY}"
185-
rmdir -p "${CHROOT_OUTPUT}/${MIRROR_DIRECTORY}"
186-
fi
183+
[ -n "$MIRROR_DIRECTORY" ] && umount "${CHROOT_OUTPUT}/${MIRROR_DIRECTORY}"
187184
}
188185
# }}}
189186

0 commit comments

Comments
 (0)