Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to disconnect #2

Open
oopswg opened this issue Apr 9, 2020 · 4 comments
Open

No way to disconnect #2

oopswg opened this issue Apr 9, 2020 · 4 comments

Comments

@oopswg
Copy link

oopswg commented Apr 9, 2020

I am able to install it. But it is not able to disconnect.
I have dug into it and found that the problem is due to the ExpressVPN client has some ASCII colour character before the "Connected to...." in the output string of checking connection status.

@grjw
Copy link
Owner

grjw commented Apr 9, 2020

Thanks for the feedback!

I'm very busy at the moment but i'll try and look at this sometime soon.

@oopswg
Copy link
Author

oopswg commented Apr 10, 2020

I have fixed this to be honest... but figuring out on how to pass my fix to you as I am a new github user...

@grjw
Copy link
Owner

grjw commented Apr 10, 2020

If you look at the Github help pages for creating a pull request, I can merge your fix in to mine.

https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

@oopswg
Copy link
Author

oopswg commented Apr 11, 2020

Done. However, since the resources/lib directory is missing from your master branch. Git think it is a new file and it is not able to indicate you the correct location of the code which I have modified. I have added more description on it in my pull request. Hope it help. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants