Skip to content

Commit bec56a9

Browse files
committed
TS: tweaks to 'removed' callback
*make sure we remove drag&drop handler * reset el.gridstackNode before callback to let callee know it's going away. * Only remove if not already done.
1 parent 509fe24 commit bec56a9

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

src/gridstack.ts

+5-2
Original file line numberDiff line numberDiff line change
@@ -1348,9 +1348,12 @@ export class GridStack {
13481348
gridToNotify._gsEventHandler[event.type](event, target);
13491349
}
13501350
gridToNotify.engine.removedNodes.push(node);
1351+
gridToNotify.dd.draggable(el, 'destroy').resizable(el, 'destroy');
1352+
delete el.gridstackNode; // hint we're removing it next and break circular link
13511353
gridToNotify._triggerRemoveEvent();
1352-
delete el.gridstackNode;
1353-
el.remove();
1354+
if (el.parentElement) {
1355+
el.remove(); // finally remove it
1356+
}
13541357
} else {
13551358
this._clearRemovingTimeout(el);
13561359
if (!node._temporaryRemoved) {

0 commit comments

Comments
 (0)