Skip to content

Commit 9042f39

Browse files
jamescowensjamescowens
committed
5.4.9.0, 2025-02-16, leisure
Added - depends: add cross arm64-darwin support #2775 (@div72) - build: add missing randomness checks #2772 (@div72) - init, registry: Support -clearallregistryhistory startup parameter #2773 (@jamescowens) Changed - build: omit _FORTIFY_SOURCE on debug #2793 (@div72) - doc: cmake is required for Windows depends #2791 (@barton2526) - CMake: Set maximum supported Boost version #2788 (@CyberTailor) - ci: bump to MacOS 13 #2784 (@div72) - build/cmake: disable LevelDB tests #2776 (@div72) - util: use XDG_STATE_HOME for datadir on Flatpak #2774 (@div72) - util, build: Support miniupnp API version 18+ #2771 (@jamescowens) - build: explicitly include FindPkgConfig for CMake #2769 (@jamescowens) - ci, cd: bump action versions #2763 (@div72) - Sync CMake CI #2762 (@CyberTailor) - cpid: Modify CPID local hasher to eliminate compiler warnings on 32 bit archs #2760 (@jamescowens) Removed - refactor, misc: remove CBitcoin(Address|Secret) #2634 (@div72) Fixed - poll, gui: Disable choice add button in poll wizard when choice limit is reached #2792 (@jamescowens) - diagnose, rpc: fix compilation with boost 1.87 #2786 (@div72) - node: fix build with GCC 15 #2783 (@CyberTailor) - ci: use overwrite with brew install on MacOS CMake #2782 (@div72) - scraper: Protect access to ConvergedStats.csv.gz with a lock #2779 (@jamescowens) - fix build on FreeBSD #2770 (@wilkart) - rpc/server: fix removing deprecated commands from command list #2768 (@lrusak) - cmake bdb53: disable error for implicit-int with gcc #2767 (@lrusak)
2 parents 70635bb + 070d9b0 commit 9042f39

File tree

143 files changed

+5226
-4244
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

143 files changed

+5226
-4244
lines changed

‎.github/workflows/cd.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,18 @@ jobs:
1111
strategy:
1212
fail-fast: false
1313
matrix:
14-
script-id: [win32, win64, mac]
14+
script-id: [win32, win64, mac, mac_arm64_cross]
1515
env:
1616
FILE_ENV: ./cd/00_setup_env_${{ matrix.script-id }}.sh
1717
OS_NAME: linux
1818
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
1919
steps:
2020
- name: checkout
21-
uses: actions/checkout@v3
21+
uses: actions/checkout@v4
2222
- name: current time for cache
2323
run: echo "TIMESTAMP=$(date +%s)" >> $GITHUB_ENV
2424
- name: cache
25-
uses: actions/cache@v3
25+
uses: actions/cache@v4
2626
with:
2727
path: |
2828
./depends/built

‎.github/workflows/ci.yml

+14-12
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ env:
77
jobs:
88
test-linux:
99
name: ${{ matrix.name }}
10-
runs-on: ubuntu-20.04
10+
runs-on: ubuntu-24.04
1111
strategy:
1212
matrix:
1313
include:
14-
- name: ARM [GOAL install] [buster]
14+
- name: ARM [GOAL install] [bullseye]
1515
script-id: arm
1616
- name: Win32
1717
script-id: win32
@@ -21,25 +21,27 @@ jobs:
2121
script-id: linux_i386
2222
- name: x86_64 Linux [GOAL install] [GUI] [focal] [no depends]
2323
script-id: native
24-
- name: x86_64 Linux [GOAL install] [GUI] [bionic] [no depends]
24+
- name: x86_64 Linux [GOAL install] [GUI] [noble] [no depends]
2525
script-id: native_old
2626
- name: x86_64 Linux [ASan] [LSan] [UBSan] [integer] [jammy] [no depends]
2727
script-id: native_asan
2828
# FIXME: depends is unable to compile Qt with clang.
2929
# - name: x86_64 Linux [TSan] [GUI] [jammy]
3030
# script-id: native_tsan
31-
- name: macOS 10.14 [GOAL deploy] [GUI] [no tests] [focal]
31+
- name: macOS 10.14 [GOAL deploy] [GUI] [no tests] [noble]
3232
script-id: mac
33+
- name: arm64 macOS 10.14 [GOAL deploy] [GUI] [no tests] [noble]
34+
script-id: mac_arm64_cross
3335
env:
3436
FILE_ENV: ./ci/test/00_setup_env_${{ matrix.script-id }}.sh
3537
OS_NAME: linux
3638
steps:
3739
- name: checkout
38-
uses: actions/checkout@v3
40+
uses: actions/checkout@v4
3941
- name: current time for cache
4042
run: echo "TIMESTAMP=$(date +%s)" >> $GITHUB_ENV
4143
- name: cache
42-
uses: actions/cache@v3
44+
uses: actions/cache@v4
4345
with:
4446
path: |
4547
./depends/built
@@ -51,20 +53,20 @@ jobs:
5153
run: |
5254
./ci/test_run_all.sh
5355
test-macos:
54-
name: macOS 12 native [GOAL install] [GUI] [no depends]
55-
runs-on: macos-12
56+
name: macOS 13 native [GOAL install] [GUI] [no depends]
57+
runs-on: macos-13
5658
env:
5759
DANGER_RUN_CI_ON_HOST: true
5860
CI_USE_APT_INSTALL: no
5961
FILE_ENV: ./ci/test/00_setup_env_mac_host.sh
6062
OS_NAME: macos
6163
steps:
6264
- name: checkout
63-
uses: actions/checkout@v3
65+
uses: actions/checkout@v4
6466
- name: current time for cache
6567
run: echo "TIMESTAMP=$(date +%s)" >> $GITHUB_ENV
6668
- name: cache
67-
uses: actions/cache@v3
69+
uses: actions/cache@v4
6870
with:
6971
path: |
7072
./ci/scratch/.ccache
@@ -82,9 +84,9 @@ jobs:
8284
runs-on: ubuntu-22.04
8385
steps:
8486
- name: checkout
85-
uses: actions/checkout@v3
87+
uses: actions/checkout@v4
8688
- name: setup-python
87-
uses: actions/setup-python@v4
89+
uses: actions/setup-python@v5
8890
with:
8991
python-version: 3.11
9092
- name: lint

‎.github/workflows/cmake-ci.yml

+67-69
Original file line numberDiff line numberDiff line change
@@ -47,60 +47,59 @@ jobs:
4747
-DSYSTEM_UNIVALUE=ON
4848
steps:
4949
- name: Checkout
50-
uses: actions/checkout@v3
50+
uses: actions/checkout@v4
5151
- name: Install dependencies
52-
uses: awalsh128/cache-apt-pkgs-action@latest
52+
uses: awalsh128/cache-apt-pkgs-action@v1
5353
with:
54-
packages: |
54+
packages: >-
5555
${{matrix.deps}}
5656
ccache
57+
cmake
5758
libcurl4-openssl-dev
59+
libssl-dev
5860
libzip-dev
5961
ninja-build
62+
pkgconf
6063
zipcmp
6164
zipmerge
6265
ziptool
6366
version: ${{matrix.tag}}
6467
- name: Install Boost dependencies
65-
run: |
66-
sudo apt-get install -y --no-install-recommends \
67-
libboost-dev \
68-
libboost-date-time-dev \
69-
libboost-exception-dev \
70-
libboost-filesystem-dev \
71-
libboost-iostreams-dev \
72-
libboost-serialization-dev \
73-
libboost-test-dev \
74-
libboost-thread-dev
68+
run: sudo apt-get install -y --no-install-recommends
69+
libboost-dev
70+
libboost-date-time-dev
71+
libboost-exception-dev
72+
libboost-filesystem-dev
73+
libboost-iostreams-dev
74+
libboost-serialization-dev
75+
libboost-test-dev
76+
libboost-thread-dev
7577
- name: Configure
76-
run: |
77-
cmake -B ${{github.workspace}}/build -G Ninja \
78-
-DCMAKE_C_COMPILER_LAUNCHER=ccache \
79-
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
80-
${{matrix.options}} \
81-
-DENABLE_TESTS=ON
78+
run: cmake
79+
-B ${{github.workspace}}/build -G Ninja
80+
-DCMAKE_C_COMPILER_LAUNCHER=ccache
81+
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache
82+
${{matrix.options}}
83+
-DENABLE_TESTS=ON
8284
- name: Restore cache
83-
uses: actions/cache/restore@v3
85+
uses: actions/cache/restore@v4
8486
if: always()
8587
with:
8688
path: ${{env.CCACHE_DIR}}
8789
key: ccache-linux-${{matrix.tag}}-${{github.run_id}}
88-
restore-keys: |
89-
ccache-linux-${{matrix.tag}}-
90+
restore-keys: ccache-linux-${{matrix.tag}}-
9091
- name: Build
91-
run: |
92-
cmake --build ${{github.workspace}}/build -v -j $(nproc)
92+
run: cmake --build ${{github.workspace}}/build -v -j $(nproc)
9393
- name: Save cache
94-
uses: actions/cache/save@v3
94+
uses: actions/cache/save@v4
9595
if: always()
9696
with:
9797
path: ${{env.CCACHE_DIR}}
9898
key: ccache-linux-${{matrix.tag}}-${{github.run_id}}
9999
- name: Run tests
100-
run: |
101-
ctest --test-dir ${{github.workspace}}/build -j $(nproc)
100+
run: ctest --test-dir ${{github.workspace}}/build -j $(nproc)
102101
- name: Upload test logs
103-
uses: actions/upload-artifact@v3
102+
uses: actions/upload-artifact@v4
104103
if: always()
105104
with:
106105
name: testlog-linux-${{matrix.tag}}
@@ -131,7 +130,7 @@ jobs:
131130
qt@5
132131
options: >-
133132
-DENABLE_GUI=ON
134-
-DQt5_DIR=/usr/local/opt/qt@5/lib/cmake/Qt5
133+
-DQt5_DIR=$(brew --prefix qt@5)/lib/cmake/Qt5
135134
-DENABLE_QRENCODE=ON
136135
-DENABLE_UPNP=ON
137136
- tag: system-libs
@@ -141,52 +140,54 @@ jobs:
141140
vim
142141
options: >-
143142
-DSYSTEM_BDB=ON
144-
-DBerkeleyDB_INCLUDE_DIR=/usr/local/opt/berkeley-db@5/include
145-
-DBerkeleyDB_CXX_LIBRARY=/usr/local/opt/berkeley-db@5/lib/libdb_cxx.dylib
143+
-DBerkeleyDB_INCLUDE_DIR=$(brew --prefix berkeley-db@5)/include
144+
-DBerkeleyDB_CXX_LIBRARY=$(brew --prefix berkeley-db@5)/lib/libdb_cxx.dylib
146145
-DSYSTEM_SECP256K1=ON
147146
-DSYSTEM_XXD=ON
148147
steps:
149148
- name: Checkout
150-
uses: actions/checkout@v3
149+
uses: actions/checkout@v4
151150
- name: Install dependencies
151+
run: brew install --overwrite
152+
${{matrix.deps}}
153+
boost
154+
ccache
155+
libzip
156+
ninja
157+
openssl@3
158+
perl
159+
pkg-config
160+
- name: Prepare source
152161
run: |
153-
brew install boost ccache ninja ${{matrix.deps}}
154-
- name: Configure
155-
run: |
156-
PKG_CONFIG_PATH="/usr/local/opt/openssl@3/lib/pkgconfig:${PKG_CONFIG_PATH}"
157-
export PKG_CONFIG_PATH
158-
159162
pushd src
160163
../contrib/nomacro.pl
161164
popd
162-
163-
cmake -B ${{github.workspace}}/build -G Ninja \
164-
-DCMAKE_C_COMPILER_LAUNCHER=ccache \
165-
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
166-
${{matrix.options}} \
167-
-DENABLE_TESTS=ON
165+
- name: Configure
166+
run: cmake
167+
-B ${{github.workspace}}/build -G Ninja
168+
-DCMAKE_C_COMPILER_LAUNCHER=ccache
169+
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache
170+
${{matrix.options}}
171+
-DENABLE_TESTS=ON
168172
- name: Restore cache
169-
uses: actions/cache/restore@v3
173+
uses: actions/cache/restore@v4
170174
if: always()
171175
with:
172176
path: ${{env.CCACHE_DIR}}
173177
key: ccache-macos-${{matrix.tag}}-${{github.run_id}}
174-
restore-keys: |
175-
ccache-macos-${{matrix.tag}}-
178+
restore-keys: ccache-macos-${{matrix.tag}}-
176179
- name: Build
177-
run: |
178-
cmake --build ${{github.workspace}}/build -v -j $(sysctl -n hw.logicalcpu)
180+
run: cmake --build ${{github.workspace}}/build -v -j $(sysctl -n hw.logicalcpu)
179181
- name: Save cache
180-
uses: actions/cache/save@v3
182+
uses: actions/cache/save@v4
181183
if: always()
182184
with:
183185
path: ${{env.CCACHE_DIR}}
184186
key: ccache-macos-${{matrix.tag}}-${{github.run_id}}
185187
- name: Run tests
186-
run: |
187-
ctest --test-dir ${{github.workspace}}/build -j $(sysctl -n hw.logicalcpu)
188+
run: ctest --test-dir ${{github.workspace}}/build -j $(sysctl -n hw.logicalcpu)
188189
- name: Upload test logs
189-
uses: actions/upload-artifact@v3
190+
uses: actions/upload-artifact@v4
190191
if: always()
191192
with:
192193
name: testlog-macos-${{matrix.tag}}
@@ -224,7 +225,7 @@ jobs:
224225
-DENABLE_UPNP=ON
225226
steps:
226227
- name: Checkout
227-
uses: actions/checkout@v3
228+
uses: actions/checkout@v4
228229
- name: Setup MSYS2
229230
uses: msys2/setup-msys2@v2
230231
with:
@@ -243,34 +244,31 @@ jobs:
243244
openssl:p
244245
toolchain:p
245246
- name: Configure
246-
run: |
247-
cmake -B ./build -G Ninja \
248-
-DCMAKE_C_COMPILER_LAUNCHER=ccache \
249-
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
250-
${{matrix.options}} \
251-
-DBUILD_SHARED_LIBS=OFF -DENABLE_TESTS=ON
247+
run: cmake
248+
-B ./build -G Ninja
249+
-DCMAKE_C_COMPILER_LAUNCHER=ccache
250+
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache
251+
${{matrix.options}}
252+
-DBUILD_SHARED_LIBS=OFF -DENABLE_TESTS=ON
252253
- name: Restore cache
253-
uses: actions/cache/restore@v3
254+
uses: actions/cache/restore@v4
254255
if: always()
255256
with:
256257
path: ${{env.CCACHE_DIR}}
257258
key: ccache-msys2-${{matrix.tag}}-${{github.run_id}}
258-
restore-keys: |
259-
ccache-msys2-${{matrix.tag}}-
259+
restore-keys: ccache-msys2-${{matrix.tag}}-
260260
- name: Build
261-
run: |
262-
cmake --build ./build -v -j $NUMBER_OF_PROCESSORS
261+
run: cmake --build ./build -v -j $NUMBER_OF_PROCESSORS
263262
- name: Save cache
264-
uses: actions/cache/save@v3
263+
uses: actions/cache/save@v4
265264
if: always()
266265
with:
267266
path: ${{env.CCACHE_DIR}}
268267
key: ccache-msys2-${{matrix.tag}}-${{github.run_id}}
269268
- name: Run tests
270-
run: |
271-
ctest --test-dir ./build -j $NUMBER_OF_PROCESSORS
269+
run: ctest --test-dir ./build -j $NUMBER_OF_PROCESSORS
272270
- name: Upload test logs
273-
uses: actions/upload-artifact@v3
271+
uses: actions/upload-artifact@v4
274272
if: always()
275273
with:
276274
name: testlog-msys-${{matrix.tag}}

‎CHANGELOG.md

+33
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,39 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/)
55
and this project adheres to [Semantic Versioning](https://semver.org/).
66

7+
## [5.4.9.0], 2025-02-16, leisure
8+
9+
### Added
10+
- depends: add cross arm64-darwin support #2775 (@div72)
11+
- build: add missing randomness checks #2772 (@div72)
12+
- init, registry: Support -clearallregistryhistory startup parameter #2773 (@jamescowens)
13+
14+
### Changed
15+
- build: omit _FORTIFY_SOURCE on debug #2793 (@div72)
16+
- doc: cmake is required for Windows depends #2791 (@barton2526)
17+
- CMake: Set maximum supported Boost version #2788 (@CyberTailor)
18+
- ci: bump to MacOS 13 #2784 (@div72)
19+
- build/cmake: disable LevelDB tests #2776 (@div72)
20+
- util: use XDG_STATE_HOME for datadir on Flatpak #2774 (@div72)
21+
- util, build: Support miniupnp API version 18+ #2771 (@jamescowens)
22+
- build: explicitly include FindPkgConfig for CMake #2769 (@jamescowens)
23+
- ci, cd: bump action versions #2763 (@div72)
24+
- Sync CMake CI #2762 (@CyberTailor)
25+
- cpid: Modify CPID local hasher to eliminate compiler warnings on 32 bit archs #2760 (@jamescowens)
26+
27+
### Removed
28+
- refactor, misc: remove CBitcoin(Address|Secret) #2634 (@div72)
29+
30+
### Fixed
31+
- poll, gui: Disable choice add button in poll wizard when choice limit is reached #2792 (@jamescowens)
32+
- diagnose, rpc: fix compilation with boost 1.87 #2786 (@div72)
33+
- node: fix build with GCC 15 #2783 (@CyberTailor)
34+
- ci: use overwrite with brew install on MacOS CMake #2782 (@div72)
35+
- scraper: Protect access to ConvergedStats.csv.gz with a lock #2779 (@jamescowens)
36+
- fix build on FreeBSD #2770 (@wilkart)
37+
- rpc/server: fix removing deprecated commands from command list #2768 (@lrusak)
38+
- cmake bdb53: disable error for implicit-int with gcc #2767 (@lrusak)
39+
740
## [5.4.8.0], 2024-04-10, leisure
841

942
### Added

0 commit comments

Comments
 (0)