Skip to content

Commit 454f103

Browse files
committed
5.2.0.0, 2021-03-01, mandatory, "Hilda"
Added - gui: Add RAC column to wizard summary page projects table #1951 (@cyrossignol) - rpc: clean up the superblocks function and add magnitude to getmininginfo #1966 (@jamescowens) - rpc: Add transaction size to RPC output #1971 (@cyrossignol) - voting: Add user-facing support for poll response types #1976 (@cyrossignol) - gui: Port Bitcoin Intro class (implement the ability to choose a data directory via the GUI) #1978 (@jamescowens) - gui: Port Bitcoin MacOS app nap manager #1991 (@jamescowens) - mining, rpc: Implement staking efficiency measure and improve SelectCoinsForStaking and CreateCoinStake #1992 (@jamescowens) - accrual, rpc: Implement auditsnapshotaccruals #2001 (@jamescowens) - docs: add doxygen support #2000 (@div72) - beacon: Specialized beacon storage in leveldb #2009 (@jamescowens) - rpc: Add a call to dump contracts in binary form #2011 (@div72) - rpc: Add boolean option to report active beacons only in beaconreport #2013 (@jamescowens) - consensus: Set Hilda mainnet hardfork height to 2197000 #2022 (@jamescowens) Changed - refactor: [Memory optimization] Block index duplicate PoS state #1945 (@cyrossignol) - refactor: [Memory optimization] Block index superblock and contract flags #1950 (@cyrossignol) - refactor: [Memory optimization] Remove stake modifier checksums #1954 (@cyrossignol) - refactor: [Memory optimization] Block index allocation overhead #1957 (@cyrossignol) - refactor: [Memory optimization] Remove block index subsidy fields #1960 (@cyrossignol) - refactor: [Memory optimization] Separate chain trust from the block index #1961 (@cyrossignol) - refactor: [Memory optimization] Eliminate padding between block index fields #1962 (@cyrossignol) - beacon, gui: Add check for presence of beacon private key to updateBeacon() #1968 (@jamescowens) - util: Enhance ETTS calculation #1973 (@jamescowens) - refactor: Use new clamp in util.h #1975 (@jamescowens) - gui: Redo global status for overview #1983 (@jamescowens) - util: Improvements to MilliTimer class and use in the miner and init #1987 (@jamescowens) - rpc: Move rpc files to directory #1995 (@Pythonix) - rpc: Enhance consolidateunspent and fix fee calculation #1994 (@jamescowens) - contract: Double the lookback scope of contract replay #1998 (@jamescowens) - net: Don't rely on external IP resolvers #2002 (@Tetrix42) - beacon: Change beacon map to pointers #2008 (@jamescowens) - gui: Update bitcoin_sv.ts #2014 (@sweede-se) - util: Update snapshot URLs and add accrual directory #2019 (@jamescowens) - beacon: Tweak BeaconRegistry::Revert #2020 (@jamescowens) - rpc, qt: bump fees @2023 (@div72) Removed - researcher: Remove automatic legacy beacon key import #1963 (@cyrossignol) - util: Revert "Close LevelDB after loading the block index" #1969 (@cyrossignol) - ci: Fix python symlink issue & remove travis #1990 (@div72) - ci: remove python workaround #2005 (@div72) Fixed - gui: fix mandatory/leisure detection of upgrade check #1959 (@Pythonix) - voting: Fix title in "gettransaction" RPC for legacy poll contracts @1970 (@cyrossignol) - gui: Fix missing menu items on macOS #1972 (@scribblemaniac) - rpc: Fix answer offset in "votedetails" #1974 (@cyrossignol) - voting: Implement missing try-catch in VotingVoteDialog::vote #1980 (@jamescowens) - scraper: Add check for minimum housekeeping complete in scraper #1977 (@jamescowens) - voting: Fix nonsense vote weights for legacy polls #1988 (@cyrossignol) - voting: Fix incorrect field returned in ResolveMoneySupplyForPoll() #1989 (@cyrossignol) - consensus, accrual: Fix newbie accrual #2004 (@jamescowens) - log: grammar correction #2016 (@nathanielcwm) - wallet: Correct nMinFee fee calculation in CreateTransaction #2021 (@jamescowens) - rpc, miner: Correct GetLastStake #2026 (@jamescowens) - wallet: Fix bug in CreateTransaction causing insufficient fees #2029 (@jamescowens)
2 parents cbd215b + 5b2a6a4 commit 454f103

File tree

135 files changed

+406902
-2131
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

135 files changed

+406902
-2131
lines changed

.github/workflows/ci.yml

+82
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,82 @@
1+
name: CI
2+
on: [push, pull_request]
3+
env:
4+
EVENT_TYPE: ${{ github.event_name }}
5+
COMMIT_COUNT: ${{ github.event.commits.length }}
6+
jobs:
7+
test-linux:
8+
name: ${{ matrix.name }}
9+
runs-on: ubuntu-18.04
10+
strategy:
11+
matrix:
12+
include:
13+
- name: ARM [GOAL install] [buster]
14+
script-id: arm
15+
- name: Win32
16+
script-id: win32
17+
- name: Win64
18+
script-id: win64
19+
- name: i386 Linux [GOAL install] [focal]
20+
script-id: linux_i386
21+
- name: x86_64 Linux [GOAL install] [GUI] [focal] [no depends]
22+
script-id: native
23+
- name: x86_64 Linux [GOAL install] [GUI] [xenial] [no depends]
24+
script-id: native_old
25+
- name: macOS 10.12 [no tests]
26+
script-id: mac
27+
env:
28+
FILE_ENV: ./ci/test/00_setup_env_${{ matrix.script-id }}.sh
29+
OS_NAME: linux
30+
steps:
31+
- name: checkout
32+
uses: actions/checkout@v2
33+
- name: cache
34+
uses: actions/cache@v2
35+
with:
36+
path: |
37+
./depends/built
38+
./ci/scratch/.ccache
39+
key: ${{ runner.os }}-${{ matrix.script-id }}
40+
- name: test
41+
run: |
42+
./ci/test_run_all.sh
43+
test-macos:
44+
name: macOS 10.15 native [GOAL install] [GUI] [no depends]
45+
runs-on: macos-10.15
46+
env:
47+
DANGER_RUN_CI_ON_HOST: true
48+
CI_USE_APT_INSTALL: no
49+
FILE_ENV: ./ci/test/00_setup_env_mac_host.sh
50+
OS_NAME: macos
51+
steps:
52+
- name: checkout
53+
uses: actions/checkout@v2
54+
- name: cache
55+
uses: actions/cache@v2
56+
with:
57+
path: |
58+
./ci/scratch/.ccache
59+
key: ${{ runner.os }}
60+
- name: install-packages
61+
run: |
62+
brew install autoconf automake berkeley-db4 boost miniupnpc qrencode ccache leveldb librsvg libtool libzip openssl pkg-config python qt xquartz
63+
- name: test
64+
run: |
65+
./ci/test_run_all.sh
66+
lint:
67+
name: Lint
68+
runs-on: ubuntu-latest
69+
continue-on-error: true
70+
steps:
71+
- name: checkout
72+
uses: actions/checkout@v2
73+
- name: setup-python
74+
uses: actions/setup-python@v2
75+
with:
76+
python-version: 3.5
77+
- name: lint
78+
continue-on-error: true
79+
run: |
80+
set -o errexit; source ./ci/lint/04_install.sh
81+
set -o errexit; source ./ci/lint/05_before_script.sh
82+
set -o errexit; source ./ci/lint/06_script.sh

.gitignore

+1-1
Original file line numberDiff line numberDiff line change
@@ -96,4 +96,4 @@ contrib/devtools/split-debug.sh
9696
*.lo
9797
*.la
9898

99-
99+
/doc/doxygen/

.travis.yml

-124
This file was deleted.

CHANGELOG.md

+60
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,66 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](http://keepachangelog.com/)
55
and this project adheres to [Semantic Versioning](http://semver.org/).
66

7+
## [5.2.0.0] 2021-03-01, mandatory, "Hilda"
8+
### Added
9+
- gui: Add RAC column to wizard summary page projects table #1951 (@cyrossignol)
10+
- rpc: clean up the superblocks function and add magnitude to getmininginfo #1966 (@jamescowens)
11+
- rpc: Add transaction size to RPC output #1971 (@cyrossignol)
12+
- voting: Add user-facing support for poll response types #1976 (@cyrossignol)
13+
- gui: Port Bitcoin Intro class (implement the ability to choose a data directory via the GUI) #1978 (@jamescowens)
14+
- gui: Port Bitcoin MacOS app nap manager #1991 (@jamescowens)
15+
- mining, rpc: Implement staking efficiency measure and improve SelectCoinsForStaking and CreateCoinStake #1992 (@jamescowens)
16+
- accrual, rpc: Implement auditsnapshotaccruals #2001 (@jamescowens)
17+
- docs: add doxygen support #2000 (@div72)
18+
- beacon: Specialized beacon storage in leveldb #2009 (@jamescowens)
19+
- rpc: Add a call to dump contracts in binary form #2011 (@div72)
20+
- rpc: Add boolean option to report active beacons only in beaconreport #2013 (@jamescowens)
21+
- consensus: Set Hilda mainnet hardfork height to 2197000 #2022 (@jamescowens)
22+
23+
### Changed
24+
- refactor: [Memory optimization] Block index duplicate PoS state #1945 (@cyrossignol)
25+
- refactor: [Memory optimization] Block index superblock and contract flags #1950 (@cyrossignol)
26+
- refactor: [Memory optimization] Remove stake modifier checksums #1954 (@cyrossignol)
27+
- refactor: [Memory optimization] Block index allocation overhead #1957 (@cyrossignol)
28+
- refactor: [Memory optimization] Remove block index subsidy fields #1960 (@cyrossignol)
29+
- refactor: [Memory optimization] Separate chain trust from the block index #1961 (@cyrossignol)
30+
- refactor: [Memory optimization] Eliminate padding between block index fields #1962 (@cyrossignol)
31+
- beacon, gui: Add check for presence of beacon private key to updateBeacon() #1968 (@jamescowens)
32+
- util: Enhance ETTS calculation #1973 (@jamescowens)
33+
- refactor: Use new clamp in util.h #1975 (@jamescowens)
34+
- gui: Redo global status for overview #1983 (@jamescowens)
35+
- util: Improvements to MilliTimer class and use in the miner and init #1987 (@jamescowens)
36+
- rpc: Move rpc files to directory #1995 (@Pythonix)
37+
- rpc: Enhance consolidateunspent and fix fee calculation #1994 (@jamescowens)
38+
- contract: Double the lookback scope of contract replay #1998 (@jamescowens)
39+
- net: Don't rely on external IP resolvers #2002 (@Tetrix42)
40+
- beacon: Change beacon map to pointers #2008 (@jamescowens)
41+
- gui: Update bitcoin_sv.ts #2014 (@sweede-se)
42+
- util: Update snapshot URLs and add accrual directory #2019 (@jamescowens)
43+
- beacon: Tweak BeaconRegistry::Revert #2020 (@jamescowens)
44+
- rpc, qt: bump fees @2023 (@div72)
45+
46+
### Removed
47+
- researcher: Remove automatic legacy beacon key import #1963 (@cyrossignol)
48+
- util: Revert "Close LevelDB after loading the block index" #1969 (@cyrossignol)
49+
- ci: Fix python symlink issue & remove travis #1990 (@div72)
50+
- ci: remove python workaround #2005 (@div72)
51+
52+
### Fixed
53+
- gui: fix mandatory/leisure detection of upgrade check #1959 (@Pythonix)
54+
- voting: Fix title in "gettransaction" RPC for legacy poll contracts @1970 (@cyrossignol)
55+
- gui: Fix missing menu items on macOS #1972 (@scribblemaniac)
56+
- rpc: Fix answer offset in "votedetails" #1974 (@cyrossignol)
57+
- voting: Implement missing try-catch in VotingVoteDialog::vote #1980 (@jamescowens)
58+
- scraper: Add check for minimum housekeeping complete in scraper #1977 (@jamescowens)
59+
- voting: Fix nonsense vote weights for legacy polls #1988 (@cyrossignol)
60+
- voting: Fix incorrect field returned in ResolveMoneySupplyForPoll() #1989 (@cyrossignol)
61+
- consensus, accrual: Fix newbie accrual #2004 (@jamescowens)
62+
- log: grammar correction #2016 (@nathanielcwm)
63+
- wallet: Correct nMinFee fee calculation in CreateTransaction #2021 (@jamescowens)
64+
- rpc, miner: Correct GetLastStake #2026 (@jamescowens)
65+
- wallet: Fix bug in CreateTransaction causing insufficient fees #2029 (@jamescowens)
66+
767
## [5.1.0.0] 2020-11-01, mandatory, "Gladys"
868
### Added
969
- rpc: Add out-of-sync status to "getinfo" and "getblockchaininfo" #1925 (@cyrossignol)

Makefile.am

+16-1
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,21 @@ CLEANFILES = $(OSX_DMG) $(BITCOIN_WIN_INSTALLER)
207207

208208
DISTCHECK_CONFIGURE_FLAGS = --enable-man
209209

210-
clean-local:
210+
doc/doxygen/.stamp: doc/Doxyfile FORCE
211+
$(MKDIR_P) $(@D)
212+
$(DOXYGEN) $^
213+
$(AM_V_at) touch $@
214+
215+
if HAVE_DOXYGEN
216+
docs: doc/doxygen/.stamp
217+
else
218+
docs:
219+
@echo "error: doxygen not found"
220+
endif
221+
222+
clean-docs:
223+
rm -rf doc/doxygen
224+
225+
clean-local: clean-docs
211226
rm -rf coverage_percent.txt test_bitcoin.coverage/ total.coverage/ test/tmp/ cache/ $(OSX_APP)
212227
rm -rf test/functional/__pycache__

ci/lint/04_install.sh

+5-5
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@
66

77
export LC_ALL=C
88

9-
travis_retry sudo apt update && sudo apt install -y clang-format-9
9+
./ci/retry/retry sudo apt update && sudo apt install -y clang-format-9
1010
sudo update-alternatives --install /usr/bin/clang-format clang-format $(which clang-format-9 ) 100
1111
sudo update-alternatives --install /usr/bin/clang-format-diff clang-format-diff $(which clang-format-diff-9) 100
1212

13-
travis_retry pip3 install codespell==1.17.1
14-
travis_retry pip3 install flake8==3.8.3
15-
travis_retry pip3 install yq
16-
travis_retry pip3 install mypy==0.781
13+
./ci/retry/retry pip3 install codespell==1.17.1
14+
./ci/retry/retry pip3 install flake8==3.8.3
15+
./ci/retry/retry pip3 install yq
16+
./ci/retry/retry pip3 install mypy==0.781
1717

1818
SHELLCHECK_VERSION=v0.7.1
1919
curl -sL "https://github.com/koalaman/shellcheck/releases/download/${SHELLCHECK_VERSION}/shellcheck-${SHELLCHECK_VERSION}.linux.x86_64.tar.xz" | tar --xz -xf - --directory /tmp/

ci/lint/06_script.sh

+3
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ if [ "$TRAVIS_EVENT_TYPE" = "pull_request" ]; then
1010
test/lint/commit-script-check.sh $TRAVIS_COMMIT_RANGE
1111
fi
1212

13+
if [ "$EVENT_TYPE" = "pull_request" ]; then
14+
test/lint/commit-script-check.sh $(git rev-parse HEAD~$COMMIT_COUNT)..$GITHUB_SHA
15+
fi
1316
#test/lint/git-subtree-check.sh src/crypto/ctaes
1417
#test/lint/git-subtree-check.sh src/secp256k1
1518
#test/lint/git-subtree-check.sh src/univalue

ci/test/00_setup_env_mac.sh

+1
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,4 @@ export RUN_FUNCTIONAL_TESTS=false
1616
export GOAL=""
1717
export DEP_OPTS="NO_QT=1"
1818
export GRIDCOIN_CONFIG="--enable-reduce-exports"
19+
export NEED_XVFB="false"

ci/test/03_before_install.sh

+10-2
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,20 @@ export LC_ALL=C.UTF-8
99
BEGIN_FOLD () {
1010
echo ""
1111
CURRENT_FOLD_NAME=$1
12-
echo "travis_fold:start:${CURRENT_FOLD_NAME}"
12+
if [ "$TRAVIS" == "true" ]; then
13+
echo "travis_fold:start:${CURRENT_FOLD_NAME}"
14+
else
15+
echo "::group::${CURRENT_FOLD_NAME}"
16+
fi
1317
}
1418

1519
END_FOLD () {
1620
RET=$?
17-
echo "travis_fold:end:${CURRENT_FOLD_NAME}"
21+
if [ "$TRAVIS" == "true" ]; then
22+
echo "travis_fold:end:${CURRENT_FOLD_NAME}"
23+
else
24+
echo "::endgroup::"
25+
fi
1826
if [ $RET != 0 ]; then
1927
echo "${CURRENT_FOLD_NAME} failed with status code ${RET}"
2028
fi

ci/test/04_install.sh

+5-1
Original file line numberDiff line numberDiff line change
@@ -54,17 +54,21 @@ if [ -n "$DPKG_ADD_ARCH" ]; then
5454
fi
5555

5656
if [[ $DOCKER_NAME_TAG == centos* ]]; then
57+
BEGIN_FOLD yum
5758
${CI_RETRY_EXE} DOCKER_EXEC yum -y install epel-release
5859
${CI_RETRY_EXE} DOCKER_EXEC yum -y install $DOCKER_PACKAGES $PACKAGES
60+
END_FOLD
5961
elif [ "$CI_USE_APT_INSTALL" != "no" ]; then
62+
BEGIN_FOLD apt
6063
${CI_RETRY_EXE} DOCKER_EXEC apt-get update
6164
${CI_RETRY_EXE} DOCKER_EXEC apt-get install --no-install-recommends --no-upgrade -y $PACKAGES $DOCKER_PACKAGES
6265
if [ "$NEED_XVFB" == "true" ]; then
6366
${CI_RETRY_EXE} DOCKER_EXEC apt-get install --no-install-recommends --no-upgrade -y xvfb
6467
fi
68+
END_FOLD
6569
fi
6670

67-
if [ "$TRAVIS_OS_NAME" == "osx" ]; then
71+
if [ "$OS_NAME" == "macos" ]; then
6872
top -l 1 -s 0 | awk ' /PhysMem/ {print}'
6973
echo "Number of CPUs: $(sysctl -n hw.logicalcpu)"
7074
else

0 commit comments

Comments
 (0)