From 143a9ff2ca218cc643827ee3f0a61db8731afcda Mon Sep 17 00:00:00 2001 From: Chetan Kini Date: Mon, 14 Nov 2022 09:17:30 -0500 Subject: [PATCH] [MAINTENANCE] Move Cloud-specific enums to `cloud_constants.py` (#6349) --- great_expectations/checkpoint/checkpoint.py | 4 +-- great_expectations/core/config_provider.py | 2 +- .../data_context/cloud_constants.py | 27 +++++++++++++++++++ .../data_context/base_data_context.py | 4 +-- .../data_context/cloud_data_context.py | 16 ++++------- .../data_context/data_context_variables.py | 4 +-- .../data_context/migrator/cloud_migrator.py | 2 +- .../data_context/store/checkpoint_store.py | 4 +-- .../data_context/store/configuration_store.py | 4 +-- .../data_context/store/expectations_store.py | 4 +-- .../store/ge_cloud_store_backend.py | 25 +++-------------- .../data_context/store/profiler_store.py | 4 +-- .../data_context/store/validations_store.py | 4 +-- .../types/resource_identifiers.py | 4 +-- .../render/renderer/site_builder.py | 4 +-- .../rule_based_profiler.py | 4 +-- .../validation_operators.py | 4 +-- tests/actions/conftest.py | 4 +-- tests/conftest.py | 4 +-- .../test_checkpoint_crud.py | 4 +-- .../test_expectation_suite_crud.py | 4 +-- .../test_include_rendered_content.py | 4 +-- .../cloud_data_context/test_profiler_crud.py | 4 +-- .../migrator/test_cloud_migrator.py | 4 +-- tests/data_context/store/conftest.py | 4 +-- .../store/test_checkpoint_store.py | 4 +-- .../store/test_configuration_store.py | 11 +------- .../store/test_datasource_store.py | 4 +-- .../test_datasource_store_cloud_backend.py | 4 +-- .../store/test_ge_cloud_store_backend.py | 6 +++-- .../data_context/store/test_store_backends.py | 10 +------ 31 files changed, 67 insertions(+), 124 deletions(-) diff --git a/great_expectations/checkpoint/checkpoint.py b/great_expectations/checkpoint/checkpoint.py index 7abb06630c09..b15a8a8d82e5 100644 --- a/great_expectations/checkpoint/checkpoint.py +++ b/great_expectations/checkpoint/checkpoint.py @@ -38,9 +38,7 @@ usage_statistics_enabled_method, ) from great_expectations.data_asset import DataAsset -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.types.base import ( CheckpointConfig, CheckpointValidationConfig, diff --git a/great_expectations/core/config_provider.py b/great_expectations/core/config_provider.py index 06bdff0950b9..7823aad3f45b 100644 --- a/great_expectations/core/config_provider.py +++ b/great_expectations/core/config_provider.py @@ -155,7 +155,7 @@ def __init__(self, cloud_config: GeCloudConfig) -> None: self._cloud_config = cloud_config def get_values(self) -> Dict[str, str]: - from great_expectations.data_context.data_context.cloud_data_context import ( + from great_expectations.data_context.cloud_constants import ( GECloudEnvironmentVariable, ) diff --git a/great_expectations/data_context/cloud_constants.py b/great_expectations/data_context/cloud_constants.py index 86d23092ec98..79dd64278b30 100644 --- a/great_expectations/data_context/cloud_constants.py +++ b/great_expectations/data_context/cloud_constants.py @@ -1,3 +1,30 @@ +from enum import Enum + from typing_extensions import Final CLOUD_DEFAULT_BASE_URL: Final[str] = "https://api.greatexpectations.io/" + + +class GECloudEnvironmentVariable(str, Enum): + BASE_URL = "GE_CLOUD_BASE_URL" + ORGANIZATION_ID = "GE_CLOUD_ORGANIZATION_ID" + ACCESS_TOKEN = "GE_CLOUD_ACCESS_TOKEN" + + +class GeCloudRESTResource(str, Enum): + BATCH = "batch" + CHECKPOINT = "checkpoint" + # Chetan - 20220811 - CONTRACT is deprecated by GX Cloud and is to be removed upon migration of E2E tests + CONTRACT = "contract" + DATASOURCE = "datasource" + DATA_ASSET = "data_asset" + DATA_CONTEXT = "data_context" + DATA_CONTEXT_VARIABLES = "data_context_variables" + EXPECTATION = "expectation" + EXPECTATION_SUITE = "expectation_suite" + EXPECTATION_VALIDATION_RESULT = "expectation_validation_result" + PROFILER = "profiler" + RENDERED_DATA_DOC = "rendered_data_doc" + # Chetan - 20220812 - SUITE_VALIDATION_RESULT is deprecated by GX Cloud and is to be removed upon migration of E2E tests + SUITE_VALIDATION_RESULT = "suite_validation_result" + VALIDATION_RESULT = "validation_result" diff --git a/great_expectations/data_context/data_context/base_data_context.py b/great_expectations/data_context/data_context/base_data_context.py index a32540e5cccd..4ab0cccfb45e 100644 --- a/great_expectations/data_context/data_context/base_data_context.py +++ b/great_expectations/data_context/data_context/base_data_context.py @@ -21,6 +21,7 @@ usage_statistics_enabled_method, ) from great_expectations.data_asset import DataAsset +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.data_context.cloud_data_context import ( CloudDataContext, ) @@ -30,9 +31,6 @@ from great_expectations.data_context.data_context.file_data_context import ( FileDataContext, ) -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) from great_expectations.data_context.templates import CONFIG_VARIABLES_TEMPLATE from great_expectations.data_context.types.base import ( DataContextConfig, diff --git a/great_expectations/data_context/data_context/cloud_data_context.py b/great_expectations/data_context/data_context/cloud_data_context.py index afa688eb224d..83be94064478 100644 --- a/great_expectations/data_context/data_context/cloud_data_context.py +++ b/great_expectations/data_context/data_context/cloud_data_context.py @@ -2,7 +2,6 @@ import logging import os -from enum import Enum from typing import TYPE_CHECKING, Dict, List, Mapping, Optional, Union, cast import requests @@ -15,16 +14,17 @@ ConfigurationProvider, ) from great_expectations.core.serializer import JsonConfigSerializer -from great_expectations.data_context.cloud_constants import CLOUD_DEFAULT_BASE_URL +from great_expectations.data_context.cloud_constants import ( + CLOUD_DEFAULT_BASE_URL, + GECloudEnvironmentVariable, + GeCloudRESTResource, +) from great_expectations.data_context.data_context.abstract_data_context import ( AbstractDataContext, ) from great_expectations.data_context.data_context_variables import ( CloudDataContextVariables, ) -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) from great_expectations.data_context.types.base import ( DEFAULT_USAGE_STATISTICS_URL, DataContextConfig, @@ -43,12 +43,6 @@ logger = logging.getLogger(__name__) -class GECloudEnvironmentVariable(str, Enum): - BASE_URL = "GE_CLOUD_BASE_URL" - ORGANIZATION_ID = "GE_CLOUD_ORGANIZATION_ID" - ACCESS_TOKEN = "GE_CLOUD_ACCESS_TOKEN" - - class CloudDataContext(AbstractDataContext): """ Subclass of AbstractDataContext that contains functionality necessary to hydrate state from cloud diff --git a/great_expectations/data_context/data_context_variables.py b/great_expectations/data_context/data_context_variables.py index 248968954142..d13b659820ec 100644 --- a/great_expectations/data_context/data_context_variables.py +++ b/great_expectations/data_context/data_context_variables.py @@ -366,12 +366,10 @@ def __post_init__(self) -> None: ) def _init_store(self) -> DataContextStore: + from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.store.data_context_store import ( DataContextStore, ) - from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, - ) store_backend: dict = { "class_name": "GeCloudStoreBackend", diff --git a/great_expectations/data_context/migrator/cloud_migrator.py b/great_expectations/data_context/migrator/cloud_migrator.py index 662b0af07261..fd6f03fbe677 100644 --- a/great_expectations/data_context/migrator/cloud_migrator.py +++ b/great_expectations/data_context/migrator/cloud_migrator.py @@ -29,6 +29,7 @@ from great_expectations.core.http import create_session from great_expectations.core.usage_statistics.events import UsageStatsEvents from great_expectations.core.usage_statistics.usage_statistics import send_usage_message +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.data_context.base_data_context import ( BaseDataContext, ) @@ -41,7 +42,6 @@ ConfigurationBundleSchema, ) from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, GeCloudStoreBackend, construct_json_payload, construct_url, diff --git a/great_expectations/data_context/store/checkpoint_store.py b/great_expectations/data_context/store/checkpoint_store.py index c662df7cba69..f096768dc979 100644 --- a/great_expectations/data_context/store/checkpoint_store.py +++ b/great_expectations/data_context/store/checkpoint_store.py @@ -9,10 +9,8 @@ import great_expectations.exceptions as ge_exceptions from great_expectations.core.data_context_key import DataContextKey +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.store import ConfigurationStore -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) from great_expectations.data_context.types.base import ( CheckpointConfig, DataContextConfigDefaults, diff --git a/great_expectations/data_context/store/configuration_store.py b/great_expectations/data_context/store/configuration_store.py index 8dc75c34cd8c..9b73b597e0d4 100644 --- a/great_expectations/data_context/store/configuration_store.py +++ b/great_expectations/data_context/store/configuration_store.py @@ -5,9 +5,7 @@ from ruamel.yaml.comments import CommentedMap import great_expectations.exceptions as ge_exceptions -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.store.store import Store from great_expectations.data_context.store.tuple_store_backend import TupleStoreBackend from great_expectations.data_context.types.base import BaseYamlConfig diff --git a/great_expectations/data_context/store/expectations_store.py b/great_expectations/data_context/store/expectations_store.py index 6d1bd274636f..f0f21a893094 100644 --- a/great_expectations/data_context/store/expectations_store.py +++ b/great_expectations/data_context/store/expectations_store.py @@ -4,12 +4,10 @@ from great_expectations.core import ExpectationSuite from great_expectations.core.expectation_suite import ExpectationSuiteSchema +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.store.database_store_backend import ( DatabaseStoreBackend, ) -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) from great_expectations.data_context.store.store import Store from great_expectations.data_context.store.tuple_store_backend import TupleStoreBackend from great_expectations.data_context.types.resource_identifiers import ( diff --git a/great_expectations/data_context/store/ge_cloud_store_backend.py b/great_expectations/data_context/store/ge_cloud_store_backend.py index 35058fd73ba7..9edb1ac6388c 100644 --- a/great_expectations/data_context/store/ge_cloud_store_backend.py +++ b/great_expectations/data_context/store/ge_cloud_store_backend.py @@ -1,14 +1,16 @@ import json import logging from abc import ABCMeta -from enum import Enum from typing import Any, Dict, List, Optional, Set, Tuple, Union, cast from urllib.parse import urljoin import requests from great_expectations.core.http import create_session -from great_expectations.data_context.cloud_constants import CLOUD_DEFAULT_BASE_URL +from great_expectations.data_context.cloud_constants import ( + CLOUD_DEFAULT_BASE_URL, + GeCloudRESTResource, +) from great_expectations.data_context.store.store_backend import StoreBackend from great_expectations.data_context.types.refs import GeCloudResourceRef from great_expectations.data_context.types.resource_identifiers import GeCloudIdentifier @@ -107,25 +109,6 @@ def get_user_friendly_error_message( return " ".join(support_message) -class GeCloudRESTResource(str, Enum): - BATCH = "batch" - CHECKPOINT = "checkpoint" - # Chetan - 20220811 - CONTRACT is deprecated by GX Cloud and is to be removed upon migration of E2E tests - CONTRACT = "contract" - DATASOURCE = "datasource" - DATA_ASSET = "data_asset" - DATA_CONTEXT = "data_context" - DATA_CONTEXT_VARIABLES = "data_context_variables" - EXPECTATION = "expectation" - EXPECTATION_SUITE = "expectation_suite" - EXPECTATION_VALIDATION_RESULT = "expectation_validation_result" - PROFILER = "profiler" - RENDERED_DATA_DOC = "rendered_data_doc" - # Chetan - 20220812 - SUITE_VALIDATION_RESULT is deprecated by GX Cloud and is to be removed upon migration of E2E tests - SUITE_VALIDATION_RESULT = "suite_validation_result" - VALIDATION_RESULT = "validation_result" - - class GeCloudStoreBackend(StoreBackend, metaclass=ABCMeta): PAYLOAD_ATTRIBUTES_KEYS: Dict[GeCloudRESTResource, str] = { GeCloudRESTResource.CHECKPOINT: "checkpoint_config", diff --git a/great_expectations/data_context/store/profiler_store.py b/great_expectations/data_context/store/profiler_store.py index 5c098e5088fe..76b54988c2c2 100644 --- a/great_expectations/data_context/store/profiler_store.py +++ b/great_expectations/data_context/store/profiler_store.py @@ -2,10 +2,8 @@ import uuid from typing import Union +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.store.configuration_store import ConfigurationStore -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) from great_expectations.data_context.types.resource_identifiers import ( ConfigurationIdentifier, GeCloudIdentifier, diff --git a/great_expectations/data_context/store/validations_store.py b/great_expectations/data_context/store/validations_store.py index 24d8f012a02c..041d0361ec2a 100644 --- a/great_expectations/data_context/store/validations_store.py +++ b/great_expectations/data_context/store/validations_store.py @@ -6,12 +6,10 @@ ExpectationSuiteValidationResult, ExpectationSuiteValidationResultSchema, ) +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.store.database_store_backend import ( DatabaseStoreBackend, ) -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) from great_expectations.data_context.store.store import Store from great_expectations.data_context.store.tuple_store_backend import TupleStoreBackend from great_expectations.data_context.types.resource_identifiers import ( diff --git a/great_expectations/data_context/types/resource_identifiers.py b/great_expectations/data_context/types/resource_identifiers.py index 57e45b2c5818..0db13c1b57b4 100644 --- a/great_expectations/data_context/types/resource_identifiers.py +++ b/great_expectations/data_context/types/resource_identifiers.py @@ -14,9 +14,7 @@ from great_expectations.exceptions import DataContextError, InvalidDataContextKeyError if TYPE_CHECKING: - from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, - ) + from great_expectations.data_context.cloud_constants import GeCloudRESTResource logger = logging.getLogger(__name__) diff --git a/great_expectations/render/renderer/site_builder.py b/great_expectations/render/renderer/site_builder.py index 3ce3a22e2c8e..6be919516cb1 100644 --- a/great_expectations/render/renderer/site_builder.py +++ b/great_expectations/render/renderer/site_builder.py @@ -7,9 +7,7 @@ import great_expectations.exceptions as exceptions from great_expectations.core import ExpectationSuite from great_expectations.core.util import nested_update -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.store.html_site_store import ( HtmlSiteStore, SiteSectionIdentifier, diff --git a/great_expectations/rule_based_profiler/rule_based_profiler.py b/great_expectations/rule_based_profiler/rule_based_profiler.py index 167c94de1997..9ed150ed42f3 100644 --- a/great_expectations/rule_based_profiler/rule_based_profiler.py +++ b/great_expectations/rule_based_profiler/rule_based_profiler.py @@ -26,9 +26,7 @@ determine_progress_bar_method_by_environment, nested_update, ) -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.types.refs import GeCloudResourceRef from great_expectations.data_context.types.resource_identifiers import ( ConfigurationIdentifier, diff --git a/great_expectations/validation_operators/validation_operators.py b/great_expectations/validation_operators/validation_operators.py index d4da265891ce..a3e790501a28 100644 --- a/great_expectations/validation_operators/validation_operators.py +++ b/great_expectations/validation_operators/validation_operators.py @@ -12,9 +12,7 @@ from great_expectations.core.run_identifier import RunIdentifier from great_expectations.data_asset import DataAsset from great_expectations.data_asset.util import parse_result_format -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.types.resource_identifiers import ( ExpectationSuiteIdentifier, GeCloudIdentifier, diff --git a/tests/actions/conftest.py b/tests/actions/conftest.py index 4218afa99460..c15e8ebaaae6 100644 --- a/tests/actions/conftest.py +++ b/tests/actions/conftest.py @@ -7,9 +7,7 @@ from great_expectations.core import ExpectationSuiteValidationResult, RunIdentifier from great_expectations.data_context import BaseDataContext -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.types.base import DataContextConfig from great_expectations.data_context.types.resource_identifiers import ( BatchIdentifier, diff --git a/tests/conftest.py b/tests/conftest.py index 5b146c79c2fc..5932a996f14b 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -30,9 +30,7 @@ ) from great_expectations.core.util import get_or_create_spark_application from great_expectations.data_context import BaseDataContext, CloudDataContext -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.store.profiler_store import ProfilerStore from great_expectations.data_context.types.base import ( AnonymizedUsageStatisticsConfig, diff --git a/tests/data_context/cloud_data_context/test_checkpoint_crud.py b/tests/data_context/cloud_data_context/test_checkpoint_crud.py index 152192ac7515..cf6660020387 100644 --- a/tests/data_context/cloud_data_context/test_checkpoint_crud.py +++ b/tests/data_context/cloud_data_context/test_checkpoint_crud.py @@ -4,6 +4,7 @@ import pytest +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.data_context.abstract_data_context import ( AbstractDataContext, ) @@ -14,9 +15,6 @@ CloudDataContext, ) from great_expectations.data_context.data_context.data_context import DataContext -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) from great_expectations.data_context.types.base import ( CheckpointConfig, DataContextConfig, diff --git a/tests/data_context/cloud_data_context/test_expectation_suite_crud.py b/tests/data_context/cloud_data_context/test_expectation_suite_crud.py index 3a2c700264fe..7da8f2b536fb 100644 --- a/tests/data_context/cloud_data_context/test_expectation_suite_crud.py +++ b/tests/data_context/cloud_data_context/test_expectation_suite_crud.py @@ -4,12 +4,10 @@ import pytest from great_expectations.core.expectation_suite import ExpectationSuite +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.data_context.base_data_context import ( BaseDataContext, ) -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) from great_expectations.data_context.types.base import DataContextConfig, GeCloudConfig from great_expectations.data_context.types.resource_identifiers import GeCloudIdentifier from great_expectations.exceptions.exceptions import DataContextError diff --git a/tests/data_context/cloud_data_context/test_include_rendered_content.py b/tests/data_context/cloud_data_context/test_include_rendered_content.py index 05c80d28aa64..2b36ea3238c1 100644 --- a/tests/data_context/cloud_data_context/test_include_rendered_content.py +++ b/tests/data_context/cloud_data_context/test_include_rendered_content.py @@ -9,9 +9,7 @@ ExpectationValidationResult, ) from great_expectations.core.batch import RuntimeBatchRequest -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.types.refs import GeCloudResourceRef from great_expectations.render import RenderedAtomicContent from great_expectations.validator.validator import Validator diff --git a/tests/data_context/cloud_data_context/test_profiler_crud.py b/tests/data_context/cloud_data_context/test_profiler_crud.py index 22b8162c1e4c..66b48ab753f8 100644 --- a/tests/data_context/cloud_data_context/test_profiler_crud.py +++ b/tests/data_context/cloud_data_context/test_profiler_crud.py @@ -3,13 +3,11 @@ import pytest +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.data_context.base_data_context import ( BaseDataContext, ) from great_expectations.data_context.data_context.data_context import DataContext -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) from great_expectations.data_context.types.base import DataContextConfig, GeCloudConfig from great_expectations.data_context.types.resource_identifiers import GeCloudIdentifier from great_expectations.rule_based_profiler.config.base import ( diff --git a/tests/data_context/migrator/test_cloud_migrator.py b/tests/data_context/migrator/test_cloud_migrator.py index d0719c6c4839..dc44a66cf78b 100644 --- a/tests/data_context/migrator/test_cloud_migrator.py +++ b/tests/data_context/migrator/test_cloud_migrator.py @@ -9,10 +9,8 @@ import great_expectations.exceptions as ge_exceptions from great_expectations import CloudMigrator from great_expectations.core.usage_statistics.events import UsageStatsEvents +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.migrator.cloud_migrator import MigrationResponse -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) from great_expectations.data_context.types.base import AnonymizedUsageStatisticsConfig from tests.data_context.migrator.conftest import StubBaseDataContext diff --git a/tests/data_context/store/conftest.py b/tests/data_context/store/conftest.py index 15fd57179ec2..7bed74297d8f 100644 --- a/tests/data_context/store/conftest.py +++ b/tests/data_context/store/conftest.py @@ -1,10 +1,8 @@ import pytest from great_expectations.core.serializer import JsonConfigSerializer +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.store import DatasourceStore -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) from great_expectations.data_context.types.base import datasourceConfigSchema diff --git a/tests/data_context/store/test_checkpoint_store.py b/tests/data_context/store/test_checkpoint_store.py index 832e5289329b..e31340433fda 100644 --- a/tests/data_context/store/test_checkpoint_store.py +++ b/tests/data_context/store/test_checkpoint_store.py @@ -9,11 +9,9 @@ import great_expectations.exceptions as ge_exceptions from great_expectations.checkpoint.checkpoint import Checkpoint from great_expectations.core.util import convert_to_json_serializable +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.data_context.data_context import DataContext from great_expectations.data_context.store import CheckpointStore -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) from great_expectations.data_context.types.base import CheckpointConfig from great_expectations.data_context.types.resource_identifiers import ( ConfigurationIdentifier, diff --git a/tests/data_context/store/test_configuration_store.py b/tests/data_context/store/test_configuration_store.py index fbd3bfdcfe8a..54808f9f9843 100644 --- a/tests/data_context/store/test_configuration_store.py +++ b/tests/data_context/store/test_configuration_store.py @@ -10,17 +10,8 @@ import great_expectations.exceptions as ge_exceptions from great_expectations.core.data_context_key import DataContextKey +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.store import ConfigurationStore -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) -from great_expectations.data_context.store.in_memory_store_backend import ( - InMemoryStoreBackend, -) -from great_expectations.data_context.store.tuple_store_backend import ( - TupleFilesystemStoreBackend, - TupleStoreBackend, -) from great_expectations.data_context.types.base import BaseYamlConfig from great_expectations.data_context.types.resource_identifiers import ( ConfigurationIdentifier, diff --git a/tests/data_context/store/test_datasource_store.py b/tests/data_context/store/test_datasource_store.py index 8022688a8c62..cd92f832b3db 100644 --- a/tests/data_context/store/test_datasource_store.py +++ b/tests/data_context/store/test_datasource_store.py @@ -12,14 +12,12 @@ JsonConfigSerializer, ) from great_expectations.core.yaml_handler import YAMLHandler +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.data_context.data_context import DataContext from great_expectations.data_context.data_context_variables import ( DataContextVariableSchema, ) from great_expectations.data_context.store.datasource_store import DatasourceStore -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) from great_expectations.data_context.types.base import ( DatasourceConfig, datasourceConfigSchema, diff --git a/tests/data_context/store/test_datasource_store_cloud_backend.py b/tests/data_context/store/test_datasource_store_cloud_backend.py index 864bebaf718a..33b7cb2fdee6 100644 --- a/tests/data_context/store/test_datasource_store_cloud_backend.py +++ b/tests/data_context/store/test_datasource_store_cloud_backend.py @@ -4,10 +4,8 @@ import pytest from great_expectations.core.serializer import DictConfigSerializer +from great_expectations.data_context.cloud_constants import GeCloudRESTResource from great_expectations.data_context.store import DatasourceStore -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) from great_expectations.data_context.types.base import ( DatasourceConfig, datasourceConfigSchema, diff --git a/tests/data_context/store/test_ge_cloud_store_backend.py b/tests/data_context/store/test_ge_cloud_store_backend.py index 29df904b8324..3bdcdcbddee1 100644 --- a/tests/data_context/store/test_ge_cloud_store_backend.py +++ b/tests/data_context/store/test_ge_cloud_store_backend.py @@ -16,9 +16,11 @@ import pytest -from great_expectations.data_context.cloud_constants import CLOUD_DEFAULT_BASE_URL -from great_expectations.data_context.store.ge_cloud_store_backend import ( +from great_expectations.data_context.cloud_constants import ( + CLOUD_DEFAULT_BASE_URL, GeCloudRESTResource, +) +from great_expectations.data_context.store.ge_cloud_store_backend import ( GeCloudStoreBackend, construct_json_payload, construct_url, diff --git a/tests/data_context/store/test_store_backends.py b/tests/data_context/store/test_store_backends.py index bcf6bfc7e54e..b96892034fe3 100644 --- a/tests/data_context/store/test_store_backends.py +++ b/tests/data_context/store/test_store_backends.py @@ -1,7 +1,6 @@ import datetime import json import os -from collections import OrderedDict from unittest.mock import patch import boto3 @@ -20,7 +19,6 @@ DataContextVariableSchema, ) from great_expectations.data_context.store import ( - GeCloudStoreBackend, InMemoryStoreBackend, StoreBackend, TupleAzureBlobStoreBackend, @@ -28,16 +26,10 @@ TupleGCSStoreBackend, TupleS3StoreBackend, ) -from great_expectations.data_context.store.ge_cloud_store_backend import ( - GeCloudRESTResource, -) from great_expectations.data_context.store.inline_store_backend import ( InlineStoreBackend, ) -from great_expectations.data_context.types.base import ( - CheckpointConfig, - DataContextConfig, -) +from great_expectations.data_context.types.base import DataContextConfig from great_expectations.data_context.types.resource_identifiers import ( ExpectationSuiteIdentifier, ValidationResultIdentifier,