Skip to content

Commit 41475bf

Browse files
korvin89amje
authored andcommitted
feat!: remove configure (i18n from uikit used instead) (#142)
1 parent 6b99075 commit 41475bf

File tree

32 files changed

+57
-119
lines changed

32 files changed

+57
-119
lines changed

.storybook/decorators/withLang.tsx

+1-5
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,10 @@
11
import React from 'react';
22

3-
import {configure as uiKitConfigure} from '@gravity-ui/uikit';
3+
import {configure} from '@gravity-ui/uikit';
44
import type {Decorator} from '@storybook/react';
55

6-
import {configure} from '../../src';
7-
86
export const withLang: Decorator = (Story, context) => {
97
const lang = context.globals.lang;
10-
11-
uiKitConfigure({lang});
128
configure({lang});
139

1410
return <Story key={lang} {...context} />;

src/components/AdaptiveTabs/AdaptiveTabs.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import ResizeObserver from 'resize-observer-polyfill';
99
import {block} from '../utils/cn';
1010

1111
import {DEFAULT_BREAK_POINTS_CONFIG} from './constants';
12-
import i18n from './i18n';
12+
import {i18n} from './i18n';
1313

1414
import './AdaptiveTabs.scss';
1515

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
import {registerKeyset} from '../../utils/registerKeyset';
1+
import {addComponentKeysets} from '@gravity-ui/uikit/i18n';
2+
3+
import {NAMESPACE} from '../../utils/cn';
24

35
import en from './en.json';
46
import ru from './ru.json';
57

6-
const COMPONENT = 'AdaptiveTabs';
7-
export default registerKeyset({en, ru}, COMPONENT);
8+
export const i18n = addComponentKeysets({en, ru}, `${NAMESPACE}adaptive-tabs`);

src/components/ChangelogDialog/ChangelogDialog.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {block} from '../utils/cn';
88

99
import {ErrorContainer} from './components/ErrorContainer/ErrorContainer';
1010
import {Item} from './components/Item/Item';
11-
import i18n from './i18n';
11+
import {i18n} from './i18n';
1212
import type {ChangelogItem} from './types';
1313

1414
import './ChangelogDialog.scss';

src/components/ChangelogDialog/components/ErrorContainer/ErrorContainer.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React from 'react';
22

33
import {Alert} from '@gravity-ui/uikit';
44

5-
import i18n from '../../i18n';
5+
import {i18n} from '../../i18n';
66

77
interface ErrorContainerProps {
88
onRetryClick?: () => void;

src/components/ChangelogDialog/components/Item/Item.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {CirclePlay} from '@gravity-ui/icons';
44
import {Button, Icon, Label} from '@gravity-ui/uikit';
55

66
import {block} from '../../../utils/cn';
7-
import i18n from '../../i18n';
7+
import {i18n} from '../../i18n';
88
import type {ChangelogItem} from '../../types';
99
import {Picture} from '../Picture/Picture';
1010

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import {registerKeyset} from '../../utils/registerKeyset';
1+
import {addComponentKeysets} from '@gravity-ui/uikit/i18n';
2+
3+
import {NAMESPACE} from '../../utils/cn';
24

35
import en from './en.json';
46
import ru from './ru.json';
57

6-
const COMPONENT = 'ChangelogDialog';
7-
8-
export default registerKeyset({en, ru}, COMPONENT);
8+
export const i18n = addComponentKeysets({en, ru}, `${NAMESPACE}changelog-dialog`);

src/components/CookieConsent/components/ConsentNotification/ConsentNotification.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import React from 'react';
33
import {Alert, Button, Link, useMobile} from '@gravity-ui/uikit';
44

55
import {block} from '../../../utils/cn';
6-
import i18n from '../../i18n';
6+
import {i18n} from '../../i18n';
77

88
import {ConsentNotificationProps} from './types';
99

src/components/CookieConsent/components/ConsentPopup/ConsentPopup.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {Button, Icon, Link, Modal, Text, useDirection, useMobile} from '@gravity
66
import {block} from '../../../utils/cn';
77
import {ConsentType} from '../../ConsentManager';
88
import type {Consents} from '../../ConsentManager';
9-
import i18n from '../../i18n';
9+
import {i18n} from '../../i18n';
1010
import {FoldableList} from '../FoldableList/FoldableList';
1111

1212
import {

src/components/CookieConsent/components/SimpleConsent/SimpleConsent.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import React from 'react';
33
import {Button, Portal} from '@gravity-ui/uikit';
44

55
import {block} from '../../../utils/cn';
6-
import i18n from '../../i18n';
6+
import {i18n} from '../../i18n';
77

88
import {SimpleConsentProps} from './types';
99

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
import {registerKeyset} from '../../utils/registerKeyset';
1+
import {addComponentKeysets} from '@gravity-ui/uikit/i18n';
2+
3+
import {NAMESPACE} from '../../utils/cn';
24

35
import en from './en.json';
46
import ru from './ru.json';
57

6-
const COMPONENT = 'CookieConsent';
7-
export default registerKeyset({en, ru}, COMPONENT);
8+
export const i18n = addComponentKeysets({en, ru}, `${NAMESPACE}cookie-consent`);

src/components/FormRow/FormRow.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import React from 'react';
33
import {block} from '../utils/cn';
44

55
import {FormRowFieldDescription} from './FormRowFieldDescription';
6-
import i18n from './i18n';
6+
import {i18n} from './i18n';
77
import {FormRowProps} from './types';
88

99
import './FormRow.scss';

src/components/FormRow/i18n/index.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import {registerKeyset} from '../../utils/registerKeyset';
1+
import {addComponentKeysets} from '@gravity-ui/uikit/i18n';
2+
3+
import {NAMESPACE} from '../../utils/cn';
24

35
import en from './en.json';
46
import ru from './ru.json';
57

6-
const COMPONENT = 'FormRow';
7-
8-
export default registerKeyset({en, ru}, COMPONENT);
8+
export const i18n = addComponentKeysets({en, ru}, `${NAMESPACE}form-row`);

src/components/ItemSelector/ItemSelector.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {Button, Icon, List, ListProps} from '@gravity-ui/uikit';
55

66
import {block} from '../utils/cn';
77

8-
import i18n from './i18n';
8+
import {i18n} from './i18n';
99

1010
import './ItemSelector.scss';
1111

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
import {registerKeyset} from '../../utils/registerKeyset';
1+
import {addComponentKeysets} from '@gravity-ui/uikit/i18n';
2+
3+
import {NAMESPACE} from '../../utils/cn';
24

35
import en from './en.json';
46
import ru from './ru.json';
57

6-
const COMPONENT = 'ItemSelector';
7-
export default registerKeyset({en, ru}, COMPONENT);
8+
export const i18n = addComponentKeysets({en, ru}, `${NAMESPACE}item-selector`);

src/components/Notifications/Notifications.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {NotificationsErrorState} from './NotificationsErrorState';
88
import {NotificationsList} from './NotificationsList';
99
import {NotificationsLoadingState} from './NotificationsLoadingState';
1010
import {NotificationsProps} from './definitions';
11-
import i18n from './i18n';
11+
import {i18n} from './i18n';
1212

1313
import './Notifications.scss';
1414

src/components/Notifications/NotificationsEmptyState.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {Icon} from '@gravity-ui/uikit';
44

55
import {block} from '../utils/cn';
66

7-
import i18n from './i18n/index';
7+
import {i18n} from './i18n/index';
88

99
import './Notifications.scss';
1010

src/components/Notifications/NotificationsErrorState.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {Icon} from '@gravity-ui/uikit';
44

55
import {block} from '../utils/cn';
66

7-
import i18n from './i18n/index';
7+
import {i18n} from './i18n/index';
88

99
import './Notifications.scss';
1010

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
import {registerKeyset} from '../../utils/registerKeyset';
1+
import {addComponentKeysets} from '@gravity-ui/uikit/i18n';
2+
3+
import {NAMESPACE} from '../../utils/cn';
24

35
import en from './en.json';
46
import ru from './ru.json';
57

6-
const COMPONENT = 'Notifications';
7-
export default registerKeyset({en, ru}, COMPONENT);
8+
export const i18n = addComponentKeysets({en, ru}, `${NAMESPACE}notifications`);

src/components/PasswordInput/PasswordInput.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212

1313
import {block} from '../utils/cn';
1414

15-
import i18n from './i18n';
15+
import {i18n} from './i18n';
1616
import {getActionButtonSizeAndIconSize} from './utils';
1717

1818
import './PasswordInput.scss';
+4-4
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import {registerKeyset} from '../../utils/registerKeyset';
1+
import {addComponentKeysets} from '@gravity-ui/uikit/i18n';
2+
3+
import {NAMESPACE} from '../../utils/cn';
24

35
import en from './en.json';
46
import ru from './ru.json';
57

6-
const COMPONENT = 'PasswordInput';
7-
8-
export default registerKeyset({en, ru}, COMPONENT);
8+
export const i18n = addComponentKeysets({en, ru}, `${NAMESPACE}password-input`);

src/components/SharePopover/ShareList/ShareList.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {block} from '../../utils/cn';
88
import {isOfType} from '../../utils/isOfType';
99
import {ShareListItem} from '../ShareListItem/ShareListItem';
1010
import type {LayoutDirection, ShareOptions} from '../constants';
11-
import i18n from '../i18n';
11+
import {i18n} from '../i18n';
1212
import type {ShareOptionsData} from '../models';
1313

1414
import './ShareList.scss';

src/components/SharePopover/ShareListItem/ShareListItem.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import type {IconData} from '@gravity-ui/uikit';
55

66
import {block} from '../../utils/cn';
77
import {LayoutDirection, ShareOptions} from '../constants';
8-
import i18n from '../i18n';
8+
import {i18n} from '../i18n';
99
import * as icons from '../icons';
1010
import type {ShareOptionsData} from '../models';
1111

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import {registerKeyset} from '../../utils/registerKeyset';
1+
import {addComponentKeysets} from '@gravity-ui/uikit/i18n';
2+
3+
import {NAMESPACE} from '../../utils/cn';
24

35
import en from './en.json';
46
import ru from './ru.json';
57

6-
const COMPONENT = 'SharePopover';
7-
8-
export default registerKeyset({en, ru}, COMPONENT);
8+
export const i18n = addComponentKeysets({en, ru}, `${NAMESPACE}share-popover`);

src/components/StoreBadge/StoreBadge.tsx

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
import React from 'react';
22

3-
import {Icon, Link, LinkProps} from '@gravity-ui/uikit';
3+
import {Icon, Lang, Link, LinkProps} from '@gravity-ui/uikit';
44

5-
import {i18n} from '../../i18n';
65
import {AppStoreEn} from '../../icons/stores/AppStoreEn';
76
import {AppStoreRu} from '../../icons/stores/AppStoreRu';
87
import {GooglePlayEn} from '../../icons/stores/GooglePlayEn';
98
import {GooglePlayRu} from '../../icons/stores/GooglePlayRu';
109
import {cn} from '../utils/cn';
11-
import {Lang} from '../utils/configure';
1210

1311
const b = cn('store-badge');
1412

@@ -20,6 +18,7 @@ export type StoreBadgePlatform = typeof androidPlatform | typeof iosPlatform;
2018
export interface StoreBadgeProps extends Omit<LinkProps, 'view' | 'onClick'> {
2119
/** store platform name */
2220
platform: StoreBadgePlatform;
21+
lang?: `${Lang}`;
2322
onClick?: React.MouseEventHandler<HTMLElement>;
2423
}
2524

@@ -42,9 +41,10 @@ export const StoreBadge = ({
4241
className,
4342
onClick,
4443
href,
44+
lang = Lang.En,
4545
...restLinkProps
4646
}: StoreBadgeProps) => {
47-
const lang = i18n.lang as Lang;
47+
// const lang = i18n.lang as Lang;
4848
const iconData = badgeData?.[platform][lang];
4949

5050
if (!iconData) {

src/components/Stories/components/StoriesLayout/StoriesLayout.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import type {ButtonProps} from '@gravity-ui/uikit';
66

77
import {MediaRenderer} from '..';
88
import {block} from '../../../utils/cn';
9-
import i18n from '../../i18n';
9+
import {i18n} from '../../i18n';
1010
import type {StoriesItem} from '../../types';
1111

1212
import './StoriesLayout.scss';

src/components/Stories/i18n/index.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import {registerKeyset} from '../../utils/registerKeyset';
1+
import {addComponentKeysets} from '@gravity-ui/uikit/i18n';
2+
3+
import {NAMESPACE} from '../../utils/cn';
24

35
import en from './en.json';
46
import ru from './ru.json';
57

6-
const COMPONENT = 'Stories';
7-
8-
export default registerKeyset({en, ru}, COMPONENT);
8+
export const i18n = addComponentKeysets({en, ru}, `${NAMESPACE}stories`);

src/components/index.ts

-2
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,3 @@ export * from './SharePopover';
1717
export * from './StoreBadge';
1818
export * from './Stories';
1919
export * from './StoriesGroup';
20-
21-
export {Lang, configure} from './utils/configure';

src/components/utils/configure.ts

-33
This file was deleted.

src/components/utils/registerKeyset.ts

-11
This file was deleted.

src/i18n.ts

-11
This file was deleted.

test-utils/setup-tests.ts

-5
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
11
import {configure} from '@testing-library/dom';
22

3-
import {Lang, configure as libConfigure} from '../src';
4-
5-
libConfigure({
6-
lang: Lang.En,
7-
});
83
configure({testIdAttribute: 'data-qa'});
94

105
global.ResizeObserver = class implements ResizeObserver {

0 commit comments

Comments
 (0)