build: rename to TS eslint rules and temporarily disable eslint rules

Author: saihaj

.eslintrc.yml

@@ -457,22 +457,21 @@ overrides:
       '@typescript-eslint/await-thenable': error
       '@typescript-eslint/ban-ts-comment': [error, { 'ts-expect-error': false }]
       '@typescript-eslint/ban-tslint-comment': error
-      '@typescript-eslint/ban-types': error
+      '@typescript-eslint/ban-types': off # TODO temporarily disabled
       '@typescript-eslint/class-literal-property-style': off # TODO enable after TS conversion
       '@typescript-eslint/consistent-indexed-object-style': off # TODO enable after TS conversion
-      '@typescript-eslint/consistent-type-assertions':
-        [error, { assertionStyle: as, objectLiteralTypeAssertions: never }]
-      '@typescript-eslint/consistent-type-definitions': off # TODO consider
-      '@typescript-eslint/consistent-type-imports': off # TODO enable after TS conversion
+      '@typescript-eslint/consistent-type-assertions': off # TODO temporarily disable
+      '@typescript-eslint/consistent-type-definitions': error
+      '@typescript-eslint/consistent-type-imports': error
       '@typescript-eslint/explicit-function-return-type': off # TODO consider
       '@typescript-eslint/explicit-member-accessibility': off # TODO consider
       '@typescript-eslint/explicit-module-boundary-types': off # TODO consider
-      '@typescript-eslint/member-ordering': off # TODO consider
+      '@typescript-eslint/member-ordering': error
       '@typescript-eslint/method-signature-style': error
       '@typescript-eslint/naming-convention': off # TODO consider
       '@typescript-eslint/no-base-to-string': error
       '@typescript-eslint/no-confusing-non-null-assertion': error
-      '@typescript-eslint/no-confusing-void-expression': error
+      '@typescript-eslint/no-confusing-void-expression': off # TODO enable with ignoreArrowShorthand
       '@typescript-eslint/no-dynamic-delete': off
       '@typescript-eslint/no-empty-interface': error
       '@typescript-eslint/no-explicit-any': off # TODO error
@@ -494,21 +493,21 @@ overrides:
       '@typescript-eslint/no-require-imports': error
       '@typescript-eslint/no-this-alias': error
       '@typescript-eslint/no-type-alias': off # TODO consider
-      '@typescript-eslint/no-unnecessary-boolean-literal-compare': error
-      '@typescript-eslint/no-unnecessary-condition': error
+      '@typescript-eslint/no-unnecessary-boolean-literal-compare': off # FIXME requires on strictNullChecks
+      '@typescript-eslint/no-unnecessary-condition': off # TODO temporary disable
       '@typescript-eslint/no-unnecessary-qualifier': error
       '@typescript-eslint/no-unnecessary-type-arguments': error
       '@typescript-eslint/no-unnecessary-type-assertion': error
-      '@typescript-eslint/no-unnecessary-type-constraint': off # TODO consider
+      '@typescript-eslint/no-unnecessary-type-constraint': error
       '@typescript-eslint/no-unsafe-argument': off # TODO consider
       '@typescript-eslint/no-unsafe-assignment': off # TODO consider
       '@typescript-eslint/no-unsafe-call': off # TODO consider
       '@typescript-eslint/no-unsafe-member-access': off # TODO consider
       '@typescript-eslint/no-unsafe-return': off # TODO consider
       '@typescript-eslint/no-var-requires': error
-      '@typescript-eslint/non-nullable-type-assertion-style': error
-      '@typescript-eslint/prefer-as-const': off # TODO consider
-      '@typescript-eslint/prefer-enum-initializers': off # TODO consider
+      '@typescript-eslint/non-nullable-type-assertion-style': off #TODO temporarily disabled
+      '@typescript-eslint/prefer-as-const': error
+      '@typescript-eslint/prefer-enum-initializers': error
       '@typescript-eslint/prefer-for-of': off # TODO switch to error after TS migration
       '@typescript-eslint/prefer-function-type': error
       '@typescript-eslint/prefer-includes': off # TODO switch to error after IE11 drop
@@ -524,12 +523,11 @@ overrides:
       '@typescript-eslint/prefer-string-starts-ends-with': off # TODO switch to error after IE11 drop
       '@typescript-eslint/promise-function-async': off
       '@typescript-eslint/require-array-sort-compare': error
-      '@typescript-eslint/restrict-plus-operands':
-        [error, { checkCompoundAssignments: true }]
-      '@typescript-eslint/restrict-template-expressions': error
+      '@typescript-eslint/restrict-plus-operands': off #TODO temporarily disabled
+      '@typescript-eslint/restrict-template-expressions': off #TODO temporarily disabled
       '@typescript-eslint/sort-type-union-intersection-members': off # TODO consider
       '@typescript-eslint/strict-boolean-expressions': off # TODO consider
-      '@typescript-eslint/switch-exhaustiveness-check': error
+      '@typescript-eslint/switch-exhaustiveness-check': off #TODO temporarily disabled
       '@typescript-eslint/triple-slash-reference': error
       '@typescript-eslint/typedef': off
       '@typescript-eslint/unbound-method': off # TODO consider

src/execution/__tests__/executor-test.ts

@@ -443,7 +443,7 @@ describe('Execute: Handles basic execution tasks', () => {
         throw new Error('Error getting syncError');
       },
       syncRawError() {
-        // eslint-disable-next-line no-throw-literal
+        // eslint-disable-next-line @typescript-eslint/no-throw-literal
         throw 'Error getting syncRawError';
       },
       syncReturnError() {
@@ -480,7 +480,7 @@ describe('Execute: Handles basic execution tasks', () => {
       },
       asyncRawError() {
         return new Promise(() => {
-          // eslint-disable-next-line no-throw-literal
+          // eslint-disable-next-line @typescript-eslint/no-throw-literal
           throw 'Error getting asyncRawError';
         });
       },

src/jsutils/__tests__/inspect-test.ts

@@ -171,7 +171,7 @@ describe('inspect', () => {
 
     // eslint-disable-next-line func-names
     const objectWithoutClassName = new (function () {
-      // eslint-disable-next-line no-invalid-this
+      // eslint-disable-next-line @typescript-eslint/no-invalid-this
       this.foo = 1;
     })();
     expect(inspect([[objectWithoutClassName]])).to.equal('[[[Object]]]');

src/subscription/__tests__/mapAsyncIterator-test.ts

@@ -3,6 +3,7 @@ import { describe, it } from 'mocha';
 
 import { mapAsyncIterator } from '../mapAsyncIterator';
 
+/* eslint-disable @typescript-eslint/require-await */
 describe('mapAsyncIterator', () => {
   it('maps over async generator', async () => {
     async function* source() {

src/subscription/__tests__/subscribe-test.ts

@@ -150,6 +150,7 @@ const DummyQueryType = new GraphQLObjectType({
   },
 });
 
+/* eslint-disable @typescript-eslint/require-await */
 // Check all error cases when initializing the subscription.
 describe('Subscription Initialization Phase', () => {
   it('accepts multiple subscription fields defined in schema', async () => {

src/utilities/buildClientSchema.ts

@@ -171,6 +171,7 @@ export function buildClientSchema(
   // Given a type's introspection result, construct the correct
   // GraphQLType instance.
   function buildType(type: IntrospectionType): GraphQLNamedType {
+    // eslint-disable-next-line @typescript-eslint/prefer-optional-chain
     if (type != null && type.name != null && type.kind != null) {
       switch (type.kind) {
         case TypeKind.SCALAR:

src/validation/validate.ts

@@ -57,6 +57,7 @@ export function validate(
             'Too many validation errors, error limit reached. Validation aborted.',
           ),
         );
+        // eslint-disable-next-line @typescript-eslint/no-throw-literal
         throw abortObj;
       }
       errors.push(error);