Follow-ups from the review of #6660.
Int8 support (comment)
Map mid-size Solidity ints (signed 33-64 bits, unsigned 25-63) to Int8 instead of BigInt. The schema scaffold and the ABI codegen need to change together: the generated getter would chain .toBigInt().toI64() since ethereum.Value has no i64 accessor. The entity side already supports Int8. Before adding the band, consolidate the int width cutoff into one shared helper — it's currently duplicated in scaffold/schema.rs and ~8 places in codegen/abi.rs.
Duplicate-name corner cases (comment)
All of these produce a duplicate name in the generated output, so the build fails:
add: an entity renamed on collision isn't checked against the other events in the same batch. Existing Transfer + ABI with Transfer and TokenTransfer → TokenTransfer declared twice.- Two params that sanitize to the same field name aren't deduped (e.g. two unnamed params both become
value). The accessor side already dedupes (param0, param1); the field side should too.
- The overload suffix can clash with a real event:
Transfer, Transfer, Transfer1 → two Transfer1s. Bump the counter until the name is free.
- An unparseable schema.graphql silently disables collision detection in
add. Should log a warning.
Follow-ups from the review of #6660.
Int8 support (comment)
Map mid-size Solidity ints (signed 33-64 bits, unsigned 25-63) to
Int8instead ofBigInt. The schema scaffold and the ABI codegen need to change together: the generated getter would chain.toBigInt().toI64()sinceethereum.Valuehas no i64 accessor. The entity side already supportsInt8. Before adding the band, consolidate the int width cutoff into one shared helper — it's currently duplicated inscaffold/schema.rsand ~8 places incodegen/abi.rs.Duplicate-name corner cases (comment)
All of these produce a duplicate name in the generated output, so the build fails:
add: an entity renamed on collision isn't checked against the other events in the same batch. ExistingTransfer+ ABI withTransferandTokenTransfer→TokenTransferdeclared twice.value). The accessor side already dedupes (param0,param1); the field side should too.Transfer,Transfer,Transfer1→ twoTransfer1s. Bump the counter until the name is free.add. Should log a warning.