Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xk6 topic should not be a requirement for internal extensions #90

Closed
szkiba opened this issue Oct 11, 2024 · 0 comments · Fixed by #91
Closed

xk6 topic should not be a requirement for internal extensions #90

szkiba opened this issue Oct 11, 2024 · 0 comments · Fixed by #91
Assignees

Comments

@szkiba
Copy link
Collaborator

szkiba commented Oct 11, 2024

The internal linter currently expects the xk6 topic to be set on the extensions repository. In the case of internal (but public) extensions, it would not be a good idea to use the xk6 topic, because that would cause them to appear in the GitHub topic search.

The internal linter should not expect the xk6 topic to be set for extensions that do not have oss in their products property. That is, in the case of extensions that cannot be used in Grafana k6, the use of the xk6 topic should not be required.

@szkiba szkiba self-assigned this Oct 11, 2024
@szkiba szkiba linked a pull request Oct 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant