Skip to content

Commit 1145525

Browse files
committed
use a second client in the test
Signed-off-by: Grant Linville <[email protected]>
1 parent eda15f3 commit 1145525

File tree

2 files changed

+16
-13
lines changed

2 files changed

+16
-13
lines changed

datasets.go

+4-5
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import (
44
"context"
55
"encoding/json"
66
"fmt"
7-
"os"
87
)
98

109
type DatasetElementMeta struct {
@@ -50,7 +49,7 @@ func (g *GPTScript) ListDatasets(ctx context.Context) ([]DatasetMeta, error) {
5049
out, err := g.runBasicCommand(ctx, "datasets", datasetRequest{
5150
Input: "{}",
5251
DatasetTool: g.globalOpts.DatasetTool,
53-
Env: append(g.globalOpts.Env, "GPTSCRIPT_WORKSPACE_ID="+os.Getenv("GPTSCRIPT_WORKSPACE_ID")),
52+
Env: g.globalOpts.Env,
5453
})
5554
if err != nil {
5655
return nil, err
@@ -94,7 +93,7 @@ func (g *GPTScript) AddDatasetElements(ctx context.Context, datasetID string, el
9493
return g.runBasicCommand(ctx, "datasets/add-elements", datasetRequest{
9594
Input: string(argsJSON),
9695
DatasetTool: g.globalOpts.DatasetTool,
97-
Env: append(g.globalOpts.Env, "GPTSCRIPT_WORKSPACE_ID="+os.Getenv("GPTSCRIPT_WORKSPACE_ID")),
96+
Env: g.globalOpts.Env,
9897
})
9998
}
10099

@@ -110,7 +109,7 @@ func (g *GPTScript) ListDatasetElements(ctx context.Context, datasetID string) (
110109
out, err := g.runBasicCommand(ctx, "datasets/list-elements", datasetRequest{
111110
Input: string(argsJSON),
112111
DatasetTool: g.globalOpts.DatasetTool,
113-
Env: append(g.globalOpts.Env, "GPTSCRIPT_WORKSPACE_ID="+os.Getenv("GPTSCRIPT_WORKSPACE_ID")),
112+
Env: g.globalOpts.Env,
114113
})
115114
if err != nil {
116115
return nil, err
@@ -136,7 +135,7 @@ func (g *GPTScript) GetDatasetElement(ctx context.Context, datasetID, elementNam
136135
out, err := g.runBasicCommand(ctx, "datasets/get-element", datasetRequest{
137136
Input: string(argsJSON),
138137
DatasetTool: g.globalOpts.DatasetTool,
139-
Env: append(g.globalOpts.Env, "GPTSCRIPT_WORKSPACE_ID="+os.Getenv("GPTSCRIPT_WORKSPACE_ID")),
138+
Env: g.globalOpts.Env,
140139
})
141140
if err != nil {
142141
return DatasetElement{}, err

datasets_test.go

+12-8
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,17 @@ func TestDatasets(t *testing.T) {
1212
workspaceID, err := g.CreateWorkspace(context.Background(), "directory")
1313
require.NoError(t, err)
1414

15-
require.NoError(t, os.Setenv("GPTSCRIPT_WORKSPACE_ID", workspaceID))
15+
client, err := NewGPTScript(GlobalOptions{
16+
OpenAIAPIKey: os.Getenv("OPENAI_API_KEY"),
17+
Env: []string{"GPTSCRIPT_WORKSPACE_ID=" + workspaceID},
18+
})
19+
require.NoError(t, err)
1620

1721
defer func() {
1822
_ = g.DeleteWorkspace(context.Background(), workspaceID)
1923
}()
2024

21-
datasetID, err := g.CreateDatasetWithElements(context.Background(), []DatasetElement{
25+
datasetID, err := client.CreateDatasetWithElements(context.Background(), []DatasetElement{
2226
{
2327
DatasetElementMeta: DatasetElementMeta{
2428
Name: "test-element-1",
@@ -33,7 +37,7 @@ func TestDatasets(t *testing.T) {
3337
require.NoError(t, err)
3438

3539
// Add three more elements
36-
_, err = g.AddDatasetElements(context.Background(), datasetID, []DatasetElement{
40+
_, err = client.AddDatasetElements(context.Background(), datasetID, []DatasetElement{
3741
{
3842
DatasetElementMeta: DatasetElementMeta{
3943
Name: "test-element-2",
@@ -59,33 +63,33 @@ func TestDatasets(t *testing.T) {
5963
require.NoError(t, err)
6064

6165
// Get the first element
62-
element, err := g.GetDatasetElement(context.Background(), datasetID, "test-element-1")
66+
element, err := client.GetDatasetElement(context.Background(), datasetID, "test-element-1")
6367
require.NoError(t, err)
6468
require.Equal(t, "test-element-1", element.Name)
6569
require.Equal(t, "This is a test element 1", element.Description)
6670
require.Equal(t, "This is the content 1", element.Contents)
6771

6872
// Get the third element
69-
element, err = g.GetDatasetElement(context.Background(), datasetID, "test-element-3")
73+
element, err = client.GetDatasetElement(context.Background(), datasetID, "test-element-3")
7074
require.NoError(t, err)
7175
require.Equal(t, "test-element-3", element.Name)
7276
require.Equal(t, "This is a test element 3", element.Description)
7377
require.Equal(t, "This is the content 3", element.Contents)
7478

7579
// Get the binary element
76-
element, err = g.GetDatasetElement(context.Background(), datasetID, "binary-element")
80+
element, err = client.GetDatasetElement(context.Background(), datasetID, "binary-element")
7781
require.NoError(t, err)
7882
require.Equal(t, "binary-element", element.Name)
7983
require.Equal(t, "this element has binary contents", element.Description)
8084
require.Equal(t, []byte("binary contents"), element.BinaryContents)
8185

8286
// List elements in the dataset
83-
elements, err := g.ListDatasetElements(context.Background(), datasetID)
87+
elements, err := client.ListDatasetElements(context.Background(), datasetID)
8488
require.NoError(t, err)
8589
require.Equal(t, 4, len(elements))
8690

8791
// List datasets
88-
datasets, err := g.ListDatasets(context.Background())
92+
datasets, err := client.ListDatasets(context.Background())
8993
require.NoError(t, err)
9094
require.Equal(t, 1, len(datasets))
9195
require.Equal(t, datasetID, datasets[0].ID)

0 commit comments

Comments
 (0)