Skip to content

eventsExecutorService: how does it work? #49

@HelgeStenstrom

Description

@HelgeStenstrom

Can you please explain a bit how this works:

/**
* Notify listeners about a BasicPlayerEvent.
*
* @param status event code.
* @param encodedStreamPosition in the stream when the event occurs.
* @param description the description
*
* @return A String Describing if any problem occurred
*/
private String generateEvent(final Status status, final int encodedStreamPosition, final Object description) {
try {
return eventsExecutorService
.submit(new StreamPlayerEventLauncher(this, status, encodedStreamPosition, description, listeners))
.get();
} catch (InterruptedException | ExecutionException ex) {
logger.log(Level.WARNING, "Problem in StreamPlayer generateEvent() method", ex);
}
return "Problem in StreamPlayer generateEvent() method";
}

From what I understand, there is a StreamPlayerEventLauncher task which holds information about source, player position, a list of listeners and some other stuff.

The task is submitted to eventsExecutorService.submit(task) and returns a Future.

Then .get() is called on this object. get() blocks until the task is done, i.e., until all listeners have been notified by the call() method of the StreamPlayerEventLauncher.

Since get() is blocking, I wonder why this has to be in a separate thread. What is the lifetime of the thread? It seems to be extremely short, or am I wrong?

Wouldn't the behavior be the same with a simple
new StreamPlayerEventLauncher(this, status, encodedStreamPosition, description, listeners).call();

and no eventsExecutorService at all?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions