[1.16.5] Using versions later than 1.3.0 causes internal server lock with world start with modded biomes

[Kaleidio]

Been dealing with this issue for months now, at first I thought it was some sort of conflict, but after some investigation it seems to be an issue very particular to adding modded biomes into the mix. I have a feeling this has to do with Treasure related code, as it only breaks if you are spawning in a modded biome (BYG Rainbow Beach for example, with correct ocean biomes around it)

Yes this is a continuation of an issue that has been since deleted, however it is still relevant and this time around I have more information, even if the log still spells literally nothing for us sadly...

You can reproduce the issue by installing BYG, Gottschcore. Additionally you can install Ksyxis to tell if the world is about to lock your server up by watching generation go past 0% for no reason (usually an indication of a structure generator forcing itself when it shouldn't. Ksyxis should always cause that screen to stay at 0% before spawning the player into the world). note that the freeze is rare.

[gottsch]

Do you still have this issue with the latest version of Treasure (v2.3) - it came out on the 1/3 ?

[Kaleidio]

I don't have treasure installed, I think it's library code meant to tie in treasure at fault. and yes the issue still exists.

[Kaleidio]

https://github.com/gottsch/gottsch-minecraft-GottschCore/tree/master/src/main/java/com/someguyssoftware/gottschcore/biome

everything located in this directory may be failing.

[Kaleidio]

I see a lot of references in this code that sort of rebuild everything forge already provides in its API. this isn't safe for mods as some mods may be providing completely custom tags and biome noise/accessor classes (especially BYG). Most of these classes, which also seem to be singletons, should be replaced with actual Forge references instead, to make sure everything registered is as dynamic as can be.