From c04ba4d8d9945b620be065b4686e66be891b9f7b Mon Sep 17 00:00:00 2001
From: nihonium <nihonium@fivem.net>
Date: Thu, 23 Nov 2023 10:35:15 +0100
Subject: [PATCH] tweak(ci): run dependant jobs on_success instead of always so
 that they don't run if dependency job failed

---
 .gitlab-ci.yml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 268241da4c..c47264eb84 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -28,14 +28,14 @@ workflow:
 .only_for_release:
   rules:
     - if: $CFX_RELEASE_BUILD == 'true'
-      when: always
+      when: on_success
     - when: never
 
 # helper for jobs that are only meant to be run on master branch
 .only_for_master:
   rules:
     - if: $CFX_RELEASE_BUILD == 'true' && $CI_COMMIT_BRANCH == 'master'
-      when: always
+      when: on_success
     - when: never
 
 # helper for windows builds of clients and server
@@ -191,7 +191,7 @@ fivem_deploy_canary:
     name: canary
   rules:
     - if: $CFX_RELEASE_BUILD == 'true' && $CI_COMMIT_BRANCH == 'master'
-      when: always
+      when: on_success
     - when: never
 
 fivem_deploy_beta:
@@ -200,7 +200,7 @@ fivem_deploy_beta:
     name: beta
   rules:
     - if: $CFX_RELEASE_BUILD == 'true' && $CI_COMMIT_BRANCH == 'beta'
-      when: always
+      when: on_success
     - when: never
 
 fivem_deploy_production:
@@ -209,7 +209,7 @@ fivem_deploy_production:
     name: production
   rules:
     - if: $CFX_RELEASE_BUILD == 'true' && $CI_COMMIT_BRANCH == 'production'
-      when: always
+      when: on_success
     - when: never
 
 fivem_deploy_specific:
@@ -229,7 +229,7 @@ redm_deploy_canary:
     name: canary
   rules:
     - if: $CFX_RELEASE_BUILD == 'true' && $CI_COMMIT_BRANCH == 'master'
-      when: always
+      when: on_success
     - when: never
 
 redm_deploy_beta:
@@ -238,7 +238,7 @@ redm_deploy_beta:
     name: beta
   rules:
     - if: $CFX_RELEASE_BUILD == 'true' && $CI_COMMIT_BRANCH == 'beta'
-      when: always
+      when: on_success
     - when: never
 
 redm_deploy_production:
@@ -247,7 +247,7 @@ redm_deploy_production:
     name: production
   rules:
     - if: $CFX_RELEASE_BUILD == 'true' && $CI_COMMIT_BRANCH == 'production'
-      when: always
+      when: on_success
     - when: never
 
 redm_deploy_specific: