Skip to content

Commit adc69dc

Browse files
authored
Merge pull request NVIDIA#884 from elezar/use-only-ubi8-images
Remove Ubuntu 22.04 images
2 parents 650a3af + 7cea228 commit adc69dc

File tree

8 files changed

+7
-136
lines changed

8 files changed

+7
-136
lines changed

.common-ci.yml

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,6 @@ trigger-pipeline:
7373
variables:
7474
DIST: "ubi8"
7575

76-
.dist-ubuntu22.04:
77-
variables:
78-
DIST: "ubuntu22.04"
79-
8076
# Define the platform targets
8177
.platform-amd64:
8278
variables:
@@ -123,23 +119,6 @@ trigger-pipeline:
123119
- .scan-base
124120

125121
# Define the scan targets
126-
scan-ubuntu22.04-amd64:
127-
extends:
128-
- .scan
129-
- .dist-ubuntu22.04
130-
- .platform-amd64
131-
needs:
132-
- image-ubuntu22.04
133-
134-
scan-ubuntu22.04-arm64:
135-
extends:
136-
- .scan
137-
- .dist-ubuntu22.04
138-
- .platform-arm64
139-
needs:
140-
- image-ubuntu22.04
141-
- scan-ubuntu22.04-amd64
142-
143122
scan-ubi8-amd64:
144123
extends:
145124
- .scan
@@ -230,10 +209,3 @@ release:staging-ubi8:
230209
- .dist-ubi8
231210
needs:
232211
- image-ubi8
233-
234-
release:staging-ubuntu22.04:
235-
extends:
236-
- .release:staging
237-
- .dist-ubuntu22.04
238-
needs:
239-
- image-ubuntu22.04

.github/workflows/image.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,6 @@ on:
3131
jobs:
3232
build:
3333
runs-on: ubuntu-latest
34-
strategy:
35-
matrix:
36-
dist: [ubuntu22.04, ubi8]
3734
steps:
3835
- uses: actions/checkout@v4
3936
name: Check out code
@@ -72,4 +69,4 @@ jobs:
7269
VERSION: ${COMMIT_SHORT_SHA}
7370
run: |
7471
echo "${VERSION}"
75-
make -f deployments/container/Makefile build-${{ matrix.dist }}
72+
make -f deployments/container/Makefile build

.nvidia-ci.yml

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,6 @@ image-ubi8:
7070
- .image-pull
7171
- .dist-ubi8
7272

73-
image-ubuntu22.04:
74-
extends:
75-
- .image-pull
76-
- .dist-ubuntu22.04
77-
7873
# We skip the integration tests for the internal CI:
7974
.integration:
8075
stage: test
@@ -118,11 +113,6 @@ image-ubuntu22.04:
118113

119114
# Define the external release targets
120115
# Release to NGC
121-
release:ngc-ubuntu22.04:
122-
extends:
123-
- .release:ngc
124-
- .dist-ubuntu22.04
125-
126116
release:ngc-ubi8:
127117
extends:
128118
- .release:ngc
@@ -170,17 +160,10 @@ sign:ngc-short-tag:
170160
extends:
171161
- .sign:ngc
172162
needs:
173-
- release:ngc-ubuntu22.04
163+
- release:ngc-ubi8
174164
variables:
175165
IMAGE_TAG: "${CI_COMMIT_TAG}"
176166

177-
sign:ngc-ubuntu22.04:
178-
extends:
179-
- .dist-ubuntu22.04
180-
- .sign:ngc
181-
needs:
182-
- release:ngc-ubuntu22.04
183-
184167
sign:ngc-ubi8:
185168
extends:
186169
- .dist-ubi8

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -951,7 +951,7 @@ Option 2, build without cloning the repository:
951951
```shell
952952
$ docker build \
953953
-t nvcr.io/nvidia/k8s-device-plugin:devel \
954-
-f deployments/container/Dockerfile.ubuntu \
954+
-f deployments/container/Dockerfile \
955955
https://github.com/NVIDIA/k8s-device-plugin.git#v0.16.2
956956
```
957957

@@ -960,7 +960,7 @@ Option 3, if you want to modify the code:
960960
$ git clone https://github.com/NVIDIA/k8s-device-plugin.git && cd k8s-device-plugin
961961
$ docker build \
962962
-t nvcr.io/nvidia/k8s-device-plugin:devel \
963-
-f deployments/container/Dockerfile.ubuntu \
963+
-f deployments/container/Dockerfile \
964964
.
965965
```
966966

demo/clusters/kind/scripts/common.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ DRIVER_IMAGE_REGISTRY=$(from_versions_mk "REGISTRY")
3030
DRIVER_IMAGE_VERSION=$(from_versions_mk "VERSION")
3131

3232
: ${DRIVER_IMAGE_NAME:=${DRIVER_NAME}}
33-
: ${DRIVER_IMAGE_PLATFORM:="ubuntu22.04"}
3433
: ${DRIVER_IMAGE_TAG:=${DRIVER_IMAGE_VERSION}}
3534
# The derived name of the driver image to build
3635
: ${DRIVER_IMAGE:="${DRIVER_IMAGE_REGISTRY}/${DRIVER_IMAGE_NAME}:${DRIVER_IMAGE_TAG}"}

deployments/container/Dockerfile.ubuntu

Lines changed: 0 additions & 76 deletions
This file was deleted.

deployments/container/Makefile

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ OUT_IMAGE_TAG = $(OUT_IMAGE_VERSION)-$(DIST)
3838
OUT_IMAGE = $(OUT_IMAGE_NAME):$(OUT_IMAGE_TAG)
3939

4040
##### Public rules #####
41-
DEFAULT_PUSH_TARGET := ubuntu22.04
42-
DISTRIBUTIONS = $(DEFAULT_PUSH_TARGET) ubi8
41+
DEFAULT_PUSH_TARGET := ubi8
42+
DISTRIBUTIONS = $(DEFAULT_PUSH_TARGET)
4343

4444
IMAGE_TARGETS := $(patsubst %,image-%,$(DISTRIBUTIONS))
4545
BUILD_TARGETS := $(patsubst %,build-%,$(DISTRIBUTIONS))
@@ -69,7 +69,7 @@ push-%: DIST = $(*)
6969
push-short: DIST = $(DEFAULT_PUSH_TARGET)
7070

7171
build-%: DIST = $(*)
72-
build-%: DOCKERFILE = $(CURDIR)/deployments/container/Dockerfile.$(DOCKERFILE_SUFFIX)
72+
build-%: DOCKERFILE = $(CURDIR)/deployments/container/Dockerfile
7373

7474
# Use a generic build target to build the relevant images
7575
$(IMAGE_TARGETS): image-%:
@@ -86,10 +86,6 @@ $(IMAGE_TARGETS): image-%:
8686
-f $(DOCKERFILE) \
8787
$(CURDIR)
8888

89-
build-ubuntu%: DOCKERFILE_SUFFIX := ubuntu
90-
91-
build-ubi8: DOCKERFILE_SUFFIX := ubi8
92-
9389
# Handle the default build target.
9490
.PHONY: build
9591
build: $(DEFAULT_PUSH_TARGET)

0 commit comments

Comments
 (0)